You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/11 17:33:31 UTC

[GitHub] [tvm] driazati opened a new pull request, #10964: [ci] Add branch protections to .asf.yaml

driazati opened a new pull request, #10964:
URL: https://github.com/apache/tvm/pull/10964

   Moving these into the repo means we will be able to change them at-will.
   `tvm-ci/pr-merge` will change soon into `tvm-ci/pr-head` to fix an
   unrelated bug, but codifying it here means we can more easily coordinate
   the change.
   
   Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch merged pull request #10964: [ci] Add branch protections to .asf.yaml

Posted by GitBox <gi...@apache.org>.
areusch merged PR #10964:
URL: https://github.com/apache/tvm/pull/10964


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] driazati commented on pull request #10964: [ci] Add branch protections to .asf.yaml

Posted by GitBox <gi...@apache.org>.
driazati commented on PR #10964:
URL: https://github.com/apache/tvm/pull/10964#issuecomment-1096999659

   Those steps sound reasonable to me
   
   
   
   > btw @driazati on a separate topic, any background reading about `pr-head`?
   
   It's to fix the CI behavior where editing your PR title/body would trigger a CI rebuild even if no code was pushed, see https://github.com/apache/tvm/pull/10778 for detaisls


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #10964: [ci] Add branch protections to .asf.yaml

Posted by GitBox <gi...@apache.org>.
tqchen commented on PR #10964:
URL: https://github.com/apache/tvm/pull/10964#issuecomment-1097006790

   I see, thanks, I just searched around and did not find a lot about pr-head, would be nice to have a link to doc if there is any, but not required for the pr


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #10964: [ci] Add branch protections to .asf.yaml

Posted by GitBox <gi...@apache.org>.
areusch commented on PR #10964:
URL: https://github.com/apache/tvm/pull/10964#issuecomment-1095666525

   cc @tqchen did we figure out where the current restriction is?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #10964: [ci] Add branch protections to .asf.yaml

Posted by GitBox <gi...@apache.org>.
tqchen commented on PR #10964:
URL: https://github.com/apache/tvm/pull/10964#issuecomment-1096994181

   current requirment is indeed pr-merge. When we change to pr-head, likely we want to do it carefully in a few steps(to avoid need to go through ASF-infra)
   
   - Start with requiring pr-merge
   - Send PR to change to a different requirement
   - Update the config to require that
   
   btw @driazati on a separate topic, any background reading about `pr-head`?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org