You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "github-actions[bot] (via GitHub)" <gi...@apache.org> on 2023/04/09 13:44:24 UTC
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18500: [Chore](storage) change FieldType to enum class
github-actions[bot] commented on code in PR #18500:
URL: https://github.com/apache/doris/pull/18500#discussion_r1161288456
##########
be/test/olap/tablet_schema_helper.cpp:
##########
@@ -24,7 +24,7 @@
TabletColumn column;
column._unique_id = id;
column._col_name = std::to_string(id);
- column._type = OLAP_FIELD_TYPE_INT;
+ column._type = FieldType::OLAP_FIELD_TYPE_INT;
Review Comment:
warning: '_type' is a private member of 'doris::TabletColumn' [clang-diagnostic-error]
```cpp
column._type = FieldType::OLAP_FIELD_TYPE_INT;
^
```
**be/src/olap/tablet_schema.h:106:** declared private here
```cpp
FieldType _type;
^
```
##########
be/test/olap/rowset/segment_v2/binary_plain_page_test.cpp:
##########
@@ -72,8 +72,9 @@
vectorized::Arena pool;
size_t size = 3;
std::unique_ptr<ColumnVectorBatch> cvb;
- ColumnVectorBatch::create(size, true, get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR),
- nullptr, &cvb);
+ ColumnVectorBatch::create(size, true,
+ get_scalar_type_info(FieldType::OLAP_FIELD_TYPE_VARCHAR), nullptr,
+ &cvb);
ColumnBlock block(cvb.get(), &pool);
ColumnBlockView column_block_view(&block);
Review Comment:
warning: unknown type name 'ColumnBlockView' [clang-diagnostic-error]
```cpp
ColumnBlockView column_block_view(&block);
^
```
##########
be/test/olap/rowset/segment_v2/binary_dict_page_test.cpp:
##########
@@ -95,7 +95,7 @@ class BinaryDictPageTest : public testing::Test {
//check values
vectorized::Arena pool;
- auto type_info = get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR);
+ auto type_info = get_scalar_type_info(FieldType::OLAP_FIELD_TYPE_VARCHAR);
size_t size = slices.size();
std::unique_ptr<ColumnVectorBatch> cvb;
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch' [clang-diagnostic-error]
```cpp
std::unique_ptr<ColumnVectorBatch> cvb;
^
```
##########
be/test/olap/tablet_schema_helper.cpp:
##########
@@ -40,7 +40,7 @@
TabletColumn column;
column._unique_id = id;
Review Comment:
warning: '_unique_id' is a private member of 'doris::TabletColumn' [clang-diagnostic-error]
```cpp
column._unique_id = id;
^
```
**be/src/olap/tablet_schema.h:104:** declared private here
```cpp
int32_t _unique_id;
^
```
##########
be/test/olap/tablet_schema_helper.cpp:
##########
@@ -24,7 +24,7 @@ TabletColumn create_int_key(int32_t id, bool is_nullable, bool is_bf_column,
TabletColumn column;
column._unique_id = id;
Review Comment:
warning: '_unique_id' is a private member of 'doris::TabletColumn' [clang-diagnostic-error]
```cpp
column._unique_id = id;
^
```
**be/src/olap/tablet_schema.h:104:** declared private here
```cpp
int32_t _unique_id;
^
```
##########
be/test/olap/rowset/segment_v2/binary_prefix_page_test.cpp:
##########
@@ -96,7 +96,7 @@
while (true) {
//check values
vectorized::Arena pool;
- auto type_info = get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR);
+ auto type_info = get_scalar_type_info(FieldType::OLAP_FIELD_TYPE_VARCHAR);
std::unique_ptr<ColumnVectorBatch> cvb;
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch' [clang-diagnostic-error]
```cpp
std::unique_ptr<ColumnVectorBatch> cvb;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org