You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@lyra.org> on 2001/02/16 02:04:26 UTC

Re: CVS update: subversion/subversion/libsvn_fs node-rev.c Makefile.am rep.c

On Thu, Feb 15, 2001 at 09:06:20PM -0000, kfogel@tigris.org wrote:
>   User: kfogel  
>   Date: 01/02/15 13:06:20
> 
>   Modified:    subversion/libsvn_fs Makefile.am
>   Added:       subversion/libsvn_fs node-rev.c
>   Removed:     subversion/libsvn_fs rep.c
>   Log:
>   * Makefile.am: Build node-rev.c, remove all mention of obsolete rep.c.
>   
>   * rep.c: Removed (renamed to node-rev.c).
>   
>   * node-rev.c: New file, inherit code from old rep.c, with the
>   following changes:
>   
>   (svn_fs__get_node_revision, get_representation_skel,
>   put_representation_skel, svn_fs__get_node_revision, new_node_id,
>   svn_fs__create_node, new_successor_id, svn_fs__create_successor):
>   Accept a trail_t instead of db_txn and pool, to match Jim Blandy's
>   interface change of 2001-02-09 16:13.
>   
>   (svn_fs__create_nodes, svn_fs__open_nodes): Delete these one-liners,
>   as they have no callers.  JimB's log entry of 2000-10-11 13:18
>   mentions some new calls to these functions, but I think he really
>   meant svn_fs__open_nodes_table, as that's what appears in the code.
>   
>   (make_nodes): #ifdef out this callerless, static function, with
>   comment asking about its future.
>   
>   (compare_nodes_keys, compare_ids, parse_node_revision_dbt): Deleted;
>   these live in nodes-table.c now.
>   
>   (svn_fs__put_node_revision): Cast away a const warning, prepare to
>   receive ticking package from Branko.

Urk. It is impossible to see any of these changes. In the future, could you
please do whatever add/move/copy magic, *followed* by another commit with
the changes?

thx,
-g

-- 
Greg Stein, http://www.lyra.org/