You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2026/05/04 03:11:05 UTC
[PR] chore: Support decimal 32 and 64 in testing json parser [arrow-nanoarrow]
paleolimbot opened a new pull request, #880:
URL: https://github.com/apache/arrow-nanoarrow/pull/880
In pursuit of removing skips in the integration test for https://github.com/apache/arrow/pull/49910 . While the IPC reader has supported Decimal 32 and 64 since the beginning but the JSON parser hasn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Support decimal32, decimal64, and dictionaries in integration test utilities [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #880:
URL: https://github.com/apache/arrow-nanoarrow/pull/880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: Support decimal32, decimal64, and dictionaries in integration test utilities [arrow-nanoarrow]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #880:
URL: https://github.com/apache/arrow-nanoarrow/pull/880#issuecomment-4380959183
## [Codecov](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/880?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `38.59649%` with `35 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 79.25%. Comparing base ([`f11d517`](https://app.codecov.io/gh/apache/arrow-nanoarrow/commit/f11d5170853c976d9ea736d5b27b97226cfd7358?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c22b72`](https://app.codecov.io/gh/apache/arrow-nanoarrow/commit/3c22b72116ab9324df53da780028d1a42f5f6068?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 43 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/880?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [src/nanoarrow/ipc/decoder.c](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/880?src=pr&el=tree&filepath=src%2Fnanoarrow%2Fipc%2Fdecoder.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL25hbm9hcnJvdy9pcGMvZGVjb2Rlci5j) | 15.00% | [15 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/880?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [src/nanoarrow/integration/ipc\_integration.cc](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/880?src=pr&el=tree&filepath=src%2Fnanoarrow%2Fintegration%2Fipc_integration.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL25hbm9hcnJvdy9pbnRlZ3JhdGlvbi9pcGNfaW50ZWdyYXRpb24uY2M=) | 0.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/880?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [src/nanoarrow/testing/testing.cc](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/880?src=pr&el=tree&filepath=src%2Fnanoarrow%2Ftesting%2Ftesting.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL25hbm9hcnJvdy90ZXN0aW5nL3Rlc3RpbmcuY2M=) | 89.47% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/880?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #880 +/- ##
==========================================
- Coverage 79.96% 79.25% -0.72%
==========================================
Files 105 106 +1
Lines 15461 15938 +477
Branches 1738 1851 +113
==========================================
+ Hits 12364 12631 +267
- Misses 1998 2147 +149
- Partials 1099 1160 +61
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/880?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org