You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/14 05:33:44 UTC

[GitHub] [shardingsphere] gzdzss opened a new pull request #6836: Add test cases for rule builder

gzdzss opened a new pull request #6836:
URL: https://github.com/apache/shardingsphere/pull/6836


   Fixes #6825 .
   
   Changes proposed in this pull request:
   
   - [x]  Add test case for MasterSlaveRuleBuilder
   - [x]  Add test case for ReplicaRuleBuilder
   - [x]  Add test case for ShadowRuleBuilder
   - [x]  Add test case for ShardingRuleBuilder
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu merged pull request #6836: Add test cases for rule builder

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #6836:
URL: https://github.com/apache/shardingsphere/pull/6836


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] coveralls commented on pull request #6836: Add test cases for rule builder

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #6836:
URL: https://github.com/apache/shardingsphere/pull/6836#issuecomment-675211132


   ## Pull Request Test Coverage Report for [Build 13765](https://coveralls.io/builds/32752611)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **1** unchanged line in **1** file lost coverage.
   * Overall coverage increased (+**0.1%**) to **57.922%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-features/shardingsphere-replica/shardingsphere-replica-common/src/main/java/org/apache/shardingsphere/replica/rule/ReplicaRule.java](https://coveralls.io/builds/32752611/source?filename=shardingsphere-features%2Fshardingsphere-replica%2Fshardingsphere-replica-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Freplica%2Frule%2FReplicaRule.java#L80) | 1 | 28.57% |
   <!-- | **Total:** | **1** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/32752611/badge)](https://coveralls.io/builds/32752611) |
   | :-- | --: |
   | Change from base [Build 13764](https://coveralls.io/builds/32752144): |  0.1% |
   | Covered Lines: | 13095 |
   | Relevant Lines: | 22608 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org