[GitHub] imatiach-msft commented on a change in pull request #23868: [SPARK-26966][ML] Update to JPMML 1.4.8

[GitBox <gi...@apache.org>]

imatiach-msft commented on a change in pull request #23868: [SPARK-26966][ML] Update to JPMML 1.4.8
URL: https://github.com/apache/spark/pull/23868#discussion_r259215535
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/mllib/pmml/export/PMMLModelExportFactory.scala
 ##########
 @@ -44,12 +44,12 @@ private[mllib] object PMMLModelExportFactory {
         new GeneralizedLinearPMMLModelExport(lasso, "lasso regression")
       case svm: SVMModel =>
         new BinaryClassificationPMMLModelExport(
-          svm, "linear SVM", RegressionNormalizationMethodType.NONE,
+          svm, "linear SVM", RegressionModel.NormalizationMethod.NONE,
 
 Review comment:
   weird, maybe I missed something obvious, but why is it a RegressionModel normalization method for something that is a classification model

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org