You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Binglin Chang (JIRA)" <ji...@apache.org> on 2012/10/12 08:21:03 UTC

[jira] [Created] (HDFS-4044) Duplicate ChecksumType definition in HDFS .proto files

Binglin Chang created HDFS-4044:
-----------------------------------

             Summary: Duplicate ChecksumType definition in HDFS .proto files
                 Key: HDFS-4044
                 URL: https://issues.apache.org/jira/browse/HDFS-4044
             Project: Hadoop HDFS
          Issue Type: Bug
            Reporter: Binglin Chang


Both hdfs.proto and datatransfer.proto define ChecksumType enum, datatransfer.proto already includes hdfs.proto, so it should reuse ChecksumTypeProto enum.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-4044) Duplicate ChecksumType definition in HDFS .proto files

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Srinivas updated HDFS-4044:
----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.3-alpha
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

I committed the patch to both trunk and branch-2. Thank you Binglin.
                
> Duplicate ChecksumType definition in HDFS .proto files
> ------------------------------------------------------
>
>                 Key: HDFS-4044
>                 URL: https://issues.apache.org/jira/browse/HDFS-4044
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>             Fix For: 2.0.3-alpha
>
>         Attachments: HDFS-4044-checksumtype.patch
>
>
> Both hdfs.proto and datatransfer.proto define ChecksumType enum, datatransfer.proto already includes hdfs.proto, so it should reuse ChecksumTypeProto enum.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-4044) Duplicate ChecksumType definition in HDFS .proto files

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Srinivas updated HDFS-4044:
----------------------------------

    Assignee: Binglin Chang
    
> Duplicate ChecksumType definition in HDFS .proto files
> ------------------------------------------------------
>
>                 Key: HDFS-4044
>                 URL: https://issues.apache.org/jira/browse/HDFS-4044
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>         Attachments: HDFS-4044-checksumtype.patch
>
>
> Both hdfs.proto and datatransfer.proto define ChecksumType enum, datatransfer.proto already includes hdfs.proto, so it should reuse ChecksumTypeProto enum.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4044) Duplicate ChecksumType definition in HDFS .proto files

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474837#comment-13474837 ] 

Suresh Srinivas commented on HDFS-4044:
---------------------------------------

This change looks like it is backward compatible. +1 for the patch. I will commit it after Jenkins posts +1.
                
> Duplicate ChecksumType definition in HDFS .proto files
> ------------------------------------------------------
>
>                 Key: HDFS-4044
>                 URL: https://issues.apache.org/jira/browse/HDFS-4044
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>         Attachments: HDFS-4044-checksumtype.patch
>
>
> Both hdfs.proto and datatransfer.proto define ChecksumType enum, datatransfer.proto already includes hdfs.proto, so it should reuse ChecksumTypeProto enum.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4044) Duplicate ChecksumType definition in HDFS .proto files

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474887#comment-13474887 ] 

Hadoop QA commented on HDFS-4044:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12548859/HDFS-4044-checksumtype.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3321//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3321//console

This message is automatically generated.
                
> Duplicate ChecksumType definition in HDFS .proto files
> ------------------------------------------------------
>
>                 Key: HDFS-4044
>                 URL: https://issues.apache.org/jira/browse/HDFS-4044
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>         Attachments: HDFS-4044-checksumtype.patch
>
>
> Both hdfs.proto and datatransfer.proto define ChecksumType enum, datatransfer.proto already includes hdfs.proto, so it should reuse ChecksumTypeProto enum.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4044) Duplicate ChecksumType definition in HDFS .proto files

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475615#comment-13475615 ] 

Hudson commented on HDFS-4044:
------------------------------

Integrated in Hadoop-Mapreduce-trunk #1225 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1225/])
    HDFS-4044. Duplicate ChecksumType definition in HDFS .proto files. Contributed by Binglin Chang. (Revision 1397580)

     Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397580
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtoUtil.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/datatransfer.proto

                
> Duplicate ChecksumType definition in HDFS .proto files
> ------------------------------------------------------
>
>                 Key: HDFS-4044
>                 URL: https://issues.apache.org/jira/browse/HDFS-4044
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>             Fix For: 2.0.3-alpha
>
>         Attachments: HDFS-4044-checksumtype.patch
>
>
> Both hdfs.proto and datatransfer.proto define ChecksumType enum, datatransfer.proto already includes hdfs.proto, so it should reuse ChecksumTypeProto enum.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4044) Duplicate ChecksumType definition in HDFS .proto files

Posted by "Binglin Chang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474891#comment-13474891 ] 

Binglin Chang commented on HDFS-4044:
-------------------------------------

@Suresh Thanks for the review.
This patch is just code refactor, so I don't think it need adding new testcase.
                
> Duplicate ChecksumType definition in HDFS .proto files
> ------------------------------------------------------
>
>                 Key: HDFS-4044
>                 URL: https://issues.apache.org/jira/browse/HDFS-4044
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>         Attachments: HDFS-4044-checksumtype.patch
>
>
> Both hdfs.proto and datatransfer.proto define ChecksumType enum, datatransfer.proto already includes hdfs.proto, so it should reuse ChecksumTypeProto enum.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4044) Duplicate ChecksumType definition in HDFS .proto files

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475010#comment-13475010 ] 

Suresh Srinivas commented on HDFS-4044:
---------------------------------------

bq. This patch is just code refactor, so I don't think it need adding new testcase.
Agree.

I will commit the patch shortly.
                
> Duplicate ChecksumType definition in HDFS .proto files
> ------------------------------------------------------
>
>                 Key: HDFS-4044
>                 URL: https://issues.apache.org/jira/browse/HDFS-4044
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>         Attachments: HDFS-4044-checksumtype.patch
>
>
> Both hdfs.proto and datatransfer.proto define ChecksumType enum, datatransfer.proto already includes hdfs.proto, so it should reuse ChecksumTypeProto enum.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4044) Duplicate ChecksumType definition in HDFS .proto files

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475074#comment-13475074 ] 

Hudson commented on HDFS-4044:
------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2878 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2878/])
    HDFS-4044. Duplicate ChecksumType definition in HDFS .proto files. Contributed by Binglin Chang. (Revision 1397580)

     Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397580
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtoUtil.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/datatransfer.proto

                
> Duplicate ChecksumType definition in HDFS .proto files
> ------------------------------------------------------
>
>                 Key: HDFS-4044
>                 URL: https://issues.apache.org/jira/browse/HDFS-4044
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>             Fix For: 2.0.3-alpha
>
>         Attachments: HDFS-4044-checksumtype.patch
>
>
> Both hdfs.proto and datatransfer.proto define ChecksumType enum, datatransfer.proto already includes hdfs.proto, so it should reuse ChecksumTypeProto enum.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4044) Duplicate ChecksumType definition in HDFS .proto files

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475030#comment-13475030 ] 

Hudson commented on HDFS-4044:
------------------------------

Integrated in Hadoop-Common-trunk-Commit #2855 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2855/])
    HDFS-4044. Duplicate ChecksumType definition in HDFS .proto files. Contributed by Binglin Chang. (Revision 1397580)

     Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397580
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtoUtil.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/datatransfer.proto

                
> Duplicate ChecksumType definition in HDFS .proto files
> ------------------------------------------------------
>
>                 Key: HDFS-4044
>                 URL: https://issues.apache.org/jira/browse/HDFS-4044
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>             Fix For: 2.0.3-alpha
>
>         Attachments: HDFS-4044-checksumtype.patch
>
>
> Both hdfs.proto and datatransfer.proto define ChecksumType enum, datatransfer.proto already includes hdfs.proto, so it should reuse ChecksumTypeProto enum.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4044) Duplicate ChecksumType definition in HDFS .proto files

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475602#comment-13475602 ] 

Hudson commented on HDFS-4044:
------------------------------

Integrated in Hadoop-Hdfs-trunk #1194 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1194/])
    HDFS-4044. Duplicate ChecksumType definition in HDFS .proto files. Contributed by Binglin Chang. (Revision 1397580)

     Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397580
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtoUtil.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/datatransfer.proto

                
> Duplicate ChecksumType definition in HDFS .proto files
> ------------------------------------------------------
>
>                 Key: HDFS-4044
>                 URL: https://issues.apache.org/jira/browse/HDFS-4044
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>             Fix For: 2.0.3-alpha
>
>         Attachments: HDFS-4044-checksumtype.patch
>
>
> Both hdfs.proto and datatransfer.proto define ChecksumType enum, datatransfer.proto already includes hdfs.proto, so it should reuse ChecksumTypeProto enum.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4044) Duplicate ChecksumType definition in HDFS .proto files

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475028#comment-13475028 ] 

Hudson commented on HDFS-4044:
------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2917 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2917/])
    HDFS-4044. Duplicate ChecksumType definition in HDFS .proto files. Contributed by Binglin Chang. (Revision 1397580)

     Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397580
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtoUtil.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/datatransfer.proto

                
> Duplicate ChecksumType definition in HDFS .proto files
> ------------------------------------------------------
>
>                 Key: HDFS-4044
>                 URL: https://issues.apache.org/jira/browse/HDFS-4044
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>             Fix For: 2.0.3-alpha
>
>         Attachments: HDFS-4044-checksumtype.patch
>
>
> Both hdfs.proto and datatransfer.proto define ChecksumType enum, datatransfer.proto already includes hdfs.proto, so it should reuse ChecksumTypeProto enum.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-4044) Duplicate ChecksumType definition in HDFS .proto files

Posted by "Binglin Chang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Binglin Chang updated HDFS-4044:
--------------------------------

    Status: Patch Available  (was: Open)
    
> Duplicate ChecksumType definition in HDFS .proto files
> ------------------------------------------------------
>
>                 Key: HDFS-4044
>                 URL: https://issues.apache.org/jira/browse/HDFS-4044
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Binglin Chang
>         Attachments: HDFS-4044-checksumtype.patch
>
>
> Both hdfs.proto and datatransfer.proto define ChecksumType enum, datatransfer.proto already includes hdfs.proto, so it should reuse ChecksumTypeProto enum.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-4044) Duplicate ChecksumType definition in HDFS .proto files

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Srinivas updated HDFS-4044:
----------------------------------

          Component/s: data-node
    Affects Version/s: 2.0.0-alpha
    
> Duplicate ChecksumType definition in HDFS .proto files
> ------------------------------------------------------
>
>                 Key: HDFS-4044
>                 URL: https://issues.apache.org/jira/browse/HDFS-4044
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>             Fix For: 2.0.3-alpha
>
>         Attachments: HDFS-4044-checksumtype.patch
>
>
> Both hdfs.proto and datatransfer.proto define ChecksumType enum, datatransfer.proto already includes hdfs.proto, so it should reuse ChecksumTypeProto enum.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-4044) Duplicate ChecksumType definition in HDFS .proto files

Posted by "Binglin Chang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Binglin Chang updated HDFS-4044:
--------------------------------

    Attachment: HDFS-4044-checksumtype.patch
    
> Duplicate ChecksumType definition in HDFS .proto files
> ------------------------------------------------------
>
>                 Key: HDFS-4044
>                 URL: https://issues.apache.org/jira/browse/HDFS-4044
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Binglin Chang
>         Attachments: HDFS-4044-checksumtype.patch
>
>
> Both hdfs.proto and datatransfer.proto define ChecksumType enum, datatransfer.proto already includes hdfs.proto, so it should reuse ChecksumTypeProto enum.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira