[GitHub] [superset] graceguo-supercat edited a comment on pull request #12613: feat: [WIP] Quick POC of rendering all charts in iframes on dashboards

[GitBox <gi...@apache.org>]

graceguo-supercat edited a comment on pull request #12613:
URL: https://github.com/apache/superset/pull/12613#issuecomment-763849557


   The impact of this change might be pretty big but hard to measure, especially for page load performance. 
   after this change, is dashboard perf logging still working? 
   Could you wrap iframe implementation in a **FEATURE FLAG**, so that we can compare and check perf impact?
   
   Agree with Erik's comment, how to handle intra-dashboard interactions? besides on filter boxes, i thought Superset will/should also implements _chart filter_ in the future.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org