[GitHub] [accumulo] ctubbsii commented on issue #3156: Explore adding tests for per table classpath configuration with plugins

["ctubbsii (via GitHub)" <gi...@apache.org>]

ctubbsii commented on issue #3156:
URL: https://github.com/apache/accumulo/issues/3156#issuecomment-1500550466

   We don't need to test per-table classpath configuration, because that's not how the classloader works now (not required to anyway). For testing plugins, we should test: 1) the plugin aspect/nature (making sure it executes correctly when configured to do so), and 2) unit test individual plugin implementations separately.
   
   The context class loader factory can be tested by providing a custom factory that returns the system classloader, but does something else that can be detected in the test, so we know the plugin aspect is working properly. If we have any reference implementations of this factory in our code, we can have unit tests for those, that ensure they return the expected classloader when provided with a given mocked input environment. Other plugins should be tested similarly: 1) test the pluggable aspect (may require integration test), and 2) unit test provided implementations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org