You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/10 11:14:37 UTC

[GitHub] [incubator-nuttx] davids5 opened a new issue #521: Document checkpatch.sh arguments with examples.

davids5 opened a new issue #521: Document checkpatch.sh arguments with examples.
URL: https://github.com/apache/incubator-nuttx/issues/521
 
 
   from https://github.com/apache/incubator-nuttx/pull/448#discussion_r390074355

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #521: Document checkpatch.sh arguments with examples.

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 commented on issue #521: Document checkpatch.sh arguments with examples.
URL: https://github.com/apache/incubator-nuttx/issues/521#issuecomment-597041522
 
 
   @davids5 is the document in this patch enough?
   https://github.com/apache/incubator-nuttx/pull/516

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 edited a comment on issue #521: Document checkpatch.sh arguments with examples.

Posted by GitBox <gi...@apache.org>.

davids5 edited a comment on issue #521: Document checkpatch.sh arguments with examples.
URL: https://github.com/apache/incubator-nuttx/issues/521#issuecomment-597061750
 
 
   Yes. What about a "patch list". Is it a file with the patches listed in it or a list of file names. You are to close to the problem to see what is missing. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 closed issue #521: Document checkpatch.sh arguments with examples.

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 closed issue #521: Document checkpatch.sh arguments with examples.
URL: https://github.com/apache/incubator-nuttx/issues/521
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #521: Document checkpatch.sh arguments with examples.

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 commented on issue #521: Document checkpatch.sh arguments with examples.
URL: https://github.com/apache/incubator-nuttx/issues/521#issuecomment-597059145
 
 
   If user use git, he already know how to specify commit id, should we put so much boring info?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on issue #521: Document checkpatch.sh arguments with examples.

Posted by GitBox <gi...@apache.org>.

davids5 commented on issue #521: Document checkpatch.sh arguments with examples.
URL: https://github.com/apache/incubator-nuttx/issues/521#issuecomment-597060254
 
 
   Are all the above correct?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #521: Document checkpatch.sh arguments with examples.

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 commented on issue #521: Document checkpatch.sh arguments with examples.
URL: https://github.com/apache/incubator-nuttx/issues/521#issuecomment-597139735
 
 
   > Yes. What about a "patch list". Is it a file with the patches listed in it or a list of file names. You are to close to the problem to see what is missing.
   
   A list of file name of course:
   checkpatch.sh *.patch
   Anyway, if you think the usage isn't clear, please send a PR.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on issue #521: Document checkpatch.sh arguments with examples.

Posted by GitBox <gi...@apache.org>.

davids5 commented on issue #521: Document checkpatch.sh arguments with examples.
URL: https://github.com/apache/incubator-nuttx/issues/521#issuecomment-597061750
 
 
   Yes. What about a "patch list". Is it a file with the patches listed in it or a list of file names. To are to close to the problem to see what is missing. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 edited a comment on issue #521: Document checkpatch.sh arguments with examples.

Posted by GitBox <gi...@apache.org>.

davids5 edited a comment on issue #521: Document checkpatch.sh arguments with examples.
URL: https://github.com/apache/incubator-nuttx/issues/521#issuecomment-597055133
 
 
   No Examples are missing.
   
   define "commit list"
   is it
   checkpatch.sh -g 2343..9011
   or
   `checkpatch.sh -g e7460a2ca740068c09f37b41552140d8621dd13e**,** bba8aac22d01d4f966396bd6b5bcbeb9b0e3f220`
   or is it
   `checkpatch.sh -g e7460a2ca740068c09f37b41552140d8621dd13e bba8aac22d01d4f966396bd6b5bcbeb9b0e3f220`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #521: Document checkpatch.sh arguments with examples.

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 commented on issue #521: Document checkpatch.sh arguments with examples.
URL: https://github.com/apache/incubator-nuttx/issues/521#issuecomment-597138721

> Are all the above correct?

Of course, if git accept, checkpatch.sh will accept, do you want me to duplicate the full gitrevisions?
```
GITREVISIONS(7) Git Manual GITREVISIONS(7)

NAME
gitrevisions - specifying revisions and ranges for Git

SYNOPSIS
gitrevisions

DESCRIPTION
Many Git commands take revision parameters as arguments. Depending on the command, they denote a specific commit or, for commands which walk the
revision graph (such as git-log(1)), all commits which are reachable from that commit. For commands that walk the revision graph one can also specify
a range of revisions explicitly.

In addition, some Git commands (such as git-show(1)) also take revision parameters which denote other objects than commits, e.g. blobs ("files") or
trees ("directories of files").

SPECIFYING REVISIONS
A revision parameter <rev> typically, but not necessarily, names a commit object. It uses what is called an extended SHA-1 syntax. Here are various
ways to spell object names. The ones listed near the end of this list name trees and blobs contained in a commit.

<sha1>, e.g. dae86e1950b1277e545cee180551750029cfe735, dae86e
The full SHA-1 object name (40-byte hexadecimal string), or a leading substring that is unique within the repository. E.g.
dae86e1950b1277e545cee180551750029cfe735 and dae86e both name the same commit object if there is no other object in your repository whose object
name starts with dae86e.

<describeOutput>, e.g. v1.7.4.2-679-g3bee7fb
Output from git describe; i.e. a closest tag, optionally followed by a dash and a number of commits, followed by a dash, a g, and an abbreviated
object name.

<refname>, e.g. master, heads/master, refs/heads/master
A symbolic ref name. E.g. master typically means the commit object referenced by refs/heads/master. If you happen to have both heads/master and
tags/master, you can explicitly say heads/master to tell Git which one you mean. When ambiguous, a <refname> is disambiguated by taking the first
match in the following rules:

1. If $GIT_DIR/<refname> exists, that is what you mean (this is usually useful only for HEAD, FETCH_HEAD, ORIG_HEAD, MERGE_HEAD and
CHERRY_PICK_HEAD);

2. otherwise, refs/<refname> if it exists;

3. otherwise, refs/tags/<refname> if it exists;

4. otherwise, refs/heads/<refname> if it exists;

5. otherwise, refs/remotes/<refname> if it exists;
```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on issue #521: Document checkpatch.sh arguments with examples.

Posted by GitBox <gi...@apache.org>.

davids5 commented on issue #521: Document checkpatch.sh arguments with examples.
URL: https://github.com/apache/incubator-nuttx/issues/521#issuecomment-597055133
 
 
   No Examples are missing.
   
   define "commit list"
   is it
   checkpatch.sh -g 2343..9011
   or
   checkpatch.sh -g e7460a2ca740068c09f37b41552140d8621dd13e**,** bba8aac22d01d4f966396bd6b5bcbeb9b0e3f220
   or is it
   checkpatch.sh -g e7460a2ca740068c09f37b41552140d8621dd13e bba8aac22d01d4f966396bd6b5bcbeb9b0e3f220
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services