[GitHub] [beam] lostluck commented on pull request #21943: Go SDK: Update memfs to parse the List() pattern as a glob, not a regexp

[GitBox <gi...@apache.org>]

lostluck commented on PR #21943:
URL: https://github.com/apache/beam/pull/21943#issuecomment-1162017374

   In this instance, I think we should change it.
   
   1. We don't really demonstrate usage of the memfs anywhere. https://github.com/apache/beam/search?l=Go&q=memfs
   2. We don't have properly defined behavior.
   3. Regex in this case is surprising, especially if coming from the local or gcs file systems.
   
   Looking at the local and gcs implementations, they use filepath.Match/Glob instead of plain path.Match. filepath is OS separator aware.
   
   A github search doesn't reveal any usage, and neither does the [pkg page for v2](https://pkg.go.dev/github.com/apache/beam/sdks/v2/go/pkg/beam/io/filesystem/memfs?tab=importedby).  Checking the pre-modules version has [1 package ](https://pkg.go.dev/github.com/apache/beam/sdks/go/pkg/beam/io/filesystem/memfs?tab=importedby) that hasn't updated in 3 years, and doesn't use it explicitly (but does use local and gcs).
   
   As a result, I think a move towards consistency, and documenting the behavior is the right one.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org