[GitHub] [incubator-superset] vfoucault commented on pull request #10190: feat: oauth config for superset chart

[GitBox <gi...@apache.org>]

vfoucault commented on pull request #10190:
URL: https://github.com/apache/incubator-superset/pull/10190#issuecomment-654973250


   > Just merged FAB 3 and marshmallow 3 dependency bump, new FAB oauth breaks compatibility, just a small change on the config:
   > `consumer_key` -> `client_id`
   > `consumer_secret` -> `client_secret`
   > `base_url` -> `api_base_url`
   > `request_token_params` -> `client_kwargs`
   
   done. 
   
   E2E tests are failing, not sure this is related


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org