You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@crunch.apache.org by GitBox <gi...@apache.org> on 2020/01/09 17:00:00 UTC
[GitHub] [crunch] jwills opened a new pull request #30: The great version
upgrade PR
jwills opened a new pull request #30: The great version upgrade PR
URL: https://github.com/apache/crunch/pull/30
In order to stay in sync w/our primary upstream dependencies, I bit the bullet and made all of the changes required to make Crunch work against Hadoop 2.8.2 and (hopefully) later. It's a large set of small/no-op changes, but version dependency changes like this are always sort of spicy so I'll get some eyes on it before I push it in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [crunch] jwills merged pull request #30: The great version upgrade
PR
Posted by GitBox <gi...@apache.org>.
jwills merged pull request #30: The great version upgrade PR
URL: https://github.com/apache/crunch/pull/30
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [crunch] gabrielreid commented on a change in pull request #30: The
great version upgrade PR
Posted by GitBox <gi...@apache.org>.
gabrielreid commented on a change in pull request #30: The great version upgrade PR
URL: https://github.com/apache/crunch/pull/30#discussion_r365525943
##########
File path: pom.xml
##########
@@ -200,6 +199,12 @@ under the License.
<version>${hadoop.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-hdfs</artifactId>
Review comment:
Looks like this is a duplicate dependency entry (`hadoop-hdfs` is also declared further down in this file, on line 527)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [crunch] gabrielreid commented on issue #30: The great version
upgrade PR
Posted by GitBox <gi...@apache.org>.
gabrielreid commented on issue #30: The great version upgrade PR
URL: https://github.com/apache/crunch/pull/30#issuecomment-573326111
Nice one taking this on @jwills !
All looks fine to me (based on just going through things and running the tests, etc), apart from the duplicate `hadoop-hdfs` entry mentioned above.
I ran into a small issue when trying to run the tests with JDK 11 (`org.apache.crunch.contrib.text.ParseTest` failed), but I'm quite sure that that's totally unrelated to all of this, so I'll fix it in a separate ticket.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services