You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Navis (Created) (JIRA)" <ji...@apache.org> on 2012/04/09 22:39:19 UTC

[jira] [Created] (HIVE-2937) TestHiveServerSessions hangs when executed directly

TestHiveServerSessions hangs when executed directly
---------------------------------------------------

                 Key: HIVE-2937
                 URL: https://issues.apache.org/jira/browse/HIVE-2937
             Project: Hive
          Issue Type: Test
            Reporter: Navis
            Priority: Trivial


code}
ant test -Doffline=true -Dtestcase=TestHiveServerSessions
{code}
Hangs infinitely.

I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2937) TestHiveServerSessions hangs when executed directly

Posted by "Navis (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Navis updated HIVE-2937:
------------------------

    Status: Patch Available  (was: Open)
    
> TestHiveServerSessions hangs when executed directly
> ---------------------------------------------------
>
>                 Key: HIVE-2937
>                 URL: https://issues.apache.org/jira/browse/HIVE-2937
>             Project: Hive
>          Issue Type: Test
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-2937.D2697.1.patch
>
>
> {code}
> ant test -Doffline=true -Dtestcase=TestHiveServerSessions
> {code}
> Hangs infinitely.
> I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2937) TestHiveServerSessions hangs when executed directly

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251812#comment-13251812 ] 

Phabricator commented on HIVE-2937:
-----------------------------------

kevinwilfong has accepted the revision "HIVE-2937 [jira] TestHiveServerSessions hangs when executed directly".

  +1 running tests

REVISION DETAIL
  https://reviews.facebook.net/D2697

BRANCH
  DPAL-1079

                
> TestHiveServerSessions hangs when executed directly
> ---------------------------------------------------
>
>                 Key: HIVE-2937
>                 URL: https://issues.apache.org/jira/browse/HIVE-2937
>             Project: Hive
>          Issue Type: Test
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-2937.D2697.1.patch
>
>
> {code}
> ant test -Doffline=true -Dtestcase=TestHiveServerSessions
> {code}
> Hangs infinitely.
> I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (HIVE-2937) TestHiveServerSessions hangs when executed directly

Posted by "Navis (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Navis reassigned HIVE-2937:
---------------------------

    Assignee: Navis
    
> TestHiveServerSessions hangs when executed directly
> ---------------------------------------------------
>
>                 Key: HIVE-2937
>                 URL: https://issues.apache.org/jira/browse/HIVE-2937
>             Project: Hive
>          Issue Type: Test
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-2937.D2697.1.patch
>
>
> {code}
> ant test -Doffline=true -Dtestcase=TestHiveServerSessions
> {code}
> Hangs infinitely.
> I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2937) TestHiveServerSessions hangs when executed directly

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253114#comment-13253114 ] 

Phabricator commented on HIVE-2937:
-----------------------------------

kevinwilfong has commented on the revision "HIVE-2937 [jira] TestHiveServerSessions hangs when executed directly".

  Awesome!  I wasn't sure if Thrift supported this, at least with this we won't end up with these mysterious infinite hangs.

REVISION DETAIL
  https://reviews.facebook.net/D2697

BRANCH
  DPAL-1079

                
> TestHiveServerSessions hangs when executed directly
> ---------------------------------------------------
>
>                 Key: HIVE-2937
>                 URL: https://issues.apache.org/jira/browse/HIVE-2937
>             Project: Hive
>          Issue Type: Test
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-2937.D2697.1.patch, HIVE-2937.D2697.2.patch
>
>
> {code}
> ant test -Doffline=true -Dtestcase=TestHiveServerSessions
> {code}
> Hangs infinitely.
> I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2937) TestHiveServerSessions hangs when executed directly

Posted by "Kevin Wilfong (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251808#comment-13251808 ] 

Kevin Wilfong commented on HIVE-2937:
-------------------------------------

I ran into this issue too.  It seems to be caused by creating the HiveClient's too quickly.  The initialization of the HiveClient initializes the HiveServerHandler which initializes the HMSHandler.  The initializations of the HMSHandler's happen in such quick succession that when the second call to create the default db occurs, the first call hasn't finished creating the db yet so it attempts to create the same db and never gets out of this method (possibly a derby issue).

It could also be fixed by adding a Thread.sleep between creating HiveClient's, but Navis's solution seems much more appropriate.

@Ashutosh I don't think it is related to either of those patches as previous builds appear to fail for the same reason
https://builds.apache.org/job/Hive-trunk-h0.21/1355/ also both of those patches should have only affected map reduce jobs, not the metastore.
                
> TestHiveServerSessions hangs when executed directly
> ---------------------------------------------------
>
>                 Key: HIVE-2937
>                 URL: https://issues.apache.org/jira/browse/HIVE-2937
>             Project: Hive
>          Issue Type: Test
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-2937.D2697.1.patch
>
>
> {code}
> ant test -Doffline=true -Dtestcase=TestHiveServerSessions
> {code}
> Hangs infinitely.
> I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2937) TestHiveServerSessions hangs when executed directly

Posted by "Ashutosh Chauhan (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250243#comment-13250243 ] 

Ashutosh Chauhan commented on HIVE-2937:
----------------------------------------

@Navis

Can you add Namit in reviewer list?

                
> TestHiveServerSessions hangs when executed directly
> ---------------------------------------------------
>
>                 Key: HIVE-2937
>                 URL: https://issues.apache.org/jira/browse/HIVE-2937
>             Project: Hive
>          Issue Type: Test
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-2937.D2697.1.patch
>
>
> {code}
> ant test -Doffline=true -Dtestcase=TestHiveServerSessions
> {code}
> Hangs infinitely.
> I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2937) TestHiveServerSessions hangs when executed directly

Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Wilfong updated HIVE-2937:
--------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Committed, thanks Navis.
                
> TestHiveServerSessions hangs when executed directly
> ---------------------------------------------------
>
>                 Key: HIVE-2937
>                 URL: https://issues.apache.org/jira/browse/HIVE-2937
>             Project: Hive
>          Issue Type: Test
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-2937.D2697.1.patch, HIVE-2937.D2697.2.patch
>
>
> {code}
> ant test -Doffline=true -Dtestcase=TestHiveServerSessions
> {code}
> Hangs infinitely.
> I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2937) TestHiveServerSessions hangs when executed directly

Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Steinbach updated HIVE-2937:
---------------------------------

    Component/s: Metastore
    
> TestHiveServerSessions hangs when executed directly
> ---------------------------------------------------
>
>                 Key: HIVE-2937
>                 URL: https://issues.apache.org/jira/browse/HIVE-2937
>             Project: Hive
>          Issue Type: Test
>          Components: Metastore
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>             Fix For: 0.10.0
>
>         Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2937.D2697.1.patch, ASF.LICENSE.NOT.GRANTED--HIVE-2937.D2697.2.patch
>
>
> {code}
> ant test -Doffline=true -Dtestcase=TestHiveServerSessions
> {code}
> Hangs infinitely.
> I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2937) TestHiveServerSessions hangs when executed directly

Posted by "Ashutosh Chauhan (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250172#comment-13250172 ] 

Ashutosh Chauhan commented on HIVE-2937:
----------------------------------------

@Navis,

I have also found this test hanging on my machines. Looking at apache build logs, either of HIVE-2929 or HIVE-2858 is the cause. https://builds.apache.org/job/Hive-trunk-h0.21/1360/ Though atleast one of the subsequent build has passed. So, may be there is a race condition somewhere.

Nsmit was involved in both of those patches, so may have more context.
                
> TestHiveServerSessions hangs when executed directly
> ---------------------------------------------------
>
>                 Key: HIVE-2937
>                 URL: https://issues.apache.org/jira/browse/HIVE-2937
>             Project: Hive
>          Issue Type: Test
>            Reporter: Navis
>            Priority: Trivial
>
> {code}
> ant test -Doffline=true -Dtestcase=TestHiveServerSessions
> {code}
> Hangs infinitely.
> I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2937) TestHiveServerSessions hangs when executed directly

Posted by "Ashutosh Chauhan (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253077#comment-13253077 ] 

Ashutosh Chauhan commented on HIVE-2937:
----------------------------------------

Go ahead and commit it will unblock us from this failing test. But do file a follow-up jira describing your findings so in case anyone is interested to further pursue this will have some context to begin with.
                
> TestHiveServerSessions hangs when executed directly
> ---------------------------------------------------
>
>                 Key: HIVE-2937
>                 URL: https://issues.apache.org/jira/browse/HIVE-2937
>             Project: Hive
>          Issue Type: Test
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-2937.D2697.1.patch
>
>
> {code}
> ant test -Doffline=true -Dtestcase=TestHiveServerSessions
> {code}
> Hangs infinitely.
> I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2937) TestHiveServerSessions hangs when executed directly

Posted by "Navis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Navis updated HIVE-2937:
------------------------

    Fix Version/s:     (was: 0.9.0)
                   0.10.0

This is not applied to hive-0.9.0 and not consistent with release note.
                
> TestHiveServerSessions hangs when executed directly
> ---------------------------------------------------
>
>                 Key: HIVE-2937
>                 URL: https://issues.apache.org/jira/browse/HIVE-2937
>             Project: Hive
>          Issue Type: Test
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>             Fix For: 0.10.0
>
>         Attachments: HIVE-2937.D2697.1.patch, HIVE-2937.D2697.2.patch
>
>
> {code}
> ant test -Doffline=true -Dtestcase=TestHiveServerSessions
> {code}
> Hangs infinitely.
> I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2937) TestHiveServerSessions hangs when executed directly

Posted by "Ashutosh Chauhan (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252487#comment-13252487 ] 

Ashutosh Chauhan commented on HIVE-2937:
----------------------------------------

@Kevin,

What you said make sense. But, I am still puzzled why this has started to show up recently. I see this hang ~70% of time on my builds starting last week. If the bug is as described, this should have always been the case. Isn't it?
                
> TestHiveServerSessions hangs when executed directly
> ---------------------------------------------------
>
>                 Key: HIVE-2937
>                 URL: https://issues.apache.org/jira/browse/HIVE-2937
>             Project: Hive
>          Issue Type: Test
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-2937.D2697.1.patch
>
>
> {code}
> ant test -Doffline=true -Dtestcase=TestHiveServerSessions
> {code}
> Hangs infinitely.
> I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2937) TestHiveServerSessions hangs when executed directly

Posted by "Kevin Wilfong (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253073#comment-13253073 ] 

Kevin Wilfong commented on HIVE-2937:
-------------------------------------

@Ashutosh

I dug deeper into the issue.  I verified that the second HiveServerHandler does exit the method, just via an exception rather than via the return.  This prevents the HiveServerHandler from being created.  The test actually gets stuck making the first execute call on the second HiveClient, presumably because there is no handler on the other end of the connection to handle the request, so it gets stuck waiting for a response.

I admit I am equally confused as to why this started showing up so frequently recently.  I had seen this problem a few times before, I had assumed it was caused by running the tests twice on the same machine.  Now however, I've run into this problem every time I try to run tests, since yesterday.

As far as I can tell, there is no, and never was any logic to handle this problem.  So Navis's diff seems worth committing to fix that issue, and it is at least a plus that it gets us around this issue, even if the root cause of why this issue suddenly became so prominent is still unsolved.

I would like to commit this patch, unless you have any objections.
                
> TestHiveServerSessions hangs when executed directly
> ---------------------------------------------------
>
>                 Key: HIVE-2937
>                 URL: https://issues.apache.org/jira/browse/HIVE-2937
>             Project: Hive
>          Issue Type: Test
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-2937.D2697.1.patch
>
>
> {code}
> ant test -Doffline=true -Dtestcase=TestHiveServerSessions
> {code}
> Hangs infinitely.
> I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2937) TestHiveServerSessions hangs when executed directly

Posted by "Navis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253111#comment-13253111 ] 

Navis commented on HIVE-2937:
-----------------------------

Modified to close connection when exception is thrown initializing HiveServerHandler.
                
> TestHiveServerSessions hangs when executed directly
> ---------------------------------------------------
>
>                 Key: HIVE-2937
>                 URL: https://issues.apache.org/jira/browse/HIVE-2937
>             Project: Hive
>          Issue Type: Test
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-2937.D2697.1.patch, HIVE-2937.D2697.2.patch
>
>
> {code}
> ant test -Doffline=true -Dtestcase=TestHiveServerSessions
> {code}
> Hangs infinitely.
> I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2937) TestHiveServerSessions hangs when executed directly

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Chauhan updated HIVE-2937:
-----------------------------------

    Fix Version/s: 0.9.0
    
> TestHiveServerSessions hangs when executed directly
> ---------------------------------------------------
>
>                 Key: HIVE-2937
>                 URL: https://issues.apache.org/jira/browse/HIVE-2937
>             Project: Hive
>          Issue Type: Test
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>             Fix For: 0.9.0
>
>         Attachments: HIVE-2937.D2697.1.patch, HIVE-2937.D2697.2.patch
>
>
> {code}
> ant test -Doffline=true -Dtestcase=TestHiveServerSessions
> {code}
> Hangs infinitely.
> I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2937) TestHiveServerSessions hangs when executed directly

Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HIVE-2937:
------------------------------

    Attachment: HIVE-2937.D2697.1.patch

navis requested code review of "HIVE-2937 [jira] TestHiveServerSessions hangs when executed directly".
Reviewers: JIRA

  DPAL-1079 TestHiveServerSessions hangs when executed directly

  ant test -Doffline=true -Dtestcase=TestHiveServerSessions

  Hangs infinitely.

  I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D2697

AFFECTED FILES
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/6183/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> TestHiveServerSessions hangs when executed directly
> ---------------------------------------------------
>
>                 Key: HIVE-2937
>                 URL: https://issues.apache.org/jira/browse/HIVE-2937
>             Project: Hive
>          Issue Type: Test
>            Reporter: Navis
>            Priority: Trivial
>         Attachments: HIVE-2937.D2697.1.patch
>
>
> {code}
> ant test -Doffline=true -Dtestcase=TestHiveServerSessions
> {code}
> Hangs infinitely.
> I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2937) TestHiveServerSessions hangs when executed directly

Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HIVE-2937:
------------------------------

    Attachment: HIVE-2937.D2697.2.patch

navis updated the revision "HIVE-2937 [jira] TestHiveServerSessions hangs when executed directly".
Reviewers: JIRA, njain, kevinwilfong

  1. When failed to create server handler, close transport and make a log
  2. Fix lint warning

REVISION DETAIL
  https://reviews.facebook.net/D2697

AFFECTED FILES
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
  service/src/java/org/apache/hadoop/hive/service/HiveServer.java

                
> TestHiveServerSessions hangs when executed directly
> ---------------------------------------------------
>
>                 Key: HIVE-2937
>                 URL: https://issues.apache.org/jira/browse/HIVE-2937
>             Project: Hive
>          Issue Type: Test
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-2937.D2697.1.patch, HIVE-2937.D2697.2.patch
>
>
> {code}
> ant test -Doffline=true -Dtestcase=TestHiveServerSessions
> {code}
> Hangs infinitely.
> I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2937) TestHiveServerSessions hangs when executed directly

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254070#comment-13254070 ] 

Hudson commented on HIVE-2937:
------------------------------

Integrated in Hive-trunk-h0.21 #1373 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1373/])
    HIVE-2937. TestHiveServerSessions hangs when executed directly. (navis via kevinwilfong) (Revision 1325830)

     Result = SUCCESS
kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325830
Files : 
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
* /hive/trunk/service/src/java/org/apache/hadoop/hive/service/HiveServer.java

                
> TestHiveServerSessions hangs when executed directly
> ---------------------------------------------------
>
>                 Key: HIVE-2937
>                 URL: https://issues.apache.org/jira/browse/HIVE-2937
>             Project: Hive
>          Issue Type: Test
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-2937.D2697.1.patch, HIVE-2937.D2697.2.patch
>
>
> {code}
> ant test -Doffline=true -Dtestcase=TestHiveServerSessions
> {code}
> Hangs infinitely.
> I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2937) TestHiveServerSessions hangs when executed directly

Posted by "Navis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250238#comment-13250238 ] 

Navis commented on HIVE-2937:
-----------------------------

@Ashutosh Chauhan

It was related to initialization of metastore. Just added static sync in HMSHandler#createDefaultDB and seemed enough to solve this.
                
> TestHiveServerSessions hangs when executed directly
> ---------------------------------------------------
>
>                 Key: HIVE-2937
>                 URL: https://issues.apache.org/jira/browse/HIVE-2937
>             Project: Hive
>          Issue Type: Test
>            Reporter: Navis
>            Priority: Trivial
>         Attachments: HIVE-2937.D2697.1.patch
>
>
> {code}
> ant test -Doffline=true -Dtestcase=TestHiveServerSessions
> {code}
> Hangs infinitely.
> I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2937) TestHiveServerSessions hangs when executed directly

Posted by "Navis (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Navis updated HIVE-2937:
------------------------

    Description: 
{code}
ant test -Doffline=true -Dtestcase=TestHiveServerSessions
{code}
Hangs infinitely.

I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.


  was:
code}
ant test -Doffline=true -Dtestcase=TestHiveServerSessions
{code}
Hangs infinitely.

I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.


    
> TestHiveServerSessions hangs when executed directly
> ---------------------------------------------------
>
>                 Key: HIVE-2937
>                 URL: https://issues.apache.org/jira/browse/HIVE-2937
>             Project: Hive
>          Issue Type: Test
>            Reporter: Navis
>            Priority: Trivial
>
> {code}
> ant test -Doffline=true -Dtestcase=TestHiveServerSessions
> {code}
> Hangs infinitely.
> I couldn't imagine exact cause of the problem, but found that by adding 'new HiveServer.HiveServerHandler();' in setup(), test resulted to success.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira