You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/24 15:03:36 UTC

[GitHub] [skywalking] wu-sheng edited a comment on pull request #6427: Add `sum` function in meter system

wu-sheng edited a comment on pull request #6427:
URL: https://github.com/apache/skywalking/pull/6427#issuecomment-785136174


   I am just being informed by @wankai123 explaining this change will cause a serious bug. The previous `sum`(with avg downsampling) is correct, such as calculating the disk usage, CPU etc. Then, the SampleFamily have 30%(for example), and 35% next time, then we really need 33% usage. `Sum function with avg downsampling` is widely used.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org