[GitHub] [hadoop] haiyang1987 commented on a diff in pull request #5068: HDFS-16811. Support to make dfs.namenode.decommission.backoff.monitor.pending.limit reconfigurable

[GitBox <gi...@apache.org>]

haiyang1987 commented on code in PR #5068:
URL: https://github.com/apache/hadoop/pull/5068#discussion_r1003973853


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java:
##########
@@ -2321,6 +2324,9 @@ protected String reconfigurePropertyImpl(String property, String newVal)
       return reconfigureSlowNodesParameters(datanodeManager, property, newVal);
     } else if (property.equals(DFS_BLOCK_INVALIDATE_LIMIT_KEY)) {
       return reconfigureBlockInvalidateLimit(datanodeManager, property, newVal);
+    } else if (property.equals(DFS_NAMENODE_DECOMMISSION_BACKOFF_MONITOR_PENDING_LIMIT)) {

Review Comment:
   Hi @tomscut, thanks for your comment.
   yeah,  can create new method reconfigureDecommissionBackoffMonitorParameters() to update DecommissionBackoffMonitor related parameters.
   
   HDFS-16810 to support ‘DFS_NAMENODE_DECOMMISSION_BACKOFF_MONITOR_PENDING_BLOCKS_PER_LOCK_DEFAULT’ reconfigurable
   
   Do we need to merge 2 issues into one to support?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org