You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Sean Busbey <se...@manvsbeard.com> on 2013/11/14 21:53:12 UTC

Review Request 15538: ACCUMULO-1893 keep tests from attempting to write to the root of HDFS.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15538/
-----------------------------------------------------------

Review request for accumulo and Eric Newton.


Bugs: ACCUMULO-1893
    https://issues.apache.org/jira/browse/ACCUMULO-1893


Repository: accumulo


Description
-------

ACCUMULO-1893 keep tests from attempting to write to the root of HDFS.

Reapplication of part of ACCUMULO-1563 to current branch.

Author: Jon Hsieh <jm...@apache.org>


Diffs
-----

  src/server/src/main/java/org/apache/accumulo/server/test/CreateMapFiles.java a57189437c6aee88af74e42254c8c6ffdec9b054 
  src/server/src/main/java/org/apache/accumulo/server/test/functional/BulkSplitOptimizationTest.java 3af414442e187de39a2f95895dad405c1616e1f7 

Diff: https://reviews.apache.org/r/15538/diff/


Testing
-------

unit tests pass, function test simple.compaction.CompactionTest fails without, passes with.


Thanks,

Sean Busbey


Re: Review Request 15538: ACCUMULO-1893 keep tests from attempting to write to the root of HDFS.

Posted by Ryan Fishel <ry...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15538/#review28898
-----------------------------------------------------------

Ship it!


Ship It!

- Ryan Fishel


On Nov. 14, 2013, 8:53 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15538/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2013, 8:53 p.m.)
> 
> 
> Review request for accumulo and Eric Newton.
> 
> 
> Bugs: ACCUMULO-1893
>     https://issues.apache.org/jira/browse/ACCUMULO-1893
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-1893 keep tests from attempting to write to the root of HDFS.
> 
> Reapplication of part of ACCUMULO-1563 to current branch.
> 
> Author: Jon Hsieh <jm...@apache.org>
> 
> 
> Diffs
> -----
> 
>   src/server/src/main/java/org/apache/accumulo/server/test/CreateMapFiles.java a57189437c6aee88af74e42254c8c6ffdec9b054 
>   src/server/src/main/java/org/apache/accumulo/server/test/functional/BulkSplitOptimizationTest.java 3af414442e187de39a2f95895dad405c1616e1f7 
> 
> Diff: https://reviews.apache.org/r/15538/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass, function test simple.compaction.CompactionTest fails without, passes with.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Re: Review Request 15538: ACCUMULO-1893 keep tests from attempting to write to the root of HDFS.

Posted by Christopher Tubbs <ct...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15538/#review28926
-----------------------------------------------------------


This patch is obsoleted by the work done on ACCUMULO-1599

- Christopher Tubbs


On Nov. 14, 2013, 3:53 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15538/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2013, 3:53 p.m.)
> 
> 
> Review request for accumulo and Eric Newton.
> 
> 
> Bugs: ACCUMULO-1893
>     https://issues.apache.org/jira/browse/ACCUMULO-1893
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-1893 keep tests from attempting to write to the root of HDFS.
> 
> Reapplication of part of ACCUMULO-1563 to current branch.
> 
> Author: Jon Hsieh <jm...@apache.org>
> 
> 
> Diffs
> -----
> 
>   src/server/src/main/java/org/apache/accumulo/server/test/CreateMapFiles.java a57189437c6aee88af74e42254c8c6ffdec9b054 
>   src/server/src/main/java/org/apache/accumulo/server/test/functional/BulkSplitOptimizationTest.java 3af414442e187de39a2f95895dad405c1616e1f7 
> 
> Diff: https://reviews.apache.org/r/15538/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass, function test simple.compaction.CompactionTest fails without, passes with.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Re: Review Request 15538: ACCUMULO-1893 keep tests from attempting to write to the root of HDFS.

Posted by Bill Havanki <bh...@clouderagovt.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15538/#review28905
-----------------------------------------------------------

Ship it!


(non-binding) The diff encompasses the changes that were missed in ACCUMULO-1563 that should have been applied to the Java files in 1.4.x. See accumulo-1536-1.4.patch under that ticket.

- Bill Havanki


On Nov. 14, 2013, 3:53 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15538/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2013, 3:53 p.m.)
> 
> 
> Review request for accumulo and Eric Newton.
> 
> 
> Bugs: ACCUMULO-1893
>     https://issues.apache.org/jira/browse/ACCUMULO-1893
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-1893 keep tests from attempting to write to the root of HDFS.
> 
> Reapplication of part of ACCUMULO-1563 to current branch.
> 
> Author: Jon Hsieh <jm...@apache.org>
> 
> 
> Diffs
> -----
> 
>   src/server/src/main/java/org/apache/accumulo/server/test/CreateMapFiles.java a57189437c6aee88af74e42254c8c6ffdec9b054 
>   src/server/src/main/java/org/apache/accumulo/server/test/functional/BulkSplitOptimizationTest.java 3af414442e187de39a2f95895dad405c1616e1f7 
> 
> Diff: https://reviews.apache.org/r/15538/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass, function test simple.compaction.CompactionTest fails without, passes with.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>