You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/19 05:15:54 UTC

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8596: [css] Simplifying SQL toolbar item margins, fixing overflow bug

codecov-io edited a comment on issue #8596: [css] Simplifying SQL toolbar item margins, fixing overflow bug
URL: https://github.com/apache/incubator-superset/pull/8596#issuecomment-555337133
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8596?src=pr&el=h1) Report
   > Merging [#8596](https://codecov.io/gh/apache/incubator-superset/pull/8596?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7d14b71a937f2dffd921b3c58007dfa4e07b7e0a?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `25%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8596/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8596?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master   #8596      +/-   ##
   =========================================
   + Coverage   65.69%   65.7%   +<.01%     
   =========================================
     Files         474     474              
     Lines       23587   23584       -3     
     Branches     2574    2573       -1     
   =========================================
   - Hits        15496   15495       -1     
   + Misses       7922    7920       -2     
     Partials      169     169
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8596?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ets/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8596/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9UZW1wbGF0ZVBhcmFtc0VkaXRvci5qc3g=) | `85.29% <ø> (ø)` | :arrow_up: |
   | [...uperset/assets/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8596/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TcWxFZGl0b3IuanN4) | `52.05% <25%> (+0.33%)` | :arrow_up: |
   | [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8596/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9DaGFydC5qc3g=) | `67.41% <0%> (ø)` | :arrow_up: |
   | [...rset/assets/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8596/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9EYXNoYm9hcmQuanN4) | `85% <0%> (+2.18%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8596?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8596?src=pr&el=footer). Last update [7d14b71...349b0c6](https://codecov.io/gh/apache/incubator-superset/pull/8596?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org