You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Suresh Antony (JIRA)" <ji...@apache.org> on 2008/11/26 00:27:44 UTC

[jira] Created: (HIVE-79) Print number of raws inserted to table(s) when the query is finished.

Print number of raws inserted to table(s) when  the query is finished.
----------------------------------------------------------------------

                 Key: HIVE-79
                 URL: https://issues.apache.org/jira/browse/HIVE-79
             Project: Hadoop Hive
          Issue Type: New Feature
    Affects Versions: 0.19.0
            Reporter: Suresh Antony
            Priority: Minor
             Fix For: 0.19.0


It is good to print the number of rows inserted into each table at end of query. 
insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;

This query can print something like:
tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-79) Print number of rows inserted to table(s) when the query is finished.

Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prasad Chakka updated HIVE-79:
------------------------------

    Summary: Print number of rows inserted to table(s) when  the query is finished.  (was: Print number of raws inserted to table(s) when  the query is finished.)

got tired of seeing raws

> Print number of rows inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Suresh Antony
>            Assignee: Suresh Antony
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: patch_79_1.txt, patch_79_2.txt
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-79) Print number of rows inserted to table(s) when the query is finished.

Posted by "Suresh Antony (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674327#action_12674327 ] 

Suresh Antony commented on HIVE-79:
-----------------------------------

if so can I commit this patch.

> Print number of rows inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Suresh Antony
>            Assignee: Suresh Antony
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: patch_79_1.txt, patch_79_2.txt, patch_79_3.txt
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-79) Print number of rows inserted to table(s) when the query is finished.

Posted by "Suresh Antony (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Antony updated HIVE-79:
------------------------------

    Attachment: patch_79_5.txt

Test failed yesterday because a new test was added.   The patch changes plan for filesink operator. A new test case will fail the unit test.

> Print number of rows inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Suresh Antony
>            Assignee: Suresh Antony
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: patch_79_1.txt, patch_79_2.txt, patch_79_3.txt, patch_79_4.txt, patch_79_5.txt
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-79) Print number of raws inserted to table(s) when the query is finished.

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668965#action_12668965 ] 

Namit Jain commented on HIVE-79:
--------------------------------

The id's in genFilesinkPlan() are always incremented. fileSinkDesc is created twice for evey table (in the common case of column pruning).

So, although, the FileSinkOperator has counters till 15, most of the tables will be doube-counted in the common case and logging wont happen when there are more than 8 tables.
Moreoever, this can get worse with more optimizer features.

clear the (id->name) map in reset()  and set the counter back to 0

> Print number of raws inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Suresh Antony
>            Assignee: Suresh Antony
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: patch_79_1.txt
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HIVE-79) Print number of rows inserted to table(s) when the query is finished.

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao resolved HIVE-79.
----------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 0.2.0)
                   0.3.0
     Release Note: HIVE-79. Print number of rows inserted to table(s) (Suresh Antony via zshao)
     Hadoop Flags: [Reviewed]

I fixed the test error and committed to trunk.
Committed revision 748058.
Thanks Suresh!


> Print number of rows inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Suresh Antony
>            Assignee: Suresh Antony
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: patch_79_1.txt, patch_79_2.txt, patch_79_3.txt, patch_79_4.txt, patch_79_5.txt
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-79) Print number of rows inserted to table(s) when the query is finished.

Posted by "Joydeep Sen Sarma (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673793#action_12673793 ] 

Joydeep Sen Sarma commented on HIVE-79:
---------------------------------------

can you please add a test (perhaps to testhivehistory?) that checks that the counter is correct for some insert operation.

otherwise looks good (the interplay between parseCtx and semanticanalyzer is pretty hard to understand - but seems like an orthogonal issue).

> Print number of rows inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Suresh Antony
>            Assignee: Suresh Antony
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: patch_79_1.txt, patch_79_2.txt, patch_79_3.txt
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-79) Print number of rows inserted to table(s) when the query is finished.

Posted by "Joydeep Sen Sarma (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674371#action_12674371 ] 

Joydeep Sen Sarma commented on HIVE-79:
---------------------------------------

+1

> Print number of rows inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Suresh Antony
>            Assignee: Suresh Antony
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: patch_79_1.txt, patch_79_2.txt, patch_79_3.txt
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HIVE-79) Print number of raws inserted to table(s) when the query is finished.

Posted by "Suresh Antony (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Antony reassigned HIVE-79:
---------------------------------

    Assignee: Suresh Antony

> Print number of raws inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Suresh Antony
>            Assignee: Suresh Antony
>            Priority: Minor
>             Fix For: 0.2.0
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-79) Print number of rows inserted to table(s) when the query is finished.

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676191#action_12676191 ] 

dhruba borthakur commented on HIVE-79:
--------------------------------------

This patch does not merge with hive trunk. 

@Suresh: can you pl upload a new patch? Thanks.

> Print number of rows inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Suresh Antony
>            Assignee: Suresh Antony
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: patch_79_1.txt, patch_79_2.txt, patch_79_3.txt
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-79) Print number of rows inserted to table(s) when the query is finished.

Posted by "Suresh Antony (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Antony updated HIVE-79:
------------------------------

    Attachment: patch_79_3.txt

1. Added printing row count to output
2.  Also added row count to Query hisory
3.  Changing the the test outputs because fileSinkDesc changed. Added table Id to file Sink Descriptor.

> Print number of rows inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Suresh Antony
>            Assignee: Suresh Antony
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: patch_79_1.txt, patch_79_2.txt, patch_79_3.txt
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-79) Print number of raws inserted to table(s) when the query is finished.

Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Thusoo updated HIVE-79:
------------------------------

    Component/s: Clients

> Print number of raws inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Clients
>    Affects Versions: 0.19.0
>            Reporter: Suresh Antony
>            Priority: Minor
>             Fix For: 0.19.0
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-79) Print number of rows inserted to table(s) when the query is finished.

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675768#action_12675768 ] 

dhruba borthakur commented on HIVE-79:
--------------------------------------

This should go into trunk and not into any branch, right?

> Print number of rows inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Suresh Antony
>            Assignee: Suresh Antony
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: patch_79_1.txt, patch_79_2.txt, patch_79_3.txt
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-79) Print number of rows inserted to table(s) when the query is finished.

Posted by "Joydeep Sen Sarma (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675816#action_12675816 ] 

Joydeep Sen Sarma commented on HIVE-79:
---------------------------------------

yeah - only trunk ..

> Print number of rows inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Suresh Antony
>            Assignee: Suresh Antony
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: patch_79_1.txt, patch_79_2.txt, patch_79_3.txt
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-79) Print number of rows inserted to table(s) when the query is finished.

Posted by "Joydeep Sen Sarma (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674041#action_12674041 ] 

Joydeep Sen Sarma commented on HIVE-79:
---------------------------------------

yeah - local mode is weird. in that case - we can punt and add the test once we move to minimr for testing.

> Print number of rows inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Suresh Antony
>            Assignee: Suresh Antony
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: patch_79_1.txt, patch_79_2.txt, patch_79_3.txt
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-79) Print number of rows inserted to table(s) when the query is finished.

Posted by "Suresh Antony (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Antony updated HIVE-79:
------------------------------

    Attachment: patch_79_4.txt

Resolved the conflicts

> Print number of rows inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Suresh Antony
>            Assignee: Suresh Antony
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: patch_79_1.txt, patch_79_2.txt, patch_79_3.txt, patch_79_4.txt
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-79) Print number of raws inserted to table(s) when the query is finished.

Posted by "Joydeep Sen Sarma (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joydeep Sen Sarma updated HIVE-79:
----------------------------------

    Component/s:     (was: Clients)
                 Logging

> Print number of raws inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>    Affects Versions: 0.19.0
>            Reporter: Suresh Antony
>            Priority: Minor
>             Fix For: 0.19.0
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-79) Print number of raws inserted to table(s) when the query is finished.

Posted by "Joydeep Sen Sarma (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672040#action_12672040 ] 

Joydeep Sen Sarma commented on HIVE-79:
---------------------------------------

we should also do this for insert overwrite directory case as well (from user perspective - i think it's equally useful to know row counts when extracting from hive).

from hivehistory perspective - these counters are query properties (and not properties of map-reduce jobs).

> Print number of raws inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Suresh Antony
>            Assignee: Suresh Antony
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: patch_79_1.txt, patch_79_2.txt
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-79) Print number of raws inserted to table(s) when the query is finished.

Posted by "Suresh Antony (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Antony updated HIVE-79:
------------------------------

    Attachment: patch_79_2.txt

Implemented the feedback by namit.
Reseting the id and map in the reset() call.
 

> Print number of raws inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Suresh Antony
>            Assignee: Suresh Antony
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: patch_79_1.txt, patch_79_2.txt
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-79) Print number of raws inserted to table(s) when the query is finished.

Posted by "Joydeep Sen Sarma (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672035#action_12672035 ] 

Joydeep Sen Sarma commented on HIVE-79:
---------------------------------------

Hey Namit - isn't there a new SemanticAnalyzer object getting created for each pass of the ColumnPruner? Just checking if the id wastage issue is resolved.

Also - it would be great if we could actually get this printed out on the cli as well (one for each table perhaps).


> Print number of raws inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Suresh Antony
>            Assignee: Suresh Antony
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: patch_79_1.txt, patch_79_2.txt
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-79) Print number of rows inserted to table(s) when the query is finished.

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676458#action_12676458 ] 

dhruba borthakur commented on HIVE-79:
--------------------------------------

This  fails unit test:

    [junit] Tests run: 144, Failures: 1, Errors: 0, Time elapsed: 760.913 sec^M
    [junit] Test org.apache.hadoop.hive.cli.TestCliDriver FAILED

> Print number of rows inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Suresh Antony
>            Assignee: Suresh Antony
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: patch_79_1.txt, patch_79_2.txt, patch_79_3.txt, patch_79_4.txt
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-79) Print number of raws inserted to table(s) when the query is finished.

Posted by "Suresh Antony (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Antony updated HIVE-79:
------------------------------

    Attachment: patch_79_1.txt

This path logs inserted row count to hive query log.  
Logged format will be:
TaskEnd TASK_ROWS_INSERTED="tmp_suresh_12:181687,tmp_suresh_13:181687"

Made changes to semantic analyzer keep tack id-table name map.

HiveHistory converts id back to table name and writes to structured query log.

> Print number of raws inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Suresh Antony
>            Assignee: Suresh Antony
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: patch_79_1.txt
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-79) Print number of rows inserted to table(s) when the query is finished.

Posted by "Suresh Antony (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673919#action_12673919 ] 

Suresh Antony commented on HIVE-79:
-----------------------------------

Trying to add test case ...
We run our test cases in local mode.
Looks like there are no counters getting created in local mode. Need to investigate more.

> Print number of rows inserted to table(s) when  the query is finished.
> ----------------------------------------------------------------------
>
>                 Key: HIVE-79
>                 URL: https://issues.apache.org/jira/browse/HIVE-79
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Suresh Antony
>            Assignee: Suresh Antony
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: patch_79_1.txt, patch_79_2.txt, patch_79_3.txt
>
>
> It is good to print the number of rows inserted into each table at end of query. 
> insert overwrite table tab1 select a.* from tab2 a where a.col1 = 10;
> This query can print something like:
> tab1 rows=100

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.