You are viewing a plain text version of this content. The canonical link for it is here.
Posted to sandesha-dev@ws.apache.org by "irantha suwandarathna (JIRA)" <ji...@apache.org> on 2008/12/05 12:13:44 UTC

[jira] Created: (SANDESHA2-185) Sandesha2 need to support JTA transactions

Sandesha2 need to support JTA transactions
------------------------------------------

                 Key: SANDESHA2-185
                 URL: https://issues.apache.org/jira/browse/SANDESHA2-185
             Project: Sandesha2
          Issue Type: New Feature
            Reporter: irantha suwandarathna
         Attachments: sandesa2_JTA.diff

Sandesha2 need to be able to participate in JTA transactions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org


[jira] Updated: (SANDESHA2-185) Sandesha2 need to support JTA transactions

Posted by "irantha suwandarathna (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SANDESHA2-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

irantha suwandarathna updated SANDESHA2-185:
--------------------------------------------

    Attachment:     (was: Sandesha2_JTA.patch)

> Sandesha2 need to support JTA transactions
> ------------------------------------------
>
>                 Key: SANDESHA2-185
>                 URL: https://issues.apache.org/jira/browse/SANDESHA2-185
>             Project: Sandesha2
>          Issue Type: New Feature
>            Reporter: irantha suwandarathna
>
> Sandesha2 need to be able to participate in JTA transactions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org


[jira] Updated: (SANDESHA2-185) Sandesha2 need to support JTA transactions

Posted by "irantha suwandarathna (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SANDESHA2-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

irantha suwandarathna updated SANDESHA2-185:
--------------------------------------------

    Attachment: sandesa2_JTA.diff

Attached  initial Sandesha2 JTA transaction implementation diffs for review.
 
Last JTA transactions created in  InvocationWorker spans up to inserting SenderBean in ApplicationMessageProcessor (this transactions spans through the service invocation). 
At lease this works for the simplest configuration with no threads created in between.
 
To enable JTA transactions, add following assertion to Sandesha2 policy configuration,
 
<sandesha2:UseJTATransactions>true</sandesha2:UseJTATransactions>
 
Sandesha2 module configuration is changed as following to use JTA aware datasource for persistance,
 
<moduleConfig>
<parameter name="db.dsName">java:DerbyDS</parameter>
<parameter name="db.icClass">org.jnp.interfaces.NamingContextFactory</parameter>
<parameter name="db.url">localhost:1099</parameter>
<parameter name="db.user">synapse</parameter>
<parameter name="db.password">synapse</parameter>
</moduleConfig>


> Sandesha2 need to support JTA transactions
> ------------------------------------------
>
>                 Key: SANDESHA2-185
>                 URL: https://issues.apache.org/jira/browse/SANDESHA2-185
>             Project: Sandesha2
>          Issue Type: New Feature
>            Reporter: irantha suwandarathna
>         Attachments: sandesa2_JTA.diff
>
>
> Sandesha2 need to be able to participate in JTA transactions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org


[jira] Updated: (SANDESHA2-185) Sandesha2 need to support JTA transactions

Posted by "irantha suwandarathna (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SANDESHA2-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

irantha suwandarathna updated SANDESHA2-185:
--------------------------------------------

    Attachment: Sandesha2_JTA.patch

Rebuild with latest Sandesha2 trunk.

> Sandesha2 need to support JTA transactions
> ------------------------------------------
>
>                 Key: SANDESHA2-185
>                 URL: https://issues.apache.org/jira/browse/SANDESHA2-185
>             Project: Sandesha2
>          Issue Type: New Feature
>            Reporter: irantha suwandarathna
>         Attachments: Sandesha2_JTA.patch
>
>
> Sandesha2 need to be able to participate in JTA transactions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org


[jira] Updated: (SANDESHA2-185) Sandesha2 need to support JTA transactions

Posted by "irantha suwandarathna (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SANDESHA2-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

irantha suwandarathna updated SANDESHA2-185:
--------------------------------------------

    Attachment:     (was: sandesa2_JTA.diff)

> Sandesha2 need to support JTA transactions
> ------------------------------------------
>
>                 Key: SANDESHA2-185
>                 URL: https://issues.apache.org/jira/browse/SANDESHA2-185
>             Project: Sandesha2
>          Issue Type: New Feature
>            Reporter: irantha suwandarathna
>
> Sandesha2 need to be able to participate in JTA transactions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org


[jira] Commented: (SANDESHA2-185) Sandesha2 need to support JTA transactions

Posted by "Andrew Gatford (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SANDESHA2-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653753#action_12653753 ] 

Andrew Gatford commented on SANDESHA2-185:
------------------------------------------

I'm finding it a little difficult to work out the relevant changes in this patch.

Can you change your editor to insert tabs, rather than spaces - the rest of the code is using tabs and having different formats makes the code unreadable.

Can you check the files that you are submitting in the patch ? It looks as though several of them only have whitespace changes - can those be removed?
I'm also getting a conflict on PersistentStorageManager.  Can you rebuild the patch on the latest code?

Thanks

> Sandesha2 need to support JTA transactions
> ------------------------------------------
>
>                 Key: SANDESHA2-185
>                 URL: https://issues.apache.org/jira/browse/SANDESHA2-185
>             Project: Sandesha2
>          Issue Type: New Feature
>            Reporter: irantha suwandarathna
>         Attachments: sandesa2_JTA.diff
>
>
> Sandesha2 need to be able to participate in JTA transactions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org


[jira] Updated: (SANDESHA2-185) Sandesha2 need to support JTA transactions

Posted by "irantha suwandarathna (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SANDESHA2-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

irantha suwandarathna updated SANDESHA2-185:
--------------------------------------------

    Attachment: Sandesha2_JTA.patch

Build with trunk

> Sandesha2 need to support JTA transactions
> ------------------------------------------
>
>                 Key: SANDESHA2-185
>                 URL: https://issues.apache.org/jira/browse/SANDESHA2-185
>             Project: Sandesha2
>          Issue Type: New Feature
>            Reporter: irantha suwandarathna
>         Attachments: Sandesha2_JTA.patch
>
>
> Sandesha2 need to be able to participate in JTA transactions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org


[jira] Commented: (SANDESHA2-185) Sandesha2 need to support JTA transactions

Posted by "Andrew Gatford (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SANDESHA2-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655975#action_12655975 ] 

Andrew Gatford commented on SANDESHA2-185:
------------------------------------------

I had a couple of comments on the patch:
1) You are still inserting spaces instead of tabs - please update your editor
2) The InvokerWorker has had a number of imports added which aren't used.
3) I'm not sure about the point of the getTransaction change inside the InvokerWorker.  In the storagemanager implementations that I've seen - if there is a transaction in use then calling getTransaction would always return a null.  This then protects sending responses from inside an invoke, so if there is an error, the transaction is rolled back and the service can be re-invoked.
Have you got any unit tests that demonstrate this functionality works ?

> Sandesha2 need to support JTA transactions
> ------------------------------------------
>
>                 Key: SANDESHA2-185
>                 URL: https://issues.apache.org/jira/browse/SANDESHA2-185
>             Project: Sandesha2
>          Issue Type: New Feature
>            Reporter: irantha suwandarathna
>         Attachments: Sandesha2_JTA.patch
>
>
> Sandesha2 need to be able to participate in JTA transactions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org


[jira] Commented: (SANDESHA2-185) Sandesha2 need to support JTA transactions

Posted by "Amila Chinthaka Suriarachchi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SANDESHA2-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655618#action_12655618 ] 

Amila Chinthaka Suriarachchi commented on SANDESHA2-185:
--------------------------------------------------------

this patch seems to be outdated. Can you create a one with the new trunk?

> Sandesha2 need to support JTA transactions
> ------------------------------------------
>
>                 Key: SANDESHA2-185
>                 URL: https://issues.apache.org/jira/browse/SANDESHA2-185
>             Project: Sandesha2
>          Issue Type: New Feature
>            Reporter: irantha suwandarathna
>         Attachments: Sandesha2_JTA.patch
>
>
> Sandesha2 need to be able to participate in JTA transactions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org