You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/22 13:39:49 UTC
[GitHub] [airflow] josh-fell opened a new pull request #17162: Adding custom Salesforce connection type + SalesforceToS3Operator updates
josh-fell opened a new pull request #17162:
URL: https://github.com/apache/airflow/pull/17162
Closes: #8766
Creating a new Salesforce connection type. Currently, the `security_token` is exposed in plain text and setting up the connection is not intuitive.
- [x] Update `SalesforceHook`
- [x] Update Salesforce connection docs
- [x] Update `SalesforceToS3Operator` and `SalesforceToGcsOperator`
- [x] Update Salesforce Hook test
Here is the new connection form:
I also updated -- effectively reverted a change to -- the output of the `SalesforceToS3Operator` from a previous PR of mine because of the issue mentioned in [this PR](https://github.com/apache/airflow/pull/16823).
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17162: Adding custom Salesforce connection type + SalesforceToS3Operator updates
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17162:
URL: https://github.com/apache/airflow/pull/17162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17162: Adding custom Salesforce connection type + SalesforceToS3Operator updates
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17162:
URL: https://github.com/apache/airflow/pull/17162#issuecomment-886157825
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org