[jira] [Commented] (SOLR-15421) ConfigSetService.checkConfigExists accepts empty configs

["Andras Salamon (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-15421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348188#comment-17348188 ] 

Andras Salamon commented on SOLR-15421:
---------------------------------------

I was not brave enough to modify checkConfigExists, so I introduced a new method to also check for solrconfig.xml: [https://github.com/apache/solr/pull/135]

I'm not sure if it a correct approach, maybe we should also check for other files here.

 

> ConfigSetService.checkConfigExists accepts empty configs
> --------------------------------------------------------
>
>                 Key: SOLR-15421
>                 URL: https://issues.apache.org/jira/browse/SOLR-15421
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Andras Salamon
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Both {{FileSystemConfigSetService}} and {{ZkConfigSetService}} only checks the existence of the directory only, if we accidentally create an empty config directory this method returns true, but when we try to use the configs to create a collection we got an error message like this:
> {noformat}
> Can't find resource 'solrconfig.xml' in classpath or '/configs/config_name', cwd=/path/to/lib/solr/server {noformat}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org