You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/01/08 20:28:00 UTC

[jira] [Updated] (ARROW-7516) [C#] .NET Benchmarks are broken

     [ https://issues.apache.org/jira/browse/ARROW-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated ARROW-7516:
----------------------------------
    Labels: pull-request-available  (was: )

> [C#] .NET Benchmarks are broken
> -------------------------------
>
>                 Key: ARROW-7516
>                 URL: https://issues.apache.org/jira/browse/ARROW-7516
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C#
>            Reporter: Eric Erhardt
>            Priority: Major
>              Labels: pull-request-available
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> See [https://github.com/apache/arrow/pull/6030#issuecomment-571877721]
>  
> It looks like the issue is that in the Benchmarks, `Length` is specified as `1_000_000`, and there has only been ~730,000 days since `DateTime.Min`, so this line fails:
> https://github.com/apache/arrow/blob/4634c89fc77f70fb5b5d035d6172263a4604da82/csharp/test/Apache.Arrow.Tests/TestData.cs#L130
> A simple fix would be to cap what we pass into `AddDays` to some number like `100_000`, or so.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)