You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "ildipo (via GitHub)" <gi...@apache.org> on 2023/06/07 18:10:31 UTC

[GitHub] [arrow] ildipo commented on a diff in pull request #35980: GH-35979: [C++] Acero - Add basic scalar and group-by window aggregation

ildipo commented on code in PR #35980:
URL: https://github.com/apache/arrow/pull/35980#discussion_r1221989239


##########
cpp/src/arrow/acero/CMakeLists.txt:
##########
@@ -29,7 +29,11 @@ endmacro()
 
 set(ARROW_ACERO_SRCS
     accumulation_queue.cc
-    aggregate_node.cc

Review Comment:
   `aggregate_node.cc` was split into `scalar_aggregate_node.cc`, `groupby_aggregate_node.cc` and `aggregate_internal.cc` - the existing code was moved as-is



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org