[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900576#comment-15900576 ] 

ASF GitHub Bot commented on ROCKETMQ-111:
-----------------------------------------

Github user shroman commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/69
  
    @zhouxinyu Probably you misunderstood what I meant :) -- this PR needs unit tests. I think it's the responsibility of the person who submitted PR to create them, whenever possible, since it reflects his/her intentions.
    @yilingfeng Can you please add unit tests?


> fix possible MQClientException when query message before today
> --------------------------------------------------------------
>
>                 Key: ROCKETMQ-111
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-111
>             Project: Apache RocketMQ
>          Issue Type: Bug
>          Components: rocketmq-commons
>    Affects Versions: 4.0.0-incubating
>            Reporter: Yiling Feng
>            Assignee: Jixiang Jin
>              Labels: build
>             Fix For: 4.0.0-incubating
>
>
> Using "cal.set(Calendar.HOUR,0);" when query message before today which may result in :
> "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: query message by key finished, but no message. "
> "HOUR" is used for the 12-hour clock.This will cause the start time of the query message to be greater than the creation time of the message.
> Implemenations:
> Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour clock.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)