You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/01/10 07:14:59 UTC
[GitHub] [incubator-apisix] membphis commented on issue #1022: Feature/chash
key support more flexible ways
membphis commented on issue #1022: Feature/chash key support more flexible ways
URL: https://github.com/apache/incubator-apisix/pull/1022#issuecomment-572904960
Test cases have some style issues that can be fixed separately by PR.
```diff
diff --git a/t/admin/routes.t b/t/admin/routes.t
index 51eeffb1..4db05f4d 100644
--- a/t/admin/routes.t
+++ b/t/admin/routes.t
@@ -1625,7 +1625,7 @@ GET /t
-=== TEST 43: set route(id: 1) and upstream(type:chash, hash_on: header, missing key)
+=== TEST 44: set route(id: 1) and upstream(type:chash, hash_on: header, missing key)
--- config
location /t {
content_by_lua_block {
@@ -1658,7 +1658,7 @@ GET /t
-=== TEST 44: set route(id: 1) and upstream(type:chash, hash_on: cookie, missing key)
+=== TEST 45: set route(id: 1) and upstream(type:chash, hash_on: cookie, missing key)
--- config
location /t {
content_by_lua_block {
@@ -1691,7 +1691,7 @@ GET /t
-=== TEST 45: set route(id: 1) and upstream(type:chash, hash_on: consumer, missing key is ok)
+=== TEST 46: set route(id: 1) and upstream(type:chash, hash_on: consumer, missing key is ok)
--- config
location /t {
content_by_lua_block {
@@ -1720,4 +1720,3 @@ GET /t
passed
--- no_error_log
[error]
-
diff --git a/t/admin/services.t b/t/admin/services.t
index c206508c..97d0aeac 100644
--- a/t/admin/services.t
+++ b/t/admin/services.t
@@ -877,4 +877,3 @@ GET /t
200 passed
--- no_error_log
[error]
-
diff --git a/t/admin/upstream.t b/t/admin/upstream.t
index 99d5a7fd..67359147 100644
--- a/t/admin/upstream.t
+++ b/t/admin/upstream.t
@@ -1230,4 +1230,3 @@ GET /t
{"error_msg":"invalid configuration: property \"hash_on\" validation failed: matches non of the enum values"}
--- no_error_log
[error]
-
diff --git a/t/node/chash-hashon.t b/t/node/chash-hashon.t
index 5839ec91..0348352f 100644
--- a/t/node/chash-hashon.t
+++ b/t/node/chash-hashon.t
@@ -200,7 +200,6 @@ chash_key: "jack"
-
=== TEST 4: hit routes, hash_on two consumer
--- config
location /t {
@@ -489,7 +488,6 @@ chash_key: "cuscookie"
-
=== TEST 10: hit routes, hash_on custom cookie miss, use default
--- config
location /t {
@@ -537,4 +535,3 @@ chash_key fetch is nil, use default chash_key remote_addr: 127.0.0.1
chash_key fetch is nil, use default chash_key remote_addr: 127.0.0.1
chash_key fetch is nil, use default chash_key remote_addr: 127.0.0.1
chash_key fetch is nil, use default chash_key remote_addr: 127.0.0.1
-
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services