[jira] [Commented] (AMQ-5473) Race condition caused by Linkstealing might make durable subs inactive

["Timothy Bish (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238649#comment-14238649 ] 

Timothy Bish commented on AMQ-5473:
-----------------------------------

Were you able to reproduce this in a test case?  I'm reviewing the change.

> Race condition caused by Linkstealing might make durable subs inactive
> ----------------------------------------------------------------------
>
>                 Key: AMQ-5473
>                 URL: https://issues.apache.org/jira/browse/AMQ-5473
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.11.0
>            Reporter: AR
>            Assignee: Timothy Bish
>         Attachments: linksteal_durablesub.patch
>
>
> Link Stealing creates a new connection and disconnects the old connection. These operations are done concurrently.
> New connection triggers addConsumer() for active subscriptions and old connection stop causes removeConsumer() for the same.
> Problems:
>  * addConsumer() would throw exception that the sub is already active (if remove did not happen before)
>  * even if we go past the exception, it will not set the right (new) connection context and consumer info the subs
>  * removeConsumer() may remove subcription even if it had different connection context (created by linkstealing)
> Patch attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)