You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/11/25 04:25:24 UTC

[GitHub] [singa] chrishkchris opened a new pull request #816: Update dev branch due to master branch hot-fix of onnx example error

chrishkchris opened a new pull request #816:
URL: https://github.com/apache/singa/pull/816


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] codecov[bot] edited a comment on pull request #816: Update dev branch due to master branch hot-fix of onnx example error

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #816:
URL: https://github.com/apache/singa/pull/816#issuecomment-733456508


   # [Codecov](https://codecov.io/gh/apache/singa/pull/816?src=pr&el=h1) Report
   > Merging [#816](https://codecov.io/gh/apache/singa/pull/816?src=pr&el=desc) (a8397fd) into [dev](https://codecov.io/gh/apache/singa/commit/ea8d671434717e16f98ab94917ede46338f2bdc7?el=desc) (ea8d671) will **increase** coverage by `1.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/816/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/816?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##              dev     #816      +/-   ##
   ==========================================
   + Coverage   65.09%   66.12%   +1.03%     
   ==========================================
     Files          86       87       +1     
     Lines        4804     5541     +737     
   ==========================================
   + Hits         3127     3664     +537     
   - Misses       1677     1877     +200     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | singa-cpp | `66.12% <ø> (+1.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/singa/pull/816?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [src/core/tensor/tensor\_math.h](https://codecov.io/gh/apache/singa/pull/816/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdGVuc29yL3RlbnNvcl9tYXRoLmg=) | `4.54% <0.00%> (-0.57%)` | :arrow_down: |
   | [include/half.hpp](https://codecov.io/gh/apache/singa/pull/816/diff?src=pr&el=tree#diff-aW5jbHVkZS9oYWxmLmhwcA==) | `0.00% <0.00%> (ø)` | |
   | [src/utils/logging.cc](https://codecov.io/gh/apache/singa/pull/816/diff?src=pr&el=tree#diff-c3JjL3V0aWxzL2xvZ2dpbmcuY2M=) | `50.68% <0.00%> (+1.40%)` | :arrow_up: |
   | [src/core/tensor/tensor.cc](https://codecov.io/gh/apache/singa/pull/816/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdGVuc29yL3RlbnNvci5jYw==) | `79.59% <0.00%> (+3.05%)` | :arrow_up: |
   | [src/core/tensor/tensor\_math\_cpp.h](https://codecov.io/gh/apache/singa/pull/816/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdGVuc29yL3RlbnNvcl9tYXRoX2NwcC5o) | `69.66% <0.00%> (+3.60%)` | :arrow_up: |
   | [include/singa/core/tensor.h](https://codecov.io/gh/apache/singa/pull/816/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3RlbnNvci5o) | `77.01% <0.00%> (+3.79%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/816?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/816?src=pr&el=footer). Last update [ea8d671...a8397fd](https://codecov.io/gh/apache/singa/pull/816?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] chrishkchris commented on pull request #816: Update dev branch due to master branch hot-fix of onnx example error

Posted by GitBox <gi...@apache.org>.
chrishkchris commented on pull request #816:
URL: https://github.com/apache/singa/pull/816#issuecomment-733456210


   ready for merge after the github actions checks are done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] lgtm-com[bot] commented on pull request #816: Update dev branch due to master branch hot-fix of onnx example error

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #816:
URL: https://github.com/apache/singa/pull/816#issuecomment-733458573


   This pull request **introduces 4 alerts** when merging a8397fd7d2d38306df073eaed8550542e19c50f8 into 0a4f433a316724e9e732e54b1dddc7c541ba48aa - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-b6eb665acb9eed6602fbf55dfe00401bc8b6e1f2)
   
   **new alerts:**
   
   * 3 for Unused import
   * 1 for Variable defined multiple times


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] chrishkchris merged pull request #816: Update dev branch due to master branch hot-fix of onnx example error

Posted by GitBox <gi...@apache.org>.
chrishkchris merged pull request #816:
URL: https://github.com/apache/singa/pull/816


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] codecov[bot] commented on pull request #816: Update dev branch due to master branch hot-fix of onnx example error

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #816:
URL: https://github.com/apache/singa/pull/816#issuecomment-733456508


   # [Codecov](https://codecov.io/gh/apache/singa/pull/816?src=pr&el=h1) Report
   > Merging [#816](https://codecov.io/gh/apache/singa/pull/816?src=pr&el=desc) (a8397fd) into [dev](https://codecov.io/gh/apache/singa/commit/ea8d671434717e16f98ab94917ede46338f2bdc7?el=desc) (ea8d671) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/816/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/816?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##              dev     #816   +/-   ##
   =======================================
     Coverage   65.09%   65.09%           
   =======================================
     Files          86       86           
     Lines        4804     4804           
   =======================================
     Hits         3127     3127           
     Misses       1677     1677           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | singa-cpp | `65.09% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/816?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/816?src=pr&el=footer). Last update [ea8d671...a8397fd](https://codecov.io/gh/apache/singa/pull/816?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org