DO NOT REPLY [Bug 34636] New: - URLUtil.URLDecode Decodes Plus Sign ("+") It Just Decoded

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34636>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34636

           Summary: URLUtil.URLDecode Decodes Plus Sign ("+") It Just
                    Decoded
           Product: Slide
           Version: 2.1
          Platform: All
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: WebDAV Server
        AssignedTo: slide-dev@jakarta.apache.org
        ReportedBy: bugzilla4dave@shepperton.us


The decoding routine decodes %xx into the equivalent character.  In the case of
%2b, the resulting character is the plus sign (+).  Separately, if the decoded
or undecoded character is a plus sign, it is replaced with a space.  I think
that the space for plus replacement should not take place if a decoding just
took place.  In a modification we made, we replaced this:

if (b == '+') {
  b = (byte)' ';
}

with this:

else if (b == '+') {
  b = (byte)' ';
}

That way, the just-decoded plus sign won't be turned into a space, but a literal
plus sign will be turned into a space.  As far as I can tell, this is the
correct behavior, and corrects a problem we were having storing files with plus
signs in their file names in Slide repositories.

We are using a modified version of SLIDE_2_1_M1_RELEASE on various platforms,
but the code quoted above is still present in the most recent CVS versions.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org