You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@toree.apache.org by Gino Bustelo <gi...@bustelos.com> on 2016/10/11 19:16:03 UTC
[VOTE] Apache Toree 0.1.0 RC2
Please vote to approve the release of the following candidate as
Apache Toree version 0.1.0
The commit to be voted on is 119bf3e2d1d16986f55802cf2323e8629ea25ef8
<https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8>
https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8
<https://github.com/apache/bahir/tree/368c436ae2ad34b3ca64d11801aee69e478555f7>
All distribution packages, including signatures, digests, etc. can be found at:
*https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/
<https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/>*
The vote is open for at least 72 hours and passes if a majority of at least
3 +1 PMC votes are cast.
[ ] +1 Release this package as Apache Toree 0.1.0
[ ] -1 Do not release this package because ...
Re: [VOTE] Apache Toree 0.1.0 RC2
Posted by Marius van Niekerk <ma...@gmail.com>.
I believe we need to make another vote thread.
On Wed, Oct 26, 2016 at 16:18 Gino Bustelo <gi...@bustelos.com> wrote:
> I address the NOTICE and the KEYS issues above. Put out another RC at
> https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc3/. Do I
> create another VOTE thread here of move it to general?
>
>
> On Thu, Oct 20, 2016 at 8:30 AM Gino Bustelo <gi...@bustelos.com> wrote:
>
> > Thanks Hitesh... I will address your comments above and put out an RC3
> for
> > vote here.
> >
> > On Tue, Oct 18, 2016 at 11:58 PM Hitesh Shah <hi...@apache.org> wrote:
> >
> > KEYS file should be at the top of the source tree and also inside the
> > https://dist.apache.org/repos/dist/release/incubator/toree/ dir.
> > markdown files support comments so ideally the apache license header
> > should be added.
> > When in doubt, keep the NOTICE file as small as possible. I would
> probably
> > err on the side of keeping it out of the NOTICE file for now and retain
> the
> > copyright line in the LICENSE file. I would recommending adding a couple
> of
> > lines in the incubator vote for folks to review the license/notice files
> > carefully as this is the first release.
> > For the one license per type - not a stop-ship but something to look at
> in
> > the future based on comments from the IPMC vote.
> > test-jars: Any reason they cannot be downloaded as part of the tests and
> > cached? In any case, as long as there is an ALv2 lineage for them, this
> is
> > not a stop-ship for now.
> >
> > thanks
> > — Hitesh
> >
> > > On Oct 17, 2016, at 8:41 AM, Gino Bustelo <gi...@bustelos.com> wrote:
> > >
> > > I'm working on changes in
> > https://github.com/apache/incubator-toree/pull/75.
> > > I've address most of the issues above.
> > >
> > >> - no KEYS file so no way to verify the gpg signature ( unless one
> > > downloads an unverified key from a public server )
> > > Where do I put this KEYS file?
> > >
> > >> - Something to check on - are the copyrights needed in the NOTICE file
> > or
> > > the LICENSE file? I am not too sure if there are needed in the NOTICE
> > file.
> > > Who can answer this? Is this a stop ship problem?
> > >
> > >> - Most projects tend to have one license file per license type and
> not a
> > > license file per dependency - with the copyrights called out in the
> main
> > > LICENSE file I believe.
> > > We did the initial work to prep for release a while back, so I can't
> > > remember what project we modeled against. Is this a stop ship problem?
> > >
> > >> - bunch of markdown files without a license header
> > > Do we have to add headers to these? Look at markdown files in Spark (
> > >
> >
> https://raw.githubusercontent.com/apache/spark/cff560755244dd4ccb998e0c56e81d2620cd4cff/docs/quick-start.md
> > ),
> > > they have no headers.
> > >
> > >> - there are a bunch of test jars checked into the source. Is there
> ALv2
> > > provenance for all of them (including the sparkr tarball )?
> > > Test jars are part of testing Magic downloading. They are ours.
> > >
> > >
> > > On Thu, Oct 13, 2016 at 6:00 PM Hitesh Shah <hi...@apache.org> wrote:
> > >
> > >> md5/sha sigs look fine. pgp sig also looked good though see below.
> > >>
> > >> Comments:
> > >> - no KEYS file so no way to verify the gpg signature ( unless one
> > >> downloads an unverified key from a public server )
> > >> - bin tarball should untar into an apache-toree-incubating or
> > >> apache-toree directory, source tarball untars into ./ - should be
> fixed
> > to
> > >> use a top-level dir IMO.
> > >> - Something to check on - are the copyrights needed in the NOTICE
> file
> > >> or the LICENSE file? I am not too sure if there are needed in the
> NOTICE
> > >> file.
> > >> - licenses/LICENSE-jline.txt seems to have some html but not the
> > actual
> > >> license content. Did not look at all the files so folks should
> re-check
> > >> those.
> > >> - Most projects tend to have one license file per license type and
> not
> > >> a license file per dependency - with the copyrights called out in the
> > main
> > >> LICENSE file I believe.
> > >> - source tarball seems to have too many licenses. Unless
> > >> jline/scala,asm.ammonite, etc are bundled into the source tarball,
> > they do
> > >> not need to be called out in the LICENSE and/or NOTICE file.
> > >> - bunch of markdown files without a license header
> > >> - there are a bunch of test jars checked into the source. Is there
> > ALv2
> > >> provenance for all of them (including the sparkr tarball )?
> > >>
> > >> Vote thread has a bahir related typo.
> > >>
> > >> thanks
> > >> — Hitesh
> > >>
> > >>
> > >>> On Oct 11, 2016, at 12:16 PM, Gino Bustelo <gi...@bustelos.com>
> wrote:
> > >>>
> > >>> Please vote to approve the release of the following candidate as
> > >>> Apache Toree version 0.1.0
> > >>>
> > >>>
> > >>> The commit to be voted on is 119bf3e2d1d16986f55802cf2323e8629ea25ef8
> > >>> <
> > >>
> >
> https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8
> > >>>
> > >>>
> > >>>
> > >>
> >
> https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8
> > >>> <
> > >>
> >
> https://github.com/apache/bahir/tree/368c436ae2ad34b3ca64d11801aee69e478555f7
> > >>>
> > >>>
> > >>> All distribution packages, including signatures, digests, etc. can be
> > >> found at:
> > >>>
> > >>> *https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/
> > >>> <https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/>*
> > >>>
> > >>> The vote is open for at least 72 hours and passes if a majority of at
> > >> least
> > >>> 3 +1 PMC votes are cast.
> > >>>
> > >>> [ ] +1 Release this package as Apache Toree 0.1.0
> > >>> [ ] -1 Do not release this package because ...
> > >>
> > >>
> >
> >
>
Re: [VOTE] Apache Toree 0.1.0 RC2
Posted by Gino Bustelo <gi...@bustelos.com>.
I address the NOTICE and the KEYS issues above. Put out another RC at
https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc3/. Do I
create another VOTE thread here of move it to general?
On Thu, Oct 20, 2016 at 8:30 AM Gino Bustelo <gi...@bustelos.com> wrote:
> Thanks Hitesh... I will address your comments above and put out an RC3 for
> vote here.
>
> On Tue, Oct 18, 2016 at 11:58 PM Hitesh Shah <hi...@apache.org> wrote:
>
> KEYS file should be at the top of the source tree and also inside the
> https://dist.apache.org/repos/dist/release/incubator/toree/ dir.
> markdown files support comments so ideally the apache license header
> should be added.
> When in doubt, keep the NOTICE file as small as possible. I would probably
> err on the side of keeping it out of the NOTICE file for now and retain the
> copyright line in the LICENSE file. I would recommending adding a couple of
> lines in the incubator vote for folks to review the license/notice files
> carefully as this is the first release.
> For the one license per type - not a stop-ship but something to look at in
> the future based on comments from the IPMC vote.
> test-jars: Any reason they cannot be downloaded as part of the tests and
> cached? In any case, as long as there is an ALv2 lineage for them, this is
> not a stop-ship for now.
>
> thanks
> — Hitesh
>
> > On Oct 17, 2016, at 8:41 AM, Gino Bustelo <gi...@bustelos.com> wrote:
> >
> > I'm working on changes in
> https://github.com/apache/incubator-toree/pull/75.
> > I've address most of the issues above.
> >
> >> - no KEYS file so no way to verify the gpg signature ( unless one
> > downloads an unverified key from a public server )
> > Where do I put this KEYS file?
> >
> >> - Something to check on - are the copyrights needed in the NOTICE file
> or
> > the LICENSE file? I am not too sure if there are needed in the NOTICE
> file.
> > Who can answer this? Is this a stop ship problem?
> >
> >> - Most projects tend to have one license file per license type and not a
> > license file per dependency - with the copyrights called out in the main
> > LICENSE file I believe.
> > We did the initial work to prep for release a while back, so I can't
> > remember what project we modeled against. Is this a stop ship problem?
> >
> >> - bunch of markdown files without a license header
> > Do we have to add headers to these? Look at markdown files in Spark (
> >
> https://raw.githubusercontent.com/apache/spark/cff560755244dd4ccb998e0c56e81d2620cd4cff/docs/quick-start.md
> ),
> > they have no headers.
> >
> >> - there are a bunch of test jars checked into the source. Is there ALv2
> > provenance for all of them (including the sparkr tarball )?
> > Test jars are part of testing Magic downloading. They are ours.
> >
> >
> > On Thu, Oct 13, 2016 at 6:00 PM Hitesh Shah <hi...@apache.org> wrote:
> >
> >> md5/sha sigs look fine. pgp sig also looked good though see below.
> >>
> >> Comments:
> >> - no KEYS file so no way to verify the gpg signature ( unless one
> >> downloads an unverified key from a public server )
> >> - bin tarball should untar into an apache-toree-incubating or
> >> apache-toree directory, source tarball untars into ./ - should be fixed
> to
> >> use a top-level dir IMO.
> >> - Something to check on - are the copyrights needed in the NOTICE file
> >> or the LICENSE file? I am not too sure if there are needed in the NOTICE
> >> file.
> >> - licenses/LICENSE-jline.txt seems to have some html but not the
> actual
> >> license content. Did not look at all the files so folks should re-check
> >> those.
> >> - Most projects tend to have one license file per license type and not
> >> a license file per dependency - with the copyrights called out in the
> main
> >> LICENSE file I believe.
> >> - source tarball seems to have too many licenses. Unless
> >> jline/scala,asm.ammonite, etc are bundled into the source tarball,
> they do
> >> not need to be called out in the LICENSE and/or NOTICE file.
> >> - bunch of markdown files without a license header
> >> - there are a bunch of test jars checked into the source. Is there
> ALv2
> >> provenance for all of them (including the sparkr tarball )?
> >>
> >> Vote thread has a bahir related typo.
> >>
> >> thanks
> >> — Hitesh
> >>
> >>
> >>> On Oct 11, 2016, at 12:16 PM, Gino Bustelo <gi...@bustelos.com> wrote:
> >>>
> >>> Please vote to approve the release of the following candidate as
> >>> Apache Toree version 0.1.0
> >>>
> >>>
> >>> The commit to be voted on is 119bf3e2d1d16986f55802cf2323e8629ea25ef8
> >>> <
> >>
> https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8
> >>>
> >>>
> >>>
> >>
> https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8
> >>> <
> >>
> https://github.com/apache/bahir/tree/368c436ae2ad34b3ca64d11801aee69e478555f7
> >>>
> >>>
> >>> All distribution packages, including signatures, digests, etc. can be
> >> found at:
> >>>
> >>> *https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/
> >>> <https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/>*
> >>>
> >>> The vote is open for at least 72 hours and passes if a majority of at
> >> least
> >>> 3 +1 PMC votes are cast.
> >>>
> >>> [ ] +1 Release this package as Apache Toree 0.1.0
> >>> [ ] -1 Do not release this package because ...
> >>
> >>
>
>
Re: [VOTE] Apache Toree 0.1.0 RC2
Posted by Gino Bustelo <gi...@bustelos.com>.
Thanks Hitesh... I will address your comments above and put out an RC3 for
vote here.
On Tue, Oct 18, 2016 at 11:58 PM Hitesh Shah <hi...@apache.org> wrote:
> KEYS file should be at the top of the source tree and also inside the
> https://dist.apache.org/repos/dist/release/incubator/toree/ dir.
> markdown files support comments so ideally the apache license header
> should be added.
> When in doubt, keep the NOTICE file as small as possible. I would probably
> err on the side of keeping it out of the NOTICE file for now and retain the
> copyright line in the LICENSE file. I would recommending adding a couple of
> lines in the incubator vote for folks to review the license/notice files
> carefully as this is the first release.
> For the one license per type - not a stop-ship but something to look at in
> the future based on comments from the IPMC vote.
> test-jars: Any reason they cannot be downloaded as part of the tests and
> cached? In any case, as long as there is an ALv2 lineage for them, this is
> not a stop-ship for now.
>
> thanks
> — Hitesh
>
> > On Oct 17, 2016, at 8:41 AM, Gino Bustelo <gi...@bustelos.com> wrote:
> >
> > I'm working on changes in
> https://github.com/apache/incubator-toree/pull/75.
> > I've address most of the issues above.
> >
> >> - no KEYS file so no way to verify the gpg signature ( unless one
> > downloads an unverified key from a public server )
> > Where do I put this KEYS file?
> >
> >> - Something to check on - are the copyrights needed in the NOTICE file
> or
> > the LICENSE file? I am not too sure if there are needed in the NOTICE
> file.
> > Who can answer this? Is this a stop ship problem?
> >
> >> - Most projects tend to have one license file per license type and not a
> > license file per dependency - with the copyrights called out in the main
> > LICENSE file I believe.
> > We did the initial work to prep for release a while back, so I can't
> > remember what project we modeled against. Is this a stop ship problem?
> >
> >> - bunch of markdown files without a license header
> > Do we have to add headers to these? Look at markdown files in Spark (
> >
> https://raw.githubusercontent.com/apache/spark/cff560755244dd4ccb998e0c56e81d2620cd4cff/docs/quick-start.md
> ),
> > they have no headers.
> >
> >> - there are a bunch of test jars checked into the source. Is there ALv2
> > provenance for all of them (including the sparkr tarball )?
> > Test jars are part of testing Magic downloading. They are ours.
> >
> >
> > On Thu, Oct 13, 2016 at 6:00 PM Hitesh Shah <hi...@apache.org> wrote:
> >
> >> md5/sha sigs look fine. pgp sig also looked good though see below.
> >>
> >> Comments:
> >> - no KEYS file so no way to verify the gpg signature ( unless one
> >> downloads an unverified key from a public server )
> >> - bin tarball should untar into an apache-toree-incubating or
> >> apache-toree directory, source tarball untars into ./ - should be fixed
> to
> >> use a top-level dir IMO.
> >> - Something to check on - are the copyrights needed in the NOTICE file
> >> or the LICENSE file? I am not too sure if there are needed in the NOTICE
> >> file.
> >> - licenses/LICENSE-jline.txt seems to have some html but not the
> actual
> >> license content. Did not look at all the files so folks should re-check
> >> those.
> >> - Most projects tend to have one license file per license type and not
> >> a license file per dependency - with the copyrights called out in the
> main
> >> LICENSE file I believe.
> >> - source tarball seems to have too many licenses. Unless
> >> jline/scala,asm.ammonite, etc are bundled into the source tarball,
> they do
> >> not need to be called out in the LICENSE and/or NOTICE file.
> >> - bunch of markdown files without a license header
> >> - there are a bunch of test jars checked into the source. Is there
> ALv2
> >> provenance for all of them (including the sparkr tarball )?
> >>
> >> Vote thread has a bahir related typo.
> >>
> >> thanks
> >> — Hitesh
> >>
> >>
> >>> On Oct 11, 2016, at 12:16 PM, Gino Bustelo <gi...@bustelos.com> wrote:
> >>>
> >>> Please vote to approve the release of the following candidate as
> >>> Apache Toree version 0.1.0
> >>>
> >>>
> >>> The commit to be voted on is 119bf3e2d1d16986f55802cf2323e8629ea25ef8
> >>> <
> >>
> https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8
> >>>
> >>>
> >>>
> >>
> https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8
> >>> <
> >>
> https://github.com/apache/bahir/tree/368c436ae2ad34b3ca64d11801aee69e478555f7
> >>>
> >>>
> >>> All distribution packages, including signatures, digests, etc. can be
> >> found at:
> >>>
> >>> *https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/
> >>> <https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/>*
> >>>
> >>> The vote is open for at least 72 hours and passes if a majority of at
> >> least
> >>> 3 +1 PMC votes are cast.
> >>>
> >>> [ ] +1 Release this package as Apache Toree 0.1.0
> >>> [ ] -1 Do not release this package because ...
> >>
> >>
>
>
Re: [VOTE] Apache Toree 0.1.0 RC2
Posted by Hitesh Shah <hi...@apache.org>.
KEYS file should be at the top of the source tree and also inside the https://dist.apache.org/repos/dist/release/incubator/toree/ dir.
markdown files support comments so ideally the apache license header should be added.
When in doubt, keep the NOTICE file as small as possible. I would probably err on the side of keeping it out of the NOTICE file for now and retain the copyright line in the LICENSE file. I would recommending adding a couple of lines in the incubator vote for folks to review the license/notice files carefully as this is the first release.
For the one license per type - not a stop-ship but something to look at in the future based on comments from the IPMC vote.
test-jars: Any reason they cannot be downloaded as part of the tests and cached? In any case, as long as there is an ALv2 lineage for them, this is not a stop-ship for now.
thanks
— Hitesh
> On Oct 17, 2016, at 8:41 AM, Gino Bustelo <gi...@bustelos.com> wrote:
>
> I'm working on changes in https://github.com/apache/incubator-toree/pull/75.
> I've address most of the issues above.
>
>> - no KEYS file so no way to verify the gpg signature ( unless one
> downloads an unverified key from a public server )
> Where do I put this KEYS file?
>
>> - Something to check on - are the copyrights needed in the NOTICE file or
> the LICENSE file? I am not too sure if there are needed in the NOTICE file.
> Who can answer this? Is this a stop ship problem?
>
>> - Most projects tend to have one license file per license type and not a
> license file per dependency - with the copyrights called out in the main
> LICENSE file I believe.
> We did the initial work to prep for release a while back, so I can't
> remember what project we modeled against. Is this a stop ship problem?
>
>> - bunch of markdown files without a license header
> Do we have to add headers to these? Look at markdown files in Spark (
> https://raw.githubusercontent.com/apache/spark/cff560755244dd4ccb998e0c56e81d2620cd4cff/docs/quick-start.md),
> they have no headers.
>
>> - there are a bunch of test jars checked into the source. Is there ALv2
> provenance for all of them (including the sparkr tarball )?
> Test jars are part of testing Magic downloading. They are ours.
>
>
> On Thu, Oct 13, 2016 at 6:00 PM Hitesh Shah <hi...@apache.org> wrote:
>
>> md5/sha sigs look fine. pgp sig also looked good though see below.
>>
>> Comments:
>> - no KEYS file so no way to verify the gpg signature ( unless one
>> downloads an unverified key from a public server )
>> - bin tarball should untar into an apache-toree-incubating or
>> apache-toree directory, source tarball untars into ./ - should be fixed to
>> use a top-level dir IMO.
>> - Something to check on - are the copyrights needed in the NOTICE file
>> or the LICENSE file? I am not too sure if there are needed in the NOTICE
>> file.
>> - licenses/LICENSE-jline.txt seems to have some html but not the actual
>> license content. Did not look at all the files so folks should re-check
>> those.
>> - Most projects tend to have one license file per license type and not
>> a license file per dependency - with the copyrights called out in the main
>> LICENSE file I believe.
>> - source tarball seems to have too many licenses. Unless
>> jline/scala,asm.ammonite, etc are bundled into the source tarball, they do
>> not need to be called out in the LICENSE and/or NOTICE file.
>> - bunch of markdown files without a license header
>> - there are a bunch of test jars checked into the source. Is there ALv2
>> provenance for all of them (including the sparkr tarball )?
>>
>> Vote thread has a bahir related typo.
>>
>> thanks
>> — Hitesh
>>
>>
>>> On Oct 11, 2016, at 12:16 PM, Gino Bustelo <gi...@bustelos.com> wrote:
>>>
>>> Please vote to approve the release of the following candidate as
>>> Apache Toree version 0.1.0
>>>
>>>
>>> The commit to be voted on is 119bf3e2d1d16986f55802cf2323e8629ea25ef8
>>> <
>> https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8
>>>
>>>
>>>
>> https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8
>>> <
>> https://github.com/apache/bahir/tree/368c436ae2ad34b3ca64d11801aee69e478555f7
>>>
>>>
>>> All distribution packages, including signatures, digests, etc. can be
>> found at:
>>>
>>> *https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/
>>> <https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/>*
>>>
>>> The vote is open for at least 72 hours and passes if a majority of at
>> least
>>> 3 +1 PMC votes are cast.
>>>
>>> [ ] +1 Release this package as Apache Toree 0.1.0
>>> [ ] -1 Do not release this package because ...
>>
>>
Re: [VOTE] Apache Toree 0.1.0 RC2
Posted by Gino Bustelo <gi...@bustelos.com>.
Actually... on the license thing, we also followed Spark's lead
https://github.com/apache/spark/tree/cff560755244dd4ccb998e0c56e81d2620cd4cff/licenses
On Mon, Oct 17, 2016 at 10:41 AM Gino Bustelo <gi...@bustelos.com> wrote:
> I'm working on changes in
> https://github.com/apache/incubator-toree/pull/75. I've address most of
> the issues above.
>
> > - no KEYS file so no way to verify the gpg signature ( unless one
> downloads an unverified key from a public server )
> Where do I put this KEYS file?
>
> > - Something to check on - are the copyrights needed in the NOTICE file
> or the LICENSE file? I am not too sure if there are needed in the NOTICE
> file.
> Who can answer this? Is this a stop ship problem?
>
> > - Most projects tend to have one license file per license type and not
> a license file per dependency - with the copyrights called out in the main
> LICENSE file I believe.
> We did the initial work to prep for release a while back, so I can't
> remember what project we modeled against. Is this a stop ship problem?
>
> > - bunch of markdown files without a license header
> Do we have to add headers to these? Look at markdown files in Spark (
> https://raw.githubusercontent.com/apache/spark/cff560755244dd4ccb998e0c56e81d2620cd4cff/docs/quick-start.md),
> they have no headers.
>
> > - there are a bunch of test jars checked into the source. Is there ALv2
> provenance for all of them (including the sparkr tarball )?
> Test jars are part of testing Magic downloading. They are ours.
>
>
> On Thu, Oct 13, 2016 at 6:00 PM Hitesh Shah <hi...@apache.org> wrote:
>
> md5/sha sigs look fine. pgp sig also looked good though see below.
>
> Comments:
> - no KEYS file so no way to verify the gpg signature ( unless one
> downloads an unverified key from a public server )
> - bin tarball should untar into an apache-toree-incubating or
> apache-toree directory, source tarball untars into ./ - should be fixed to
> use a top-level dir IMO.
> - Something to check on - are the copyrights needed in the NOTICE file
> or the LICENSE file? I am not too sure if there are needed in the NOTICE
> file.
> - licenses/LICENSE-jline.txt seems to have some html but not the actual
> license content. Did not look at all the files so folks should re-check
> those.
> - Most projects tend to have one license file per license type and not
> a license file per dependency - with the copyrights called out in the main
> LICENSE file I believe.
> - source tarball seems to have too many licenses. Unless
> jline/scala,asm.ammonite, etc are bundled into the source tarball, they do
> not need to be called out in the LICENSE and/or NOTICE file.
> - bunch of markdown files without a license header
> - there are a bunch of test jars checked into the source. Is there ALv2
> provenance for all of them (including the sparkr tarball )?
>
> Vote thread has a bahir related typo.
>
> thanks
> — Hitesh
>
>
> > On Oct 11, 2016, at 12:16 PM, Gino Bustelo <gi...@bustelos.com> wrote:
> >
> > Please vote to approve the release of the following candidate as
> > Apache Toree version 0.1.0
> >
> >
> > The commit to be voted on is 119bf3e2d1d16986f55802cf2323e8629ea25ef8
> > <
> https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8
> >
> >
> >
> https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8
> > <
> https://github.com/apache/bahir/tree/368c436ae2ad34b3ca64d11801aee69e478555f7
> >
> >
> > All distribution packages, including signatures, digests, etc. can be
> found at:
> >
> > *https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/
> > <https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/>*
> >
> > The vote is open for at least 72 hours and passes if a majority of at
> least
> > 3 +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Toree 0.1.0
> > [ ] -1 Do not release this package because ...
>
>
Re: [VOTE] Apache Toree 0.1.0 RC2
Posted by Gino Bustelo <gi...@bustelos.com>.
I'm working on changes in https://github.com/apache/incubator-toree/pull/75.
I've address most of the issues above.
> - no KEYS file so no way to verify the gpg signature ( unless one
downloads an unverified key from a public server )
Where do I put this KEYS file?
> - Something to check on - are the copyrights needed in the NOTICE file or
the LICENSE file? I am not too sure if there are needed in the NOTICE file.
Who can answer this? Is this a stop ship problem?
> - Most projects tend to have one license file per license type and not a
license file per dependency - with the copyrights called out in the main
LICENSE file I believe.
We did the initial work to prep for release a while back, so I can't
remember what project we modeled against. Is this a stop ship problem?
> - bunch of markdown files without a license header
Do we have to add headers to these? Look at markdown files in Spark (
https://raw.githubusercontent.com/apache/spark/cff560755244dd4ccb998e0c56e81d2620cd4cff/docs/quick-start.md),
they have no headers.
> - there are a bunch of test jars checked into the source. Is there ALv2
provenance for all of them (including the sparkr tarball )?
Test jars are part of testing Magic downloading. They are ours.
On Thu, Oct 13, 2016 at 6:00 PM Hitesh Shah <hi...@apache.org> wrote:
> md5/sha sigs look fine. pgp sig also looked good though see below.
>
> Comments:
> - no KEYS file so no way to verify the gpg signature ( unless one
> downloads an unverified key from a public server )
> - bin tarball should untar into an apache-toree-incubating or
> apache-toree directory, source tarball untars into ./ - should be fixed to
> use a top-level dir IMO.
> - Something to check on - are the copyrights needed in the NOTICE file
> or the LICENSE file? I am not too sure if there are needed in the NOTICE
> file.
> - licenses/LICENSE-jline.txt seems to have some html but not the actual
> license content. Did not look at all the files so folks should re-check
> those.
> - Most projects tend to have one license file per license type and not
> a license file per dependency - with the copyrights called out in the main
> LICENSE file I believe.
> - source tarball seems to have too many licenses. Unless
> jline/scala,asm.ammonite, etc are bundled into the source tarball, they do
> not need to be called out in the LICENSE and/or NOTICE file.
> - bunch of markdown files without a license header
> - there are a bunch of test jars checked into the source. Is there ALv2
> provenance for all of them (including the sparkr tarball )?
>
> Vote thread has a bahir related typo.
>
> thanks
> — Hitesh
>
>
> > On Oct 11, 2016, at 12:16 PM, Gino Bustelo <gi...@bustelos.com> wrote:
> >
> > Please vote to approve the release of the following candidate as
> > Apache Toree version 0.1.0
> >
> >
> > The commit to be voted on is 119bf3e2d1d16986f55802cf2323e8629ea25ef8
> > <
> https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8
> >
> >
> >
> https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8
> > <
> https://github.com/apache/bahir/tree/368c436ae2ad34b3ca64d11801aee69e478555f7
> >
> >
> > All distribution packages, including signatures, digests, etc. can be
> found at:
> >
> > *https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/
> > <https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/>*
> >
> > The vote is open for at least 72 hours and passes if a majority of at
> least
> > 3 +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Toree 0.1.0
> > [ ] -1 Do not release this package because ...
>
>
Re: [VOTE] Apache Toree 0.1.0 RC2
Posted by Hitesh Shah <hi...@apache.org>.
md5/sha sigs look fine. pgp sig also looked good though see below.
Comments:
- no KEYS file so no way to verify the gpg signature ( unless one downloads an unverified key from a public server )
- bin tarball should untar into an apache-toree-incubating or apache-toree directory, source tarball untars into ./ - should be fixed to use a top-level dir IMO.
- Something to check on - are the copyrights needed in the NOTICE file or the LICENSE file? I am not too sure if there are needed in the NOTICE file.
- licenses/LICENSE-jline.txt seems to have some html but not the actual license content. Did not look at all the files so folks should re-check those.
- Most projects tend to have one license file per license type and not a license file per dependency - with the copyrights called out in the main LICENSE file I believe.
- source tarball seems to have too many licenses. Unless jline/scala,asm.ammonite, etc are bundled into the source tarball, they do not need to be called out in the LICENSE and/or NOTICE file.
- bunch of markdown files without a license header
- there are a bunch of test jars checked into the source. Is there ALv2 provenance for all of them (including the sparkr tarball )?
Vote thread has a bahir related typo.
thanks
— Hitesh
> On Oct 11, 2016, at 12:16 PM, Gino Bustelo <gi...@bustelos.com> wrote:
>
> Please vote to approve the release of the following candidate as
> Apache Toree version 0.1.0
>
>
> The commit to be voted on is 119bf3e2d1d16986f55802cf2323e8629ea25ef8
> <https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8>
>
> https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8
> <https://github.com/apache/bahir/tree/368c436ae2ad34b3ca64d11801aee69e478555f7>
>
> All distribution packages, including signatures, digests, etc. can be found at:
>
> *https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/
> <https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/>*
>
> The vote is open for at least 72 hours and passes if a majority of at least
> 3 +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Toree 0.1.0
> [ ] -1 Do not release this package because ...
Re: [VOTE] Apache Toree 0.1.0 RC2
Posted by Gino Bustelo <gi...@bustelos.com>.
For pip it is challenging. It may not have the name "incubating" but it
does alerts of incubation during installation. It is also on the
description of the package. Placing the "incubating" in the version is not
possible since it will make it an invalid version format. Adding it to the
name is also not ideal since it will identify the package and will force a
new package with new history after graduation.
On Wed, Oct 12, 2016 at 4:48 PM Hitesh Shah <hi...@apache.org> wrote:
> The pip bundle does not have “incubating” in either the name or the
> version so that should be something to address.
>
> Will look at the RC in more detail and provide feedback.
>
> For others who are reviewing the RC,
> http://incubator.apache.org/guides/release.html#checklist ( or
> http://incubator.apache.org/guides/releasemanagement.html#check-list ) is
> a useful set of things to look for when vetting a release candidate.
>
> thanks
> — Hitesh
>
>
> > On Oct 11, 2016, at 12:16 PM, Gino Bustelo <gi...@bustelos.com> wrote:
> >
> > Please vote to approve the release of the following candidate as
> > Apache Toree version 0.1.0
> >
> >
> > The commit to be voted on is 119bf3e2d1d16986f55802cf2323e8629ea25ef8
> > <
> https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8
> >
> >
> >
> https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8
> > <
> https://github.com/apache/bahir/tree/368c436ae2ad34b3ca64d11801aee69e478555f7
> >
> >
> > All distribution packages, including signatures, digests, etc. can be
> found at:
> >
> > *https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/
> > <https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/>*
> >
> > The vote is open for at least 72 hours and passes if a majority of at
> least
> > 3 +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Toree 0.1.0
> > [ ] -1 Do not release this package because ...
>
>
Re: [VOTE] Apache Toree 0.1.0 RC2
Posted by Hitesh Shah <hi...@apache.org>.
The pip bundle does not have “incubating” in either the name or the version so that should be something to address.
Will look at the RC in more detail and provide feedback.
For others who are reviewing the RC, http://incubator.apache.org/guides/release.html#checklist ( or http://incubator.apache.org/guides/releasemanagement.html#check-list ) is a useful set of things to look for when vetting a release candidate.
thanks
— Hitesh
> On Oct 11, 2016, at 12:16 PM, Gino Bustelo <gi...@bustelos.com> wrote:
>
> Please vote to approve the release of the following candidate as
> Apache Toree version 0.1.0
>
>
> The commit to be voted on is 119bf3e2d1d16986f55802cf2323e8629ea25ef8
> <https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8>
>
> https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8
> <https://github.com/apache/bahir/tree/368c436ae2ad34b3ca64d11801aee69e478555f7>
>
> All distribution packages, including signatures, digests, etc. can be found at:
>
> *https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/
> <https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/>*
>
> The vote is open for at least 72 hours and passes if a majority of at least
> 3 +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Toree 0.1.0
> [ ] -1 Do not release this package because ...
Re: [VOTE] Apache Toree 0.1.0 RC2
Posted by Corey Stubbs <ca...@gmail.com>.
+1 Release this package as Apache Toree 0.1.0
On Tue, Oct 11, 2016 at 2:16 PM Gino Bustelo <gi...@bustelos.com> wrote:
> Please vote to approve the release of the following candidate as
> Apache Toree version 0.1.0
>
>
> The commit to be voted on is 119bf3e2d1d16986f55802cf2323e8629ea25ef8
> <
> https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8
> >
>
>
> https://github.com/apache/incubator-toree/tree/119bf3e2d1d16986f55802cf2323e8629ea25ef8
> <
> https://github.com/apache/bahir/tree/368c436ae2ad34b3ca64d11801aee69e478555f7
> >
>
> All distribution packages, including signatures, digests, etc. can be
> found at:
>
> *https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/
> <https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/>*
>
> The vote is open for at least 72 hours and passes if a majority of at least
> 3 +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Toree 0.1.0
> [ ] -1 Do not release this package because ...
>
Re: [VOTE] Apache Toree 0.1.0 RC2
Posted by Chip Senkbeil <ch...@gmail.com>.
+1
On Wed, Oct 12, 2016 at 12:47 PM Marius van Niekerk <
marius.v.niekerk@gmail.com> wrote:
> +1
>
> On Tue, 11 Oct 2016 at 16:22 Gino Bustelo <gi...@bustelos.com> wrote:
>
> > Tagged as v0.1.0-rc2 and points to the commit. I was trying to avoid
> overly
> > tagging and reserving them for actual releases. Instead... I was placing
> a
> > commit to mark the RC.
> >
> > On Tue, Oct 11, 2016 at 3:14 PM Luciano Resende <lu...@gmail.com>
> > wrote:
> >
> > > On Tue, Oct 11, 2016 at 12:16 PM, Gino Bustelo <gi...@bustelos.com>
> > wrote:
> > >
> > > > Please vote to approve the release of the following candidate as
> > > > Apache Toree version 0.1.0
> > > >
> > > >
> > > > The commit to be voted on is 119bf3e2d1d16986f55802cf2323e8629ea25ef8
> > > > <https://github.com/apache/incubator-toree/tree/
> > > > 119bf3e2d1d16986f55802cf2323e8629ea25ef8>
> > > >
> > > > https://github.com/apache/incubator-toree/tree/
> > > > 119bf3e2d1d16986f55802cf2323e8629ea25ef8
> > > > <https://github.com/apache/bahir/tree/368c436ae2ad34b3ca64d11801aee6
> > > > 9e478555f7>
> > > >
> > > > All distribution packages, including signatures, digests, etc. can be
> > > > found at:
> > > >
> > > > *https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/
> > > > <https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/>*
> > > >
> > > > The vote is open for at least 72 hours and passes if a majority of at
> > > least
> > > > 3 +1 PMC votes are cast.
> > > >
> > > > [ ] +1 Release this package as Apache Toree 0.1.0
> > > > [ ] -1 Do not release this package because ...
> > > >
> > >
> > >
> > > Note there should be a tag associated with the vote. I am assuming that
> > the
> > > tag will be based on 119bf3e2d1d16986f55802cf2323e8629ea25ef8
> > >
> > > --
> > > Luciano Resende
> > > http://twitter.com/lresende1975
> > > http://lresende.blogspot.com/
> > >
> >
>
Re: [VOTE] Apache Toree 0.1.0 RC2
Posted by Marius van Niekerk <ma...@gmail.com>.
+1
On Tue, 11 Oct 2016 at 16:22 Gino Bustelo <gi...@bustelos.com> wrote:
> Tagged as v0.1.0-rc2 and points to the commit. I was trying to avoid overly
> tagging and reserving them for actual releases. Instead... I was placing a
> commit to mark the RC.
>
> On Tue, Oct 11, 2016 at 3:14 PM Luciano Resende <lu...@gmail.com>
> wrote:
>
> > On Tue, Oct 11, 2016 at 12:16 PM, Gino Bustelo <gi...@bustelos.com>
> wrote:
> >
> > > Please vote to approve the release of the following candidate as
> > > Apache Toree version 0.1.0
> > >
> > >
> > > The commit to be voted on is 119bf3e2d1d16986f55802cf2323e8629ea25ef8
> > > <https://github.com/apache/incubator-toree/tree/
> > > 119bf3e2d1d16986f55802cf2323e8629ea25ef8>
> > >
> > > https://github.com/apache/incubator-toree/tree/
> > > 119bf3e2d1d16986f55802cf2323e8629ea25ef8
> > > <https://github.com/apache/bahir/tree/368c436ae2ad34b3ca64d11801aee6
> > > 9e478555f7>
> > >
> > > All distribution packages, including signatures, digests, etc. can be
> > > found at:
> > >
> > > *https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/
> > > <https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/>*
> > >
> > > The vote is open for at least 72 hours and passes if a majority of at
> > least
> > > 3 +1 PMC votes are cast.
> > >
> > > [ ] +1 Release this package as Apache Toree 0.1.0
> > > [ ] -1 Do not release this package because ...
> > >
> >
> >
> > Note there should be a tag associated with the vote. I am assuming that
> the
> > tag will be based on 119bf3e2d1d16986f55802cf2323e8629ea25ef8
> >
> > --
> > Luciano Resende
> > http://twitter.com/lresende1975
> > http://lresende.blogspot.com/
> >
>
Re: [VOTE] Apache Toree 0.1.0 RC2
Posted by Gino Bustelo <gi...@bustelos.com>.
Tagged as v0.1.0-rc2 and points to the commit. I was trying to avoid overly
tagging and reserving them for actual releases. Instead... I was placing a
commit to mark the RC.
On Tue, Oct 11, 2016 at 3:14 PM Luciano Resende <lu...@gmail.com>
wrote:
> On Tue, Oct 11, 2016 at 12:16 PM, Gino Bustelo <gi...@bustelos.com> wrote:
>
> > Please vote to approve the release of the following candidate as
> > Apache Toree version 0.1.0
> >
> >
> > The commit to be voted on is 119bf3e2d1d16986f55802cf2323e8629ea25ef8
> > <https://github.com/apache/incubator-toree/tree/
> > 119bf3e2d1d16986f55802cf2323e8629ea25ef8>
> >
> > https://github.com/apache/incubator-toree/tree/
> > 119bf3e2d1d16986f55802cf2323e8629ea25ef8
> > <https://github.com/apache/bahir/tree/368c436ae2ad34b3ca64d11801aee6
> > 9e478555f7>
> >
> > All distribution packages, including signatures, digests, etc. can be
> > found at:
> >
> > *https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/
> > <https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/>*
> >
> > The vote is open for at least 72 hours and passes if a majority of at
> least
> > 3 +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Toree 0.1.0
> > [ ] -1 Do not release this package because ...
> >
>
>
> Note there should be a tag associated with the vote. I am assuming that the
> tag will be based on 119bf3e2d1d16986f55802cf2323e8629ea25ef8
>
> --
> Luciano Resende
> http://twitter.com/lresende1975
> http://lresende.blogspot.com/
>
Re: [VOTE] Apache Toree 0.1.0 RC2
Posted by Luciano Resende <lu...@gmail.com>.
On Tue, Oct 11, 2016 at 12:16 PM, Gino Bustelo <gi...@bustelos.com> wrote:
> Please vote to approve the release of the following candidate as
> Apache Toree version 0.1.0
>
>
> The commit to be voted on is 119bf3e2d1d16986f55802cf2323e8629ea25ef8
> <https://github.com/apache/incubator-toree/tree/
> 119bf3e2d1d16986f55802cf2323e8629ea25ef8>
>
> https://github.com/apache/incubator-toree/tree/
> 119bf3e2d1d16986f55802cf2323e8629ea25ef8
> <https://github.com/apache/bahir/tree/368c436ae2ad34b3ca64d11801aee6
> 9e478555f7>
>
> All distribution packages, including signatures, digests, etc. can be
> found at:
>
> *https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/
> <https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc2/>*
>
> The vote is open for at least 72 hours and passes if a majority of at least
> 3 +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Toree 0.1.0
> [ ] -1 Do not release this package because ...
>
Note there should be a tag associated with the vote. I am assuming that the
tag will be based on 119bf3e2d1d16986f55802cf2323e8629ea25ef8
--
Luciano Resende
http://twitter.com/lresende1975
http://lresende.blogspot.com/