You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Paul Lindner <li...@inuus.com> on 2011/09/23 11:06:18 UTC
Review Request: Upgrade htmlunit to 2.9 and required dependency on nekohtml
to 1.9.15
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2035/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
Deps upgrade.
Diffs
-----
/trunk/pom.xml 1174464
Diff: https://reviews.apache.org/r/2035/diff
Testing
-------
EndToEnd tests (which use htmlunit) working correctly.
Existing parser tests pass.
Smoke test of gadgets working.
Thanks,
Paul
Re: Review Request: Upgrade htmlunit to 2.9 and required dependency on
nekohtml to 1.9.15
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2035/#review2040
-----------------------------------------------------------
Ship it!
LGTM
- Ryan
On 2011-09-23 09:06:17, Paul Lindner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2035/
> -----------------------------------------------------------
>
> (Updated 2011-09-23 09:06:17)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Deps upgrade.
>
>
> Diffs
> -----
>
> /trunk/pom.xml 1174464
>
> Diff: https://reviews.apache.org/r/2035/diff
>
>
> Testing
> -------
>
> EndToEnd tests (which use htmlunit) working correctly.
> Existing parser tests pass.
> Smoke test of gadgets working.
>
>
> Thanks,
>
> Paul
>
>
Re: Review Request: Upgrade htmlunit to 2.9 and required dependency
on nekohtml to 1.9.15
Posted by Vjekoslav Nesek <vn...@nmote.com>.
unsubscribe
Re: Review Request: Upgrade htmlunit to 2.9 and required dependency on
nekohtml to 1.9.15
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2035/#review2039
-----------------------------------------------------------
LGTM, though I'm not familiar yet with those deps.
Did you ever get to update the closure compiler dep, or did you leave as-is because of the error we had consuming it the last time?
- Dan
On 2011-09-23 09:06:17, Paul Lindner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2035/
> -----------------------------------------------------------
>
> (Updated 2011-09-23 09:06:17)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Deps upgrade.
>
>
> Diffs
> -----
>
> /trunk/pom.xml 1174464
>
> Diff: https://reviews.apache.org/r/2035/diff
>
>
> Testing
> -------
>
> EndToEnd tests (which use htmlunit) working correctly.
> Existing parser tests pass.
> Smoke test of gadgets working.
>
>
> Thanks,
>
> Paul
>
>
Re: Review Request: Upgrade htmlunit to 2.9 and required dependency on
nekohtml to 1.9.15
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2035/#review2041
-----------------------------------------------------------
Ship it!
+1
Paul, could you also update the UPGRADING file about the dependencies change? Will help the Shindig consumers keep track of libs need to be updated when moving to 3.0.0.
- Henry
On 2011-09-23 09:06:17, Paul Lindner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2035/
> -----------------------------------------------------------
>
> (Updated 2011-09-23 09:06:17)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Deps upgrade.
>
>
> Diffs
> -----
>
> /trunk/pom.xml 1174464
>
> Diff: https://reviews.apache.org/r/2035/diff
>
>
> Testing
> -------
>
> EndToEnd tests (which use htmlunit) working correctly.
> Existing parser tests pass.
> Smoke test of gadgets working.
>
>
> Thanks,
>
> Paul
>
>