[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4221: REST client for creating batch with uploading resource file

["bowenliang123 (via GitHub)" <gi...@apache.org>]

bowenliang123 commented on code in PR #4221:
URL: https://github.com/apache/kyuubi/pull/4221#discussion_r1093983809


##########
kyuubi-rest-client/src/main/java/org/apache/kyuubi/client/IRestClient.java:
##########
@@ -27,6 +28,8 @@ public interface IRestClient extends AutoCloseable {
 
   <T> T post(String path, String body, Class<T> type, String authHeader);
 
+  <T> T post(String path, HttpEntity requestEntity, Class<T> type, String authHeader);

Review Comment:
   But a map of key-to-file is not enough to represent the whole request entity.
   In this client request,
   - entity body (in media type of `multipart-formdata`)
   	- subpart1 (key, string value, media type of `application-json`)
   	- subpart2 (key, File, media type of file itself)
   	- subpart3 (key, value, other media type) and etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org