You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by sy...@apache.org on 2005/06/10 18:32:53 UTC
svn commit: r189983 - in /cocoon:
blocks/forms/trunk/java/org/apache/cocoon/forms/formmodel/Field.java
blocks/forms/trunk/java/org/apache/cocoon/forms/formmodel/Form.java
trunk/status.xml
Author: sylvain
Date: Fri Jun 10 09:32:52 2005
New Revision: 189983
URL: http://svn.apache.org/viewcvs?rev=189983&view=rev
Log:
Fix bug#35311 - ensure FormHandler is always called when a field's value changes. Thanks to Jeffrey Kirby
Modified:
cocoon/blocks/forms/trunk/java/org/apache/cocoon/forms/formmodel/Field.java
cocoon/blocks/forms/trunk/java/org/apache/cocoon/forms/formmodel/Form.java
cocoon/trunk/status.xml
Modified: cocoon/blocks/forms/trunk/java/org/apache/cocoon/forms/formmodel/Field.java
URL: http://svn.apache.org/viewcvs/cocoon/blocks/forms/trunk/java/org/apache/cocoon/forms/formmodel/Field.java?rev=189983&r1=189982&r2=189983&view=diff
==============================================================================
--- cocoon/blocks/forms/trunk/java/org/apache/cocoon/forms/formmodel/Field.java (original)
+++ cocoon/blocks/forms/trunk/java/org/apache/cocoon/forms/formmodel/Field.java Fri Jun 10 09:32:52 2005
@@ -507,7 +507,9 @@
}
private boolean hasValueChangedListeners() {
- return this.listener != null || this.fieldDefinition.hasValueChangedListeners();
+ return this.listener != null ||
+ this.fieldDefinition.hasValueChangedListeners() ||
+ this.getForm().hasFormHandler();
}
private void fireValueChangedEvent(ValueChangedEvent event) {
Modified: cocoon/blocks/forms/trunk/java/org/apache/cocoon/forms/formmodel/Form.java
URL: http://svn.apache.org/viewcvs/cocoon/blocks/forms/trunk/java/org/apache/cocoon/forms/formmodel/Form.java?rev=189983&r1=189982&r2=189983&view=diff
==============================================================================
--- cocoon/blocks/forms/trunk/java/org/apache/cocoon/forms/formmodel/Form.java (original)
+++ cocoon/blocks/forms/trunk/java/org/apache/cocoon/forms/formmodel/Form.java Fri Jun 10 09:32:52 2005
@@ -174,6 +174,10 @@
this.submitWidget = widget;
}
+ public boolean hasFormHandler() {
+ return (this.formHandler != null);
+ }
+
public void setFormHandler(FormHandler formHandler) {
this.formHandler = formHandler;
}
Modified: cocoon/trunk/status.xml
URL: http://svn.apache.org/viewcvs/cocoon/trunk/status.xml?rev=189983&r1=189982&r2=189983&view=diff
==============================================================================
--- cocoon/trunk/status.xml (original)
+++ cocoon/trunk/status.xml Fri Jun 10 09:32:52 2005
@@ -464,6 +464,9 @@
</action>
</release>
<release version="2.1.8" date="TBD">
+ <action dev="SW" type="fix" fixes-bug="35311" due-to="Jeffrey Kirby" due-to-email="jeff.kirby@wicourts.gov">
+ CForms block: Ensure FormHandler is always called when a field's value change.
+ </action>
<action dev="RP" type="update">
CForms block: The default HTML stylesheets have been moved into the jar packages. If they should
be extended in custom stylesheets, import or include them using the resource protocol: