You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by GitBox <gi...@apache.org> on 2020/05/04 12:54:39 UTC

[GitHub] [syncope] mmoayyed opened a new pull request #182: NOJIRA - Switch Travis CI to AMD64 Bionic Distro

mmoayyed opened a new pull request #182:
URL: https://github.com/apache/syncope/pull/182


   The Travis CI trusty image is deprecated. This change switches the distro to Bionic which builds against Ubuntu 18.
   
   PS. I also experimented with arm-based builds which are super fast to startup (less than 10 seconds) but they are not as packed as others (No maven, Java installed, etc) and the cache seems somewhat suspicious with those. Bionic should do fine for now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [syncope] ilgrosso commented on pull request #182: NOJIRA - Switch Travis CI to AMD64 Bionic Distro

Posted by GitBox <gi...@apache.org>.
ilgrosso commented on pull request #182:
URL: https://github.com/apache/syncope/pull/182#issuecomment-624039868


   @mmoayyed I'd say it works, please go ahead, squash and merge, thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [syncope] mmoayyed commented on a change in pull request #182: NOJIRA - Switch Travis CI to AMD64 Bionic Distro

Posted by GitBox <gi...@apache.org>.
mmoayyed commented on a change in pull request #182:
URL: https://github.com/apache/syncope/pull/182#discussion_r419509630



##########
File path: pom.xml
##########
@@ -2530,6 +2530,7 @@ under the License.
             <exclude>**/*.json</exclude>
             <exclude>**/banner.txt</exclude>
             <exclude>**/target/**</exclude>
+            <exclude>**/install-jdk.sh</exclude>

Review comment:
       Ah, that's much better. I'll see if I can fetch it into the temp directory.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [syncope] ilgrosso commented on pull request #182: NOJIRA - Switch Travis CI to AMD64 Bionic Distro

Posted by GitBox <gi...@apache.org>.
ilgrosso commented on pull request #182:
URL: https://github.com/apache/syncope/pull/182#issuecomment-623469331


   @mmoayyed it seems that installing other JDKs is failing, I tried to restart the related steps several times, no luck. Any idea?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [syncope] ilgrosso commented on a change in pull request #182: NOJIRA - Switch Travis CI to AMD64 Bionic Distro

Posted by GitBox <gi...@apache.org>.
ilgrosso commented on a change in pull request #182:
URL: https://github.com/apache/syncope/pull/182#discussion_r419503248



##########
File path: pom.xml
##########
@@ -2530,6 +2530,7 @@ under the License.
             <exclude>**/*.json</exclude>
             <exclude>**/banner.txt</exclude>
             <exclude>**/target/**</exclude>
+            <exclude>**/install-jdk.sh</exclude>

Review comment:
       I think we should avoid this.
   Isn't enough to fetch the `install-jdk` script into a different location, not placed in the checkout directory, to avoid RAT failing?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [syncope] ilgrosso commented on a change in pull request #182: NOJIRA - Switch Travis CI to AMD64 Bionic Distro

Posted by GitBox <gi...@apache.org>.
ilgrosso commented on a change in pull request #182:
URL: https://github.com/apache/syncope/pull/182#discussion_r419514983



##########
File path: pom.xml
##########
@@ -2530,6 +2530,7 @@ under the License.
             <exclude>**/*.json</exclude>
             <exclude>**/banner.txt</exclude>
             <exclude>**/target/**</exclude>
+            <exclude>**/install-jdk.sh</exclude>

Review comment:
       maybe `~/bin` as it used to be?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org