[GitHub] [arrow] pitrou commented on a change in pull request #12317: ARROW-15520: [C++] Qualify `arrow_vendored::date::format()` for C++20 compatibility

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #12317:
URL: https://github.com/apache/arrow/pull/12317#discussion_r797598878



##########
File path: cpp/src/arrow/array/diff.cc
##########
@@ -639,42 +639,42 @@ class MakeFormatterImpl {
       auto fmt = fmt_str.c_str();
       auto unit = checked_cast<const T&>(*array.type()).unit();
       auto value = checked_cast<const NumericArray<T>&>(array).Value(index);
-      using arrow_vendored::date::format;
+      namespace avd = arrow_vendored::date;

Review comment:
       ```suggestion
         // Using unqualified `format` directly would produce ambiguous
         // lookup because of `std::format` (ARROW-15520).
         namespace avd = arrow_vendored::date;
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org