You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/03 12:13:31 UTC
[GitHub] [skywalking-docker] JaredTan95 opened a new pull request #22: update ui docker enntry point script.
JaredTan95 opened a new pull request #22:
URL: https://github.com/apache/skywalking-docker/pull/22
fix https://github.com/apache/skywalking/issues/7401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] hanahmily commented on pull request #22: update ui docker enntry point script.
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #22:
URL: https://github.com/apache/skywalking-docker/pull/22#issuecomment-891863549
I found that docker-compose.yml doesn't pick up the skywalking version from the bash script, which causes we can't verify the images just built. Could you parameterize them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] JaredTan95 commented on pull request #22: update ui docker enntry point script.
Posted by GitBox <gi...@apache.org>.
JaredTan95 commented on pull request #22:
URL: https://github.com/apache/skywalking-docker/pull/22#issuecomment-891878289
> I found that docker-compose.yml doesn't pick up the skywalking version from the bash script, which causes we can't verify the images just built. Could you parameterize them?
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] JaredTan95 commented on a change in pull request #22: update ui docker enntry point script.
Posted by GitBox <gi...@apache.org>.
JaredTan95 commented on a change in pull request #22:
URL: https://github.com/apache/skywalking-docker/pull/22#discussion_r681777787
##########
File path: ui/docker-entrypoint.sh
##########
@@ -20,7 +20,12 @@ set -e
export LOGGING_CONFIG="webapp/logback.xml"
-[[ ! -z "$SW_OAP_ADDRESS" ]] && export COLLECTOR_RIBBON_LISTOFSERVERS=${SW_OAP_ADDRESS} && echo "COLLECTOR_RIBBON_LISTOFSERVERS=$COLLECTOR_RIBBON_LISTOFSERVERS"
-[[ ! -z "$SW_TIMEOUT" ]] && export COLLECTOR_RIBBON_READTIMEOUT=${SW_TIMEOUT} && echo "COLLECTOR_RIBBON_READTIMEOUT=$COLLECTOR_RIBBON_READTIMEOUT"
+if [[ ! -z "$SW_OAP_ADDRESS" ]]; then
+ address_arr=(${SW_OAP_ADDRESS//,/ })
+ for i in "${!address_arr[@]}"
+ do
+ JAVA_OPTS="${JAVA_OPTS} -Dspring.cloud.discovery.client.simple.instances.oap-service[$i].uri=${address_arr[$i]}"
+ done
+fi
-exec java -jar webapp/skywalking-webapp.jar "$@"
Review comment:
Okay, then we should remove this in skywalking main repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] wu-sheng merged pull request #22: update ui docker enntry point script.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #22:
URL: https://github.com/apache/skywalking-docker/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] wu-sheng commented on pull request #22: update ui docker enntry point script.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #22:
URL: https://github.com/apache/skywalking-docker/pull/22#issuecomment-892328747
@JaredTan95 Do you have access to the docker hub repo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] hanahmily commented on a change in pull request #22: update ui docker enntry point script.
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #22:
URL: https://github.com/apache/skywalking-docker/pull/22#discussion_r681779991
##########
File path: ui/docker-entrypoint.sh
##########
@@ -20,7 +20,12 @@ set -e
export LOGGING_CONFIG="webapp/logback.xml"
-[[ ! -z "$SW_OAP_ADDRESS" ]] && export COLLECTOR_RIBBON_LISTOFSERVERS=${SW_OAP_ADDRESS} && echo "COLLECTOR_RIBBON_LISTOFSERVERS=$COLLECTOR_RIBBON_LISTOFSERVERS"
-[[ ! -z "$SW_TIMEOUT" ]] && export COLLECTOR_RIBBON_READTIMEOUT=${SW_TIMEOUT} && echo "COLLECTOR_RIBBON_READTIMEOUT=$COLLECTOR_RIBBON_READTIMEOUT"
+if [[ ! -z "$SW_OAP_ADDRESS" ]]; then
+ address_arr=(${SW_OAP_ADDRESS//,/ })
+ for i in "${!address_arr[@]}"
+ do
+ JAVA_OPTS="${JAVA_OPTS} -Dspring.cloud.discovery.client.simple.instances.oap-service[$i].uri=${address_arr[$i]}"
+ done
+fi
-exec java -jar webapp/skywalking-webapp.jar "$@"
Review comment:
The main repo UI image is base on using jdk8, pls upgrade it to jdk11 if you want to remove them 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] JaredTan95 commented on a change in pull request #22: update ui docker enntry point script.
Posted by GitBox <gi...@apache.org>.
JaredTan95 commented on a change in pull request #22:
URL: https://github.com/apache/skywalking-docker/pull/22#discussion_r681780780
##########
File path: ui/docker-entrypoint.sh
##########
@@ -20,7 +20,12 @@ set -e
export LOGGING_CONFIG="webapp/logback.xml"
-[[ ! -z "$SW_OAP_ADDRESS" ]] && export COLLECTOR_RIBBON_LISTOFSERVERS=${SW_OAP_ADDRESS} && echo "COLLECTOR_RIBBON_LISTOFSERVERS=$COLLECTOR_RIBBON_LISTOFSERVERS"
-[[ ! -z "$SW_TIMEOUT" ]] && export COLLECTOR_RIBBON_READTIMEOUT=${SW_TIMEOUT} && echo "COLLECTOR_RIBBON_READTIMEOUT=$COLLECTOR_RIBBON_READTIMEOUT"
+if [[ ! -z "$SW_OAP_ADDRESS" ]]; then
+ address_arr=(${SW_OAP_ADDRESS//,/ })
+ for i in "${!address_arr[@]}"
+ do
+ JAVA_OPTS="${JAVA_OPTS} -Dspring.cloud.discovery.client.simple.instances.oap-service[$i].uri=${address_arr[$i]}"
+ done
+fi
-exec java -jar webapp/skywalking-webapp.jar "$@"
Review comment:
> The main repo UI image is base on using jdk8, pls upgrade it to jdk11 if you want to remove them 😄
I will deal with it next soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] JaredTan95 commented on pull request #22: update ui docker enntry point script.
Posted by GitBox <gi...@apache.org>.
JaredTan95 commented on pull request #22:
URL: https://github.com/apache/skywalking-docker/pull/22#issuecomment-892449085
> @JaredTan95 Do you have access to the docker hub repo?
okay, I will deal with it after applied for permission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] JaredTan95 commented on a change in pull request #22: update ui docker enntry point script.
Posted by GitBox <gi...@apache.org>.
JaredTan95 commented on a change in pull request #22:
URL: https://github.com/apache/skywalking-docker/pull/22#discussion_r681777787
##########
File path: ui/docker-entrypoint.sh
##########
@@ -20,7 +20,12 @@ set -e
export LOGGING_CONFIG="webapp/logback.xml"
-[[ ! -z "$SW_OAP_ADDRESS" ]] && export COLLECTOR_RIBBON_LISTOFSERVERS=${SW_OAP_ADDRESS} && echo "COLLECTOR_RIBBON_LISTOFSERVERS=$COLLECTOR_RIBBON_LISTOFSERVERS"
-[[ ! -z "$SW_TIMEOUT" ]] && export COLLECTOR_RIBBON_READTIMEOUT=${SW_TIMEOUT} && echo "COLLECTOR_RIBBON_READTIMEOUT=$COLLECTOR_RIBBON_READTIMEOUT"
+if [[ ! -z "$SW_OAP_ADDRESS" ]]; then
+ address_arr=(${SW_OAP_ADDRESS//,/ })
+ for i in "${!address_arr[@]}"
+ do
+ JAVA_OPTS="${JAVA_OPTS} -Dspring.cloud.discovery.client.simple.instances.oap-service[$i].uri=${address_arr[$i]}"
+ done
+fi
-exec java -jar webapp/skywalking-webapp.jar "$@"
Review comment:
Okay, This dockerfile used jdk11, skywalking main repo used jdk8, I did not noticed that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] hanahmily commented on a change in pull request #22: update ui docker enntry point script.
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #22:
URL: https://github.com/apache/skywalking-docker/pull/22#discussion_r681776376
##########
File path: ui/docker-entrypoint.sh
##########
@@ -20,7 +20,12 @@ set -e
export LOGGING_CONFIG="webapp/logback.xml"
-[[ ! -z "$SW_OAP_ADDRESS" ]] && export COLLECTOR_RIBBON_LISTOFSERVERS=${SW_OAP_ADDRESS} && echo "COLLECTOR_RIBBON_LISTOFSERVERS=$COLLECTOR_RIBBON_LISTOFSERVERS"
-[[ ! -z "$SW_TIMEOUT" ]] && export COLLECTOR_RIBBON_READTIMEOUT=${SW_TIMEOUT} && echo "COLLECTOR_RIBBON_READTIMEOUT=$COLLECTOR_RIBBON_READTIMEOUT"
+if [[ ! -z "$SW_OAP_ADDRESS" ]]; then
+ address_arr=(${SW_OAP_ADDRESS//,/ })
+ for i in "${!address_arr[@]}"
+ do
+ JAVA_OPTS="${JAVA_OPTS} -Dspring.cloud.discovery.client.simple.instances.oap-service[$i].uri=${address_arr[$i]}"
+ done
+fi
-exec java -jar webapp/skywalking-webapp.jar "$@"
Review comment:
`-XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap` are invalid in jdk11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org