[jira] Commented: (HADOOP-6186) Enhance checkstyle results by Hudson Hadoop QA to provide a diff

["Nigel Daley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742997#action_12742997 ] 

Nigel Daley commented on HADOOP-6186:
-------------------------------------

That would be great.  Unfortunately checkstyle doesn't come with any diffing tools (like findbugs does).

Another approach would be to get the warnings down to 0 through both tuning the rules and doing a mass cleanup of the source tree using an IDE.

> Enhance checkstyle results by Hudson Hadoop QA to provide a diff
> ----------------------------------------------------------------
>
>                 Key: HADOOP-6186
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6186
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>            Reporter: Vinod K V
>
> Currently, when a patch is submitted to Hudson, it provides the checkstyle results indicating problems that happened throughout the project history. For e.g., http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/463/artifact/trunk/build/test/checkstyle-errors.html.
> It is not useful at all in this format. It would be of better use to provide the style problems resulting ONLY OUT OF THE CURRENT PATCH.
> Another point: Should we also consider a +1, -1 by Hudson w.r.t code style ala findBugs warnings, test results etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.