You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/01/08 22:34:03 UTC

[GitHub] [couchdb-helm] iamwillbar opened a new pull request #64: Fix Ingress for Kubernetes 1.22+

iamwillbar opened a new pull request #64:
URL: https://github.com/apache/couchdb-helm/pull/64

<!--
Thank you for contributing to couchdb-helm. Before you submit this PR we'd like to
make sure you are aware of the chart technical requirements and best practices:

* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements
* https://github.com/helm/helm/tree/master/docs/chart_best_practices

For a quick overview across what we will look at reviewing your PR, please read
our review guidelines:

* https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md

Following our best practices right from the start will accelerate the review process and
help get your PR merged quicker.

When updates to your PR are requested, please add new commits and do not squash the
history. This will make it easier to identify new changes. The PR will be squashed
anyways when it is merged. Thanks.

Please make sure you test your changes before you push them.
-->

#### What this PR does / why we need it:
The current chart fails to install on Kubernetes v1.22 because Ingress is no longer in the v1beta API.

#### Which issue this PR fixes
*(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*

#### Special notes for your reviewer:
I also added a link to this repository in the "sources". There was only a link to the docker repository and I was confused when I couldn't find the helm chart in that repository.

I didn't create the .tgz and update the index because I wasn't sure if this was done by the contributor or maintainer, if you'd like me to do this I'm happy to.

#### Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.
- [x] Chart Version bumped
- [x] e2e tests pass
- [ ] Chart tgz added to /docs and index updated

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-helm] gpothier commented on pull request #64: Fix Ingress for Kubernetes 1.22+

Posted by GitBox <gi...@apache.org>.

gpothier commented on pull request #64:
URL: https://github.com/apache/couchdb-helm/pull/64#issuecomment-1020104021


   This PR is very useful, in particular the "pathType: Prefix" change, as it is needed for load balancers to work properly in AWS.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-helm] kocolosk commented on pull request #64: Fix Ingress for Kubernetes 1.22+

Posted by GitBox <gi...@apache.org>.

kocolosk commented on pull request #64:
URL: https://github.com/apache/couchdb-helm/pull/64#issuecomment-1020282230


   Thanks for the reminder, I went ahead and bumped the versioning in #65 so this fix is now merged as of v3.5.2. Thanks again @iamwillbar for the contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-helm] kocolosk closed pull request #64: Fix Ingress for Kubernetes 1.22+

Posted by GitBox <gi...@apache.org>.

kocolosk closed pull request #64:
URL: https://github.com/apache/couchdb-helm/pull/64


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-helm] kocolosk commented on pull request #64: Fix Ingress for Kubernetes 1.22+

Posted by GitBox <gi...@apache.org>.

kocolosk commented on pull request #64:
URL: https://github.com/apache/couchdb-helm/pull/64#issuecomment-1012146819


   Thanks! This is a nice contribution @iamwillbar. Appreciate you adding the URL, updating the test suite, etc.
   
   It looks like you did go ahead and update the index. We should figure out a better process for that, as it tends to result in merge conflicts when we have concurrent contributions. Can you either re-publish this as 3.5.2 or remove the chart versioning / publishing bits from this PR so it'll merge cleanly?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org