You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "IKholopov (via GitHub)" <gi...@apache.org> on 2023/02/21 23:10:54 UTC
[GitHub] [airflow] IKholopov opened a new pull request, #29680: Google Cloud Providers - Introduce GoogleCloudBaseOperator
IKholopov opened a new pull request, #29680:
URL: https://github.com/apache/airflow/pull/29680
As part of addressing #28751 the GoogleCloudBaseOperator is introduced to have common fix for all Google Cloud operators.
Refactored to a separate PR per @potiuk request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29680: Google Cloud Providers - Introduce GoogleCloudBaseOperator
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29680:
URL: https://github.com/apache/airflow/pull/29680#issuecomment-1439879330
> LGTM if the tests pass we can merge. That said if you could please add some context at the top. I realize that there is more info in the ticket but it would be nice to have a few sentences here as well to give larger context so future users who are running git blame don't have to dive through a hyperlink rabbithole to find out why this change was made.
yep. Fully agree. Context is important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29680: Google Cloud Providers - Introduce GoogleCloudBaseOperator
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29680:
URL: https://github.com/apache/airflow/pull/29680#issuecomment-1439880398
(best is to squash the commits and rebase on top of the main and add good description).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #29680: Google Cloud Providers - Introduce GoogleCloudBaseOperator
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #29680:
URL: https://github.com/apache/airflow/pull/29680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #29680: Google Cloud Providers - Introduce GoogleCloudBaseOperator
Posted by "dimberman (via GitHub)" <gi...@apache.org>.
dimberman commented on PR #29680:
URL: https://github.com/apache/airflow/pull/29680#issuecomment-1439325320
LGTM if the tests pass we can merge. That said if you could please add some context at the top. I realize that there is more info in the ticket but it would be nice to have a few sentences here as well to give larger context so future users who are running git blame don't have to dive through a hyperlink rabbithole to find out why this change was made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] IKholopov commented on pull request #29680: Google Cloud Providers - Introduce GoogleCloudBaseOperator
Posted by "IKholopov (via GitHub)" <gi...@apache.org>.
IKholopov commented on PR #29680:
URL: https://github.com/apache/airflow/pull/29680#issuecomment-1440995701
> (best is to squash the commits and rebase on top of the main and add good description).
I've added a detailed description to the commit, let me know if you meant any other place to put description in (I am not too familiar with how GitHub merges PR/commit chain messages)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org