You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "guixiaowen (via GitHub)" <gi...@apache.org> on 2024/04/19 08:54:32 UTC
[PR] [SPARK-47914][SQL] Do not display the splits parameter in Rang [spark]
guixiaowen opened a new pull request, #46136:
URL: https://github.com/apache/spark/pull/46136
### What changes were proposed in this pull request?
[SQL]
explain extended select * from range(0, 4);
Before this pr, the split is also displayed in the logical execution phase as None, if it is not be set.
`
plan
== Parsed Logical Plan ==
'Project [*]
+- 'UnresolvedTableValuedFunction [range], [0, 4]
== Analyzed Logical Plan ==
id: bigint
Project [id#11L](https://issues.apache.org/jira/projects/SPARK/issues/SPARK-47914?filter=allissues#11L)
+- Range (0, 4, step=1, splits=None)
== Optimized Logical Plan ==
Range (0, 4, step=1, splits=None)
== Physical Plan ==
*(1) Range (0, 4, step=1, splits=1)`
After this pr, the split will not be displayed in the logical execution phase , if it is not set. At the same time, it will be be displayed when it is be set.
`
plan
== Parsed Logical Plan ==
'Project [*]
+- 'UnresolvedTableValuedFunction [range], [0, 4]
== Analyzed Logical Plan ==
id: bigint
Project [id#11L](https://issues.apache.org/jira/projects/SPARK/issues/SPARK-47914?filter=allissues#11L)
+- Range (0, 4, step=1)
== Optimized Logical Plan ==
Range (0, 4, step=1)
== Physical Plan ==
*(1) Range (0, 4, step=1, splits=1)`
### Why are the changes needed?
If the split is not be set. it is also displayed in the logical execution phase as None, which is not very user-friendly.
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47914][SQL] Do not display the splits parameter in Range [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #46136: [SPARK-47914][SQL] Do not display the splits parameter in Range
URL: https://github.com/apache/spark/pull/46136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47914][SQL] Do not display the splits parameter in Range [spark]
Posted by "guixiaowen (via GitHub)" <gi...@apache.org>.
guixiaowen commented on PR #46136:
URL: https://github.com/apache/spark/pull/46136#issuecomment-2079061228
> > Mind checking the test failures?
>
> ok. I will check it.
@HyukjinKwon h hi Do you have any questions about this place？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47914][SQL] Do not display the splits parameter in Range [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #46136:
URL: https://github.com/apache/spark/pull/46136#issuecomment-2099698487
Merged to master
Thank you @guixiaowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47914][SQL] Do not display the splits parameter in Rang [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #46136:
URL: https://github.com/apache/spark/pull/46136#issuecomment-2067849302
Mind checking the test failures?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47914][SQL] Do not display the splits parameter in Rang [spark]
Posted by "guixiaowen (via GitHub)" <gi...@apache.org>.
guixiaowen commented on PR #46136:
URL: https://github.com/apache/spark/pull/46136#issuecomment-2068383150
> Mind checking the test failures?
ok. I will check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47914][SQL] Do not display the splits parameter in Rang [spark]
Posted by "guixiaowen (via GitHub)" <gi...@apache.org>.
guixiaowen commented on PR #46136:
URL: https://github.com/apache/spark/pull/46136#issuecomment-2073986240
> Mind checking the test failures?
@HyukjinKwon I made the changes. Do you have any other questions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org