[GitHub] [beam] angoenka commented on a change in pull request #15140: Default to Runner v2 for Python Streaming jobs.

[GitBox <gi...@apache.org>]

angoenka commented on a change in pull request #15140:
URL: https://github.com/apache/beam/pull/15140#discussion_r673505350



##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -588,9 +588,15 @@ def run_pipeline(self, pipeline, options):
     return result
 
   def _maybe_add_unified_worker_missing_options(self, options):
+    debug_options = options.view_as(DebugOptions)
+    # Streaming is always portable, default to runner v2.
+    if options.view_as(StandardOptions).streaming:
+      if not debug_options.lookup_experiment('disable_runner_v2'):
+        debug_options.add_experiment('beam_fn_api')
+        debug_options.add_experiment('use_runner_v2')

Review comment:
       This will move the runner_v2 selection from Service to SDK and will limit out capability of auto optin/not option to UW if we ever have to.
   
   Is there a specific reason why we want to move runner selection to SDK.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org