[GitHub] [hive] pvargacl commented on a change in pull request #1730: HIVE-24475: Generalize fixacidkeyindex utility

[GitBox <gi...@apache.org>]

pvargacl commented on a change in pull request #1730:
URL: https://github.com/apache/hive/pull/1730#discussion_r535204663



##########
File path: ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestFixAcidKeyIndex.java
##########
@@ -243,6 +233,12 @@ public void testInvalidKeyIndex() throws Exception {
     checkInvalidKeyIndex(testFilePath);
     // Try fixing, this should result in new fixed file.
     fixInvalidIndex(testFilePath);
+
+    // Multiple stripes
+    createTestAcidFile(testFilePath, 12000, new FaultyKeyIndexBuilder());
+    checkInvalidKeyIndex(testFilePath);
+    // Try fixing, this should result in new fixed file.
+    fixInvalidIndex(testFilePath);

Review comment:
       Shouldn't this check if the index was actually corrected in the new file? It just checks the output of the tool.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org