You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/14 04:13:41 UTC
[jira] [Commented] (ZOOKEEPER-2178) Native client fails compilation
on Windows.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923534#comment-15923534 ]
ASF GitHub Bot commented on ZOOKEEPER-2178:
-------------------------------------------
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/190
ZOOKEEPER-2178: fix flaky StandaloneDisabledTest
The flaky (that existing for a long time) is caused by a ghost server that although not appear in the quorum's config but still up and running and send requests to the quorum {2, 3, 4}. Fix is simply kill the server 1 after it's used. Verified that with the fix the test survive stress test (100+ runs) while w/o the fix the tests fails frequently, on internal Jenkins machine.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hanm/zookeeper ZOOKEEPER-2178
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/190.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #190
----
commit 85d4fb7fb5769a7c95b93588ab2357aa3d7f4242
Author: Michael Han <ha...@apache.org>
Date: 2017-03-14T03:48:03Z
ZOOKEEPER-2178: org.apache.zookeeper.server.quorum.StandaloneDisabledTest fails intermittently.
----
> Native client fails compilation on Windows.
> -------------------------------------------
>
> Key: ZOOKEEPER-2178
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2178
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.5.0
> Environment: Windows
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2178.001.patch
>
>
> Due to several recent changes, the native client fails to compile on Windows:
> # ZOOKEEPER-827 (read-only mode) mismatched a function return type between the declaration and definition.
> # ZOOKEEPER-1626 (monotonic clock for tolerance to time adjustments) added an include of unistd.h, which does not exist on Windows.
> # Additionally, ZOOKEEPER-1626 did not implement a code path for accessing the Windows monotonic clock.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)