You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "uwe schaefer (JIRA)" <ji...@apache.org> on 2008/10/07 10:03:44 UTC
[jira] Created: (WICKET-1861) Inevitable UnknownSizeException with
HTTPS
Inevitable UnknownSizeException with HTTPS
------------------------------------------
Key: WICKET-1861
URL: https://issues.apache.org/jira/browse/WICKET-1861
Project: Wicket
Issue Type: Bug
Affects Versions: 1.4-M3
Environment: Caucho Resin 3.2 behind apache2
Reporter: uwe schaefer
When using a FileUploadField in a HTTPS environment, the request always returns a request-size of -1.
In that case, FileUploadBase rejects to process the reuqest, no matter what (or if9 a maxSize is defined:
org.apache.wicket.util.upload.FileUploadBase:236 (wicket 1.4m3)
{code}
if (requestSize == -1) {
throw new UnknownSizeException( "the request was rejected because its size is unknown");
}
{code}
this makes it impossible to use fileUploads with HTTPS in this environment at all.
I think, this _sanity check_ should not be done if either HTTPS is used, or the developer does not care (expressed by not setting any maxSize).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1861) Inevitable UnknownSizeException
with HTTPS
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637435#action_12637435 ]
Martijn Dashorst commented on WICKET-1861:
------------------------------------------
sounds like a resin/apache problem. Our app uses https exclusively through apache/tomcat and have no problems with file uploads.
> Inevitable UnknownSizeException with HTTPS
> ------------------------------------------
>
> Key: WICKET-1861
> URL: https://issues.apache.org/jira/browse/WICKET-1861
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M3
> Environment: Caucho Resin 3.2 behind apache2
> Reporter: uwe schaefer
>
> When using a FileUploadField in a HTTPS environment, the request always returns a request-size of -1.
> In that case, FileUploadBase rejects to process the reuqest, no matter what (or if) a maxSize is defined:
> org.apache.wicket.util.upload.FileUploadBase:236 (wicket 1.4m3)
> if (requestSize == -1) {
> throw new UnknownSizeException( "the request was rejected because its size is unknown");
> }
> this makes it impossible to use fileUploads with HTTPS in this environment at all.
> I think, this _sanity check_ should not be done if either HTTPS is used, or the developer does not care (expressed by not setting any maxSize).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1861) Inevitable UnknownSizeException
with HTTPS
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637625#action_12637625 ]
Martijn Dashorst commented on WICKET-1861:
------------------------------------------
yes, more than we would like our users to do. It bogs our database/filesystem with all those word documents they upload.
> Inevitable UnknownSizeException with HTTPS
> ------------------------------------------
>
> Key: WICKET-1861
> URL: https://issues.apache.org/jira/browse/WICKET-1861
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M3
> Environment: Caucho Resin 3.2 behind apache2
> Reporter: uwe schaefer
>
> When using a FileUploadField in a HTTPS environment, the request always returns a request-size of -1.
> In that case, FileUploadBase rejects to process the reuqest, no matter what (or if) a maxSize is defined:
> org.apache.wicket.util.upload.FileUploadBase:236 (wicket 1.4m3)
> if (requestSize == -1) {
> throw new UnknownSizeException( "the request was rejected because its size is unknown");
> }
> this makes it impossible to use fileUploads with HTTPS in this environment at all.
> I think, this _sanity check_ should not be done if either HTTPS is used, or the developer does not care (expressed by not setting any maxSize).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1861) Inevitable UnknownSizeException
with HTTPS
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671894#action_12671894 ]
Matej Knopp commented on WICKET-1861:
-------------------------------------
Can't we omit the check if no maxSize is set?
> Inevitable UnknownSizeException with HTTPS
> ------------------------------------------
>
> Key: WICKET-1861
> URL: https://issues.apache.org/jira/browse/WICKET-1861
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M3
> Environment: Caucho Resin 3.2 behind apache2
> Reporter: uwe schaefer
> Assignee: Juergen Donnerstag
> Fix For: 1.4-RC2
>
>
> When using a FileUploadField in a HTTPS environment, the request always returns a request-size of -1.
> In that case, FileUploadBase rejects to process the reuqest, no matter what (or if) a maxSize is defined:
> org.apache.wicket.util.upload.FileUploadBase:236 (wicket 1.4m3)
> if (requestSize == -1) {
> throw new UnknownSizeException( "the request was rejected because its size is unknown");
> }
> this makes it impossible to use fileUploads with HTTPS in this environment at all.
> I think, this _sanity check_ should not be done if either HTTPS is used, or the developer does not care (expressed by not setting any maxSize).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1861) Inevitable UnknownSizeException with
HTTPS
Posted by "uwe schaefer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
uwe schaefer updated WICKET-1861:
---------------------------------
Component/s: wicket
Description:
When using a FileUploadField in a HTTPS environment, the request always returns a request-size of -1.
In that case, FileUploadBase rejects to process the reuqest, no matter what (or if) a maxSize is defined:
org.apache.wicket.util.upload.FileUploadBase:236 (wicket 1.4m3)
if (requestSize == -1) {
throw new UnknownSizeException( "the request was rejected because its size is unknown");
}
this makes it impossible to use fileUploads with HTTPS in this environment at all.
I think, this _sanity check_ should not be done if either HTTPS is used, or the developer does not care (expressed by not setting any maxSize).
was:
When using a FileUploadField in a HTTPS environment, the request always returns a request-size of -1.
In that case, FileUploadBase rejects to process the reuqest, no matter what (or if9 a maxSize is defined:
org.apache.wicket.util.upload.FileUploadBase:236 (wicket 1.4m3)
{code}
if (requestSize == -1) {
throw new UnknownSizeException( "the request was rejected because its size is unknown");
}
{code}
this makes it impossible to use fileUploads with HTTPS in this environment at all.
I think, this _sanity check_ should not be done if either HTTPS is used, or the developer does not care (expressed by not setting any maxSize).
> Inevitable UnknownSizeException with HTTPS
> ------------------------------------------
>
> Key: WICKET-1861
> URL: https://issues.apache.org/jira/browse/WICKET-1861
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M3
> Environment: Caucho Resin 3.2 behind apache2
> Reporter: uwe schaefer
>
> When using a FileUploadField in a HTTPS environment, the request always returns a request-size of -1.
> In that case, FileUploadBase rejects to process the reuqest, no matter what (or if) a maxSize is defined:
> org.apache.wicket.util.upload.FileUploadBase:236 (wicket 1.4m3)
> if (requestSize == -1) {
> throw new UnknownSizeException( "the request was rejected because its size is unknown");
> }
> this makes it impossible to use fileUploads with HTTPS in this environment at all.
> I think, this _sanity check_ should not be done if either HTTPS is used, or the developer does not care (expressed by not setting any maxSize).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1861) Inevitable UnknownSizeException with
HTTPS
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1861.
-----------------------------------
Resolution: Fixed
Fix Version/s: (was: 1.4-RC2)
1.4-RC3
the check now looks like this:
if (requestSize == -1 && getSizeMax() != Long.MAX_VALUE)
if you have it set to max then obviously you dont care how big it is - so knowing the size ahead of time doesnt really matter.
yes this is a caucho problem because they dont set the right headers or whatever, but we can also handle it if it makes sense.
> Inevitable UnknownSizeException with HTTPS
> ------------------------------------------
>
> Key: WICKET-1861
> URL: https://issues.apache.org/jira/browse/WICKET-1861
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M3
> Environment: Caucho Resin 3.2 behind apache2
> Reporter: uwe schaefer
> Assignee: Igor Vaynberg
> Fix For: 1.4-RC3
>
>
> When using a FileUploadField in a HTTPS environment, the request always returns a request-size of -1.
> In that case, FileUploadBase rejects to process the reuqest, no matter what (or if) a maxSize is defined:
> org.apache.wicket.util.upload.FileUploadBase:236 (wicket 1.4m3)
> if (requestSize == -1) {
> throw new UnknownSizeException( "the request was rejected because its size is unknown");
> }
> this makes it impossible to use fileUploads with HTTPS in this environment at all.
> I think, this _sanity check_ should not be done if either HTTPS is used, or the developer does not care (expressed by not setting any maxSize).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1861) Inevitable UnknownSizeException
with HTTPS
Posted by "uwe schaefer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637465#action_12637465 ]
uwe schaefer commented on WICKET-1861:
--------------------------------------
Thanks! Good to know. I´ll take it to caucho support then.
> Inevitable UnknownSizeException with HTTPS
> ------------------------------------------
>
> Key: WICKET-1861
> URL: https://issues.apache.org/jira/browse/WICKET-1861
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M3
> Environment: Caucho Resin 3.2 behind apache2
> Reporter: uwe schaefer
>
> When using a FileUploadField in a HTTPS environment, the request always returns a request-size of -1.
> In that case, FileUploadBase rejects to process the reuqest, no matter what (or if) a maxSize is defined:
> org.apache.wicket.util.upload.FileUploadBase:236 (wicket 1.4m3)
> if (requestSize == -1) {
> throw new UnknownSizeException( "the request was rejected because its size is unknown");
> }
> this makes it impossible to use fileUploads with HTTPS in this environment at all.
> I think, this _sanity check_ should not be done if either HTTPS is used, or the developer does not care (expressed by not setting any maxSize).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1861) Inevitable UnknownSizeException
with HTTPS
Posted by "uwe schaefer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637635#action_12637635 ]
uwe schaefer commented on WICKET-1861:
--------------------------------------
Thanks Martijn, i´ll take it to caucho then.
> Inevitable UnknownSizeException with HTTPS
> ------------------------------------------
>
> Key: WICKET-1861
> URL: https://issues.apache.org/jira/browse/WICKET-1861
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M3
> Environment: Caucho Resin 3.2 behind apache2
> Reporter: uwe schaefer
>
> When using a FileUploadField in a HTTPS environment, the request always returns a request-size of -1.
> In that case, FileUploadBase rejects to process the reuqest, no matter what (or if) a maxSize is defined:
> org.apache.wicket.util.upload.FileUploadBase:236 (wicket 1.4m3)
> if (requestSize == -1) {
> throw new UnknownSizeException( "the request was rejected because its size is unknown");
> }
> this makes it impossible to use fileUploads with HTTPS in this environment at all.
> I think, this _sanity check_ should not be done if either HTTPS is used, or the developer does not care (expressed by not setting any maxSize).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1861) Inevitable UnknownSizeException
with HTTPS
Posted by "uwe schaefer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671943#action_12671943 ]
uwe schaefer commented on WICKET-1861:
--------------------------------------
Awesome, thanks Igor!
btw: on the caucho side there is a fix for 4.x branch, so it only effects 3.2.x.
For details: http://bugs.caucho.com/view.php?id=2995
> Inevitable UnknownSizeException with HTTPS
> ------------------------------------------
>
> Key: WICKET-1861
> URL: https://issues.apache.org/jira/browse/WICKET-1861
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M3
> Environment: Caucho Resin 3.2 behind apache2
> Reporter: uwe schaefer
> Assignee: Igor Vaynberg
> Fix For: 1.4-RC3
>
>
> When using a FileUploadField in a HTTPS environment, the request always returns a request-size of -1.
> In that case, FileUploadBase rejects to process the reuqest, no matter what (or if) a maxSize is defined:
> org.apache.wicket.util.upload.FileUploadBase:236 (wicket 1.4m3)
> if (requestSize == -1) {
> throw new UnknownSizeException( "the request was rejected because its size is unknown");
> }
> this makes it impossible to use fileUploads with HTTPS in this environment at all.
> I think, this _sanity check_ should not be done if either HTTPS is used, or the developer does not care (expressed by not setting any maxSize).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1861) Inevitable UnknownSizeException with
HTTPS
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-1861.
----------------------------------------
Resolution: Invalid
Fix Version/s: 1.4-RC2
Assignee: Juergen Donnerstag
seems to be no Wicket problem according to the discussion
> Inevitable UnknownSizeException with HTTPS
> ------------------------------------------
>
> Key: WICKET-1861
> URL: https://issues.apache.org/jira/browse/WICKET-1861
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M3
> Environment: Caucho Resin 3.2 behind apache2
> Reporter: uwe schaefer
> Assignee: Juergen Donnerstag
> Fix For: 1.4-RC2
>
>
> When using a FileUploadField in a HTTPS environment, the request always returns a request-size of -1.
> In that case, FileUploadBase rejects to process the reuqest, no matter what (or if) a maxSize is defined:
> org.apache.wicket.util.upload.FileUploadBase:236 (wicket 1.4m3)
> if (requestSize == -1) {
> throw new UnknownSizeException( "the request was rejected because its size is unknown");
> }
> this makes it impossible to use fileUploads with HTTPS in this environment at all.
> I think, this _sanity check_ should not be done if either HTTPS is used, or the developer does not care (expressed by not setting any maxSize).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-1861) Inevitable UnknownSizeException with
HTTPS
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reopened WICKET-1861:
-----------------------------------
Assignee: Igor Vaynberg (was: Juergen Donnerstag)
> Inevitable UnknownSizeException with HTTPS
> ------------------------------------------
>
> Key: WICKET-1861
> URL: https://issues.apache.org/jira/browse/WICKET-1861
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M3
> Environment: Caucho Resin 3.2 behind apache2
> Reporter: uwe schaefer
> Assignee: Igor Vaynberg
> Fix For: 1.4-RC2
>
>
> When using a FileUploadField in a HTTPS environment, the request always returns a request-size of -1.
> In that case, FileUploadBase rejects to process the reuqest, no matter what (or if) a maxSize is defined:
> org.apache.wicket.util.upload.FileUploadBase:236 (wicket 1.4m3)
> if (requestSize == -1) {
> throw new UnknownSizeException( "the request was rejected because its size is unknown");
> }
> this makes it impossible to use fileUploads with HTTPS in this environment at all.
> I think, this _sanity check_ should not be done if either HTTPS is used, or the developer does not care (expressed by not setting any maxSize).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-1861) Inevitable
UnknownSizeException with HTTPS
Posted by "uwe schaefer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637465#action_12637465 ]
javadoc edited comment on WICKET-1861 at 10/7/08 6:12 AM:
---------------------------------------------------------------
Thanks! Good to know. Just to make sure: You do use _FileUploads_ via HTTPS ?
I´ll take it to caucho support then. In the meantime, however it would be nice to be able to turn it off without patching the source.
was (Author: javadoc):
Thanks! Good to know. I´ll take it to caucho support then.
> Inevitable UnknownSizeException with HTTPS
> ------------------------------------------
>
> Key: WICKET-1861
> URL: https://issues.apache.org/jira/browse/WICKET-1861
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M3
> Environment: Caucho Resin 3.2 behind apache2
> Reporter: uwe schaefer
>
> When using a FileUploadField in a HTTPS environment, the request always returns a request-size of -1.
> In that case, FileUploadBase rejects to process the reuqest, no matter what (or if) a maxSize is defined:
> org.apache.wicket.util.upload.FileUploadBase:236 (wicket 1.4m3)
> if (requestSize == -1) {
> throw new UnknownSizeException( "the request was rejected because its size is unknown");
> }
> this makes it impossible to use fileUploads with HTTPS in this environment at all.
> I think, this _sanity check_ should not be done if either HTTPS is used, or the developer does not care (expressed by not setting any maxSize).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.