You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "Gumix (via GitHub)" <gi...@apache.org> on 2025/03/26 19:00:16 UTC

[I] Dead code in `ArrowIpcSharedBufferClone()` [arrow-nanoarrow]

Gumix opened a new issue, #734:
URL: https://github.com/apache/arrow-nanoarrow/issues/734

   https://github.com/apache/arrow-nanoarrow/blob/08a64ff44fce354dfca9c011443dbe555f3a8715/src/nanoarrow/ipc/decoder.c#L201-L209
   
   I guess it should look like this:
   
   ```c
        shared_out->size_bytes = shared->size_bytes; 
        shared_out->capacity_bytes = shared->capacity_bytes; 
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Dead code in `ArrowIpcSharedBufferClone()` [arrow-nanoarrow]

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.

paleolimbot commented on issue #734:
URL: https://github.com/apache/arrow-nanoarrow/issues/734#issuecomment-2756513448

   Thanks for reporting! I agree with your fix (it's probably never cone up because nobody has ever wanted to share an empty buffer!)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Dead code in `ArrowIpcSharedBufferClone()` [arrow-nanoarrow]

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.

paleolimbot closed issue #734: Dead code in `ArrowIpcSharedBufferClone()`
URL: https://github.com/apache/arrow-nanoarrow/issues/734


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Dead code in `ArrowIpcSharedBufferClone()` [arrow-nanoarrow]

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.

paleolimbot closed issue #734: Dead code in `ArrowIpcSharedBufferClone()`
URL: https://github.com/apache/arrow-nanoarrow/issues/734


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org