[GitHub] [spark] cloud-fan commented on a change in pull request #24185: [SPARK-27252][SQL] Make current_date() independent from time zones

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #24185: [SPARK-27252][SQL] Make current_date() independent from time zones
URL: https://github.com/apache/spark/pull/24185#discussion_r268457064
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala
 ##########
 @@ -58,20 +58,19 @@ object ReplaceExpressions extends Rule[LogicalPlan] {
  */
 object ComputeCurrentTime extends Rule[LogicalPlan] {
   def apply(plan: LogicalPlan): LogicalPlan = {
-    val currentDates = mutable.Map.empty[String, Literal]
-    val timeExpr = CurrentTimestamp()
-    val timestamp = timeExpr.eval(EmptyRow).asInstanceOf[Long]
-    val currentTime = Literal.create(timestamp, timeExpr.dataType)
+    lazy val currentDate = {
 
 Review comment:
   the overhead of `lazy val` might be bigger than always computing the value. Can we add `lazy val` when we have benchmarks to prove it's necessary?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org