You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/11 13:13:08 UTC
[GitHub] [superset] cccs-Dustin opened a new issue #19119: New Feature Flag to allow users to modify a column's data type from the new dataset editor
cccs-Dustin opened a new issue #19119:
URL: https://github.com/apache/superset/issues/19119
**Is your feature request related to a problem? Please describe.**
When users are creating a new dataset, if that dataset contains a field with a long, complex data type, users will get an error because the field type is too long. To get around this issue, users must change the field type to JSON. This can currently only be done (in the UI) through the Legacy Datasource Editor. It should be possible to do this through the new dataset editor as well.
In the new dataset editor, even if a user wanted to simply change the column's data type from one data type to another, it is not currently possible. To do it, they need to go into the Legacy Datasource Editor, again, this should be possible in the new dataset editor.
**Describe the solution you'd like**
Within the front-end code, there is a prop for the `ColumnCollectionTable` component named `allowEditDataType`. It is currently always set to false, but if you manually change it to true and reload, you can modify the column's data type in the new dataset editor. So it seems like the implementation was almost complete, it was just never finished off.
My solution would include creating a new feature flag which would allow users to simply modify the config file instead of having to dig into the front-end code to enable this feature. I would also create unit tests to make sure that the UI behaves as expected when the flag is either enabled or disabled.
Current dataset editor:
Proposed dataset editor with feature flag enabled:
**Describe alternatives you've considered**
Considering the prop is already in the component, I did not consider any other alternatives as the solution is pretty straightforward.
**Additional context**
I have actually implemented the new feature flag and will create a PR for it to be added to master. When it has been created, I will link it here:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cccs-Dustin edited a comment on issue #19119: New Feature Flag to allow users to modify a column's data type from the new dataset editor
Posted by GitBox <gi...@apache.org>.
cccs-Dustin edited a comment on issue #19119:
URL: https://github.com/apache/superset/issues/19119#issuecomment-1069146511
After some investigation, it turns out that the issue we were running into can be solved one of two ways. The first of the two ways is to cast the variable in the virtual dataset SQL statement to avoid it being assigned the wrong data type.
The second way to avoid the issue mentioned in the use case was actually solved by this PR: https://github.com/apache/superset/pull/17360/files. Instead of having the column type set to be a maximum of 32 characters, it switches the type to TEXT which does not have a limit.
Since the issue can now be avoided without having to make modifications to the code, we decided to close this issue (and the corresponding PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cccs-Dustin commented on issue #19119: New Feature Flag to allow users to modify a column's data type from the new dataset editor
Posted by GitBox <gi...@apache.org>.
cccs-Dustin commented on issue #19119:
URL: https://github.com/apache/superset/issues/19119#issuecomment-1069146511
After some investigation, it turns out that the issue we were running into can be solved one of two ways. The first of the two ways is to cast the variable in the virtual dataset SQL statement to avoid it being assigned the wrong data type.
The second way to avoid the issue mentioned in the use case was actually solved by this PR: https://github.com/apache/superset/pull/17360/files. Instead of having the column type set to be a maximum of 32 characters, it switches the type to TEXT which does not have a limit.
Since the issue can now be avoided without having to make modifications to the code, we decided to close this issue (and the corresponding PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cccs-Dustin closed issue #19119: New Feature Flag to allow users to modify a column's data type from the new dataset editor
Posted by GitBox <gi...@apache.org>.
cccs-Dustin closed issue #19119:
URL: https://github.com/apache/superset/issues/19119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cccs-Dustin commented on issue #19119: New Feature Flag to allow users to modify a column's data type from the new dataset editor
Posted by GitBox <gi...@apache.org>.
cccs-Dustin commented on issue #19119:
URL: https://github.com/apache/superset/issues/19119#issuecomment-1065103485
Hi @geido! Would you be able to provide some feedback if any for this issue? Thank you :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org