You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by "akshaymankumbare (via GitHub)" <gi...@apache.org> on 2026/04/28 17:58:03 UTC
[PR] Ambari-26062 Fix python3 type encoding error on security.py [ambari]
akshaymankumbare opened a new pull request, #4126:
URL: https://github.com/apache/ambari/pull/4126
## What changes were proposed in this pull request?
I saw a similar issue with security.py
## How was this patch tested?
While enabling twoway ssl for ambari faced this issue.
Implemented the patch after which this issue was resloved and twoway ssl was working with python3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] Ambari-26062 Fix python3 type encoding error on security.py [ambari]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC closed pull request #4126: Ambari-26062 Fix python3 type encoding error on security.py
URL: https://github.com/apache/ambari/pull/4126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] Ambari-26062 Fix python3 type encoding error on security.py [ambari]
Posted by "akshaymankumbare (via GitHub)" <gi...@apache.org>.
akshaymankumbare commented on PR #4126:
URL: https://github.com/apache/ambari/pull/4126#issuecomment-4487555104
@JiaLiangC I see you mentioned "Looks good to me." but I don't see it merged. Do you want me to re-open and fix something here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] Ambari-26062 Fix python3 type encoding error on security.py [ambari]
Posted by "akshaymankumbare (via GitHub)" <gi...@apache.org>.
akshaymankumbare commented on PR #4126:
URL: https://github.com/apache/ambari/pull/4126#issuecomment-4359656450
@guluo2016 @JiaLiangC Can you please help review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] Ambari-26062 Fix python3 type encoding error on security.py [ambari]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #4126:
URL: https://github.com/apache/ambari/pull/4126#issuecomment-4384311352
Looks good to me. The Python 3 fixes are correct:
writing the downloaded cert in binary mode
encoding the JSON request body before passing it to urllib.request.Request
closing the written certificate file on success
Minor non-blocking suggestion: consider using with open(...) in a follow-up for cleaner file handling and to avoid explicit close calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [PR] Ambari-26062 Fix python3 type encoding error on security.py [ambari]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #4126:
URL: https://github.com/apache/ambari/pull/4126#issuecomment-4384312254
> ## What changes were proposed in this pull request?
> I saw a similar issue with security.py
>
> ## How was this patch tested?
> While enabling twoway ssl for ambari faced this issue. Implemented the patch after which this issue was resloved and twoway ssl was working with python3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org