You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2026/05/11 19:12:10 UTC

(superset) branch chore/gha-latest-tag-sound-condition created (now feea61581fb)

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a change to branch chore/gha-latest-tag-sound-condition
in repository https://gitbox.apache.org/repos/asf/superset.git


      at feea61581fb fix(gha): use sound condition gating for latest-tag step

This branch includes the following new commits:

     new feea61581fb fix(gha): use sound condition gating for latest-tag step

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(superset) 01/01: fix(gha): use sound condition gating for latest-tag step

Posted by ru...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch chore/gha-latest-tag-sound-condition
in repository https://gitbox.apache.org/repos/asf/superset.git

commit feea61581fb0a58b747b5aaa003ca6390867a05d
Author: Superset Dev <de...@superset.apache.org>
AuthorDate: Mon May 11 12:11:52 2026 -0700

    fix(gha): use sound condition gating for latest-tag step
    
    The `if:` on the `Run latest-tag` step used a `${{ }}` template
    interpolation inside an expression context, which is the zizmor
    "unsound-condition" pattern. The expression is template-substituted
    *before* it is parsed, so when `steps.latest-tag.outputs.SKIP_TAG` is
    empty (which happens on the "no latest tags yet" path of
    `scripts/tag_latest_release.sh`, where `SKIP_TAG` is never written to
    `$GITHUB_OUTPUT` before the script exits), the condition becomes the
    malformed expression `(! )` and GitHub Actions evaluates it as falsy —
    so the tag step is skipped on the very first release when it should
    run.
    
    Replace with a direct string comparison
    `steps.latest-tag.outputs.SKIP_TAG != 'true'`, which:
    - evaluates soundly in all cases (empty, "false", "true"),
    - matches the script's intent (skip only when SKIP_TAG is explicitly
      "true"), and
    - mirrors how other workflows in this repo gate on step outputs.
    
    Co-Authored-By: Claude Opus 4.7 <no...@anthropic.com>
---
 .github/workflows/latest-release-tag.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/latest-release-tag.yml b/.github/workflows/latest-release-tag.yml
index 97cd73df462..4a4f38320a8 100644
--- a/.github/workflows/latest-release-tag.yml
+++ b/.github/workflows/latest-release-tag.yml
@@ -29,7 +29,7 @@ jobs:
 
     - name: Run latest-tag
       uses: ./.github/actions/latest-tag
-      if: (! ${{ steps.latest-tag.outputs.SKIP_TAG }} )
+      if: steps.latest-tag.outputs.SKIP_TAG != 'true'
       with:
         description: Superset latest release
         tag-name: latest