You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/24 13:05:51 UTC
[GitHub] [superset] simcha90 opened a new pull request #17208: feat: Dynamic dashboard component
simcha90 opened a new pull request #17208:
URL: https://github.com/apache/superset/pull/17208
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR POC feat for dynamic loading of dashboard components
**Why?**
Dependent on product needs we want to take development of Superset to different directions. `Dashboard Components` can introduce specific needs of company requirements. So we wanted to do this feature more flexible in order to not affect other product visions :)
**What?**
This PR add opportunity to add new `Dashboard Components` that can be configured in separate file by every superset instance and not affects main Superset functionality
**How?**
We creating new dashboard components registry that can register new `Dashboard Components` in `/src/setup/setupDasboardComponents.ts`
When we drag new component to dashboard we use `React.lazy` function to load code of component
**NOTES:**
- We created new type of registry using functional approach in favor of class approach that we are using now for loading plugin charts
- We have some basic predefined rules for dynamic components
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
https://user-images.githubusercontent.com/56388545/138594705-32b5a862-295f-4111-a63b-d8e8c96fcb7e.mov
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (26c0d65) into [master](https://codecov.io/gh/apache/superset/commit/28e729b835d8195f3610f7131504441803e43406?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (28e729b) will **decrease** coverage by `0.02%`.
> The diff coverage is `40.35%`.
> :exclamation: Current head 26c0d65 differs from pull request most recent head e5b7040. Consider uploading reports for the commit e5b7040 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
- Coverage 66.31% 66.29% -0.03%
==========================================
Files 1595 1575 -20
Lines 62599 61605 -994
Branches 6297 6280 -17
==========================================
- Hits 41513 40839 -674
+ Misses 19440 19145 -295
+ Partials 1646 1621 -25
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.86% <40.35%> (-0.47%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `78.94% <0.00%> (-4.39%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `70.00% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rdComponents/ExampleComponent/ExampleComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvRXhhbXBsZUNvbXBvbmVudC9FeGFtcGxlQ29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...ions/dashboardComponents/ExampleComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvRXhhbXBsZUNvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `5.26% <5.26%> (ø)` | |
| [...ponents/gridComponents/new/NewDynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdEeW5hbWljQ29tcG9uZW50LnRzeA==) | `50.00% <50.00%> (ø)` | |
| ... and [214 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [28e729b...e5b7040](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8556f1c) into [master](https://codecov.io/gh/apache/superset/commit/37944e18d6dccb04a5a768134b6fc1f4a2e625a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (37944e1) will **decrease** coverage by `0.00%`.
> The diff coverage is `56.38%`.
> :exclamation: Current head 8556f1c differs from pull request most recent head 208e275. Consider uploading reports for the commit 208e275 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
- Coverage 76.89% 76.89% -0.01%
==========================================
Files 1038 1047 +9
Lines 55515 55670 +155
Branches 7564 7598 +34
==========================================
+ Hits 42690 42807 +117
- Misses 12575 12613 +38
Partials 250 250
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.93% <56.38%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `85.71% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rset-frontend/src/setup/setupDasboardComponents.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRGFzYm9hcmRDb21wb25lbnRzLnRz) | `0.00% <0.00%> (ø)` | |
| [...ashboardComponents/TestComponent/TestComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9UZXN0Q29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...zations/dashboardComponents/TestComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `42.85% <42.85%> (ø)` | |
| [superset-frontend/src/utils/functionalRegistry.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Z1bmN0aW9uYWxSZWdpc3RyeS50cw==) | `57.89% <57.89%> (ø)` | |
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `96.00% <66.66%> (-4.00%)` | :arrow_down: |
| ... and [44 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [37944e1...208e275](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (26c0d65) into [master](https://codecov.io/gh/apache/superset/commit/fa104fee9a20dbd2175f60c50043886b8b8f7408?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa104fe) will **increase** coverage by `0.33%`.
> The diff coverage is `40.35%`.
> :exclamation: Current head 26c0d65 differs from pull request most recent head c2a0516. Consider uploading reports for the commit c2a0516 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
+ Coverage 65.95% 66.29% +0.33%
==========================================
Files 1584 1575 -9
Lines 62063 61605 -458
Branches 6273 6280 +7
==========================================
- Hits 40934 40839 -95
+ Misses 19508 19145 -363
Partials 1621 1621
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.86% <40.35%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `78.94% <0.00%> (-4.39%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `70.00% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rdComponents/ExampleComponent/ExampleComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvRXhhbXBsZUNvbXBvbmVudC9FeGFtcGxlQ29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...ions/dashboardComponents/ExampleComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvRXhhbXBsZUNvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `5.26% <5.26%> (ø)` | |
| [...ponents/gridComponents/new/NewDynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdEeW5hbWljQ29tcG9uZW50LnRzeA==) | `50.00% <50.00%> (ø)` | |
| ... and [92 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fa104fe...c2a0516](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (369afd4) into [master](https://codecov.io/gh/apache/superset/commit/0a33fcf31818216f6e6be9fa315af907ae9413c9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0a33fcf) will **increase** coverage by `9.71%`.
> The diff coverage is `54.00%`.
> :exclamation: Current head 369afd4 differs from pull request most recent head 7ee2be4. Consider uploading reports for the commit 7ee2be4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
+ Coverage 67.17% 76.89% +9.71%
==========================================
Files 1609 1045 -564
Lines 64797 55698 -9099
Branches 6855 7606 +751
==========================================
- Hits 43530 42830 -700
+ Misses 19411 12618 -6793
+ Partials 1856 250 -1606
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.94% <54.00%> (+17.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `85.71% <ø> (+10.71%)` | :arrow_up: |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rset-frontend/src/setup/setupDasboardComponents.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRGFzYm9hcmRDb21wb25lbnRzLnRz) | `0.00% <0.00%> (ø)` | |
| [...ashboardComponents/TestComponent/TestComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9UZXN0Q29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...zations/dashboardComponents/TestComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `42.10% <42.10%> (ø)` | |
| [superset-frontend/src/utils/functionalRegistry.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Z1bmN0aW9uYWxSZWdpc3RyeS50cw==) | `57.89% <57.89%> (ø)` | |
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `96.00% <66.66%> (+5.67%)` | :arrow_up: |
| ... and [1264 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0a33fcf...7ee2be4](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #17208:
URL: https://github.com/apache/superset/pull/17208#discussion_r785743112
##########
File path: superset-frontend/src/visualizations/dashboardComponents/TestComponent/TestComponent.tsx
##########
@@ -0,0 +1,27 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { JsonObject } from '@superset-ui/core';
+
+// TODO: POC only component can be removed after PR approved
+const TestComponent = ({ dashboardData }: JsonObject) => (
+ <div>We have next keys: {Object.keys(dashboardData).join(', ')}</div>
Review comment:
nit:
```suggestion
<div>We have the following keys: {Object.keys(dashboardData).join(', ')}</div>
```
##########
File path: superset-frontend/src/dashboard/components/gridComponents/DynamicComponent.tsx
##########
@@ -0,0 +1,184 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { FC, Suspense } from 'react';
+import { JsonObject, t } from '@superset-ui/core';
+import backgroundStyleOptions from 'src/dashboard/util/backgroundStyleOptions';
+import cx from 'classnames';
+import { useSelector } from 'react-redux';
+import DragDroppable from '../dnd/DragDroppable';
+import { COLUMN_TYPE, ROW_TYPE } from '../../util/componentTypes';
+import WithPopoverMenu from '../menu/WithPopoverMenu';
+import ResizableContainer from '../resizable/ResizableContainer';
+import {
+ BACKGROUND_TRANSPARENT,
+ GRID_BASE_UNIT,
+ GRID_MIN_COLUMN_COUNT,
+} from '../../util/constants';
+import HoverMenu from '../menu/HoverMenu';
+import DeleteComponentButton from '../DeleteComponentButton';
+import BackgroundStyleDropdown from '../menu/BackgroundStyleDropdown';
+import dashboardComponents from '../../../visualizations/presets/dashboardComponents';
+import { RootState } from '../../types';
+import { NativeFiltersState } from '../../reducers/types';
+import { DataMaskStateWithId } from '../../../dataMask/types';
+
+type DashboardData = {
Review comment:
nit: I'd rename this to `DashboardComponentMetadata` or something similar.
##########
File path: superset-frontend/src/setup/setupDasboardComponents.ts
##########
@@ -0,0 +1,31 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*
+ This file can be overridden from outside by custom config, it will add/delete new components to existing config in
+ superset-frontend/src/visualizations/presets/dashboardComponents.ts file
+ */
+
+import dashboardComponentsRegistry from '../visualizations/presets/dashboardComponents';
+import test from '../visualizations/dashboardComponents/TestComponent';
+
+export default function setupDashboardComponents() {
+ // TODO: can be removed after POC approved
+ dashboardComponentsRegistry.set('test', test);
Review comment:
Let's disable this by default and move instructions for enabling this test component in the PR description (I assume the import also needs to be commented out).
```suggestion
// Add custom dashboard components here. Example:
// dashboardComponentsRegistry.set('test', test);
```
##########
File path: superset-frontend/src/visualizations/dashboardComponents/TestComponent/index.ts
##########
@@ -0,0 +1,28 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+// TODO: POC only component can be removed after PR approved
+export default {
+ metadata: {
+ name: 'Test',
+ description: 'Test description',
+ iconName: 'filter',
+ },
+ loadComponent: () => import('./TestComponent'),
Review comment:
Should we rather call this an "Example component" to disambiguate from regular tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e5b7040) into [master](https://codecov.io/gh/apache/superset/commit/28e729b835d8195f3610f7131504441803e43406?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (28e729b) will **decrease** coverage by `0.04%`.
> The diff coverage is `44.26%`.
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
- Coverage 66.31% 66.26% -0.05%
==========================================
Files 1595 1603 +8
Lines 62599 62715 +116
Branches 6297 6316 +19
==========================================
+ Hits 41513 41559 +46
- Misses 19440 19507 +67
- Partials 1646 1649 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.29% <44.26%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `42.04% <ø> (ø)` | |
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `78.94% <0.00%> (-4.39%)` | :arrow_down: |
| [...ilterScopingModal/CrossFilterScopingForm/index.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nyb3NzRmlsdGVyU2NvcGluZ01vZGFsL0Nyb3NzRmlsdGVyU2NvcGluZ0Zvcm0vaW5kZXgudHN4) | `83.33% <ø> (ø)` | |
| [...components/DashboardBuilder/DashboardContainer.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIvRGFzaGJvYXJkQ29udGFpbmVyLnRzeA==) | `67.64% <ø> (ø)` | |
| [...src/dashboard/components/DashboardBuilder/state.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIvc3RhdGUudHM=) | `68.96% <ø> (ø)` | |
| [...nd/src/dashboard/components/FiltersBadge/index.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9pbmRleC50c3g=) | `86.11% <ø> (ø)` | |
| [...src/dashboard/components/FiltersBadge/selectors.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9zZWxlY3RvcnMudHM=) | `70.64% <ø> (ø)` | |
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `48.33% <ø> (ø)` | |
| ... and [58 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [28e729b...e5b7040](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (208e275) into [master](https://codecov.io/gh/apache/superset/commit/4316fe6ae64522ff5ac31383b378b94be786ad60?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4316fe6) will **decrease** coverage by `0.07%`.
> The diff coverage is `55.20%`.
> :exclamation: Current head 208e275 differs from pull request most recent head 369afd4. Consider uploading reports for the commit 369afd4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
- Coverage 76.96% 76.89% -0.08%
==========================================
Files 1037 1047 +10
Lines 55608 55672 +64
Branches 7588 7598 +10
==========================================
+ Hits 42800 42807 +7
- Misses 12558 12615 +57
Partials 250 250
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.92% <55.20%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `85.71% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rset-frontend/src/setup/setupDasboardComponents.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRGFzYm9hcmRDb21wb25lbnRzLnRz) | `0.00% <0.00%> (ø)` | |
| [...ashboardComponents/TestComponent/TestComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9UZXN0Q29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...zations/dashboardComponents/TestComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `42.85% <42.85%> (ø)` | |
| [superset-frontend/src/utils/functionalRegistry.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Z1bmN0aW9uYWxSZWdpc3RyeS50cw==) | `57.89% <57.89%> (ø)` | |
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `96.00% <66.66%> (-4.00%)` | :arrow_down: |
| ... and [54 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4316fe6...369afd4](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (369afd4) into [master](https://codecov.io/gh/apache/superset/commit/4954d5232958890c36eb97ba114d74105fa25ca5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4954d52) will **increase** coverage by `9.81%`.
> The diff coverage is `54.00%`.
> :exclamation: Current head 369afd4 differs from pull request most recent head 503eea8. Consider uploading reports for the commit 503eea8 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
+ Coverage 67.08% 76.89% +9.81%
==========================================
Files 1609 1045 -564
Lines 64897 55698 -9199
Branches 6866 7606 +740
==========================================
- Hits 43533 42830 -703
+ Misses 19498 12618 -6880
+ Partials 1866 250 -1616
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.94% <54.00%> (+17.17%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `85.71% <ø> (+10.71%)` | :arrow_up: |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rset-frontend/src/setup/setupDasboardComponents.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRGFzYm9hcmRDb21wb25lbnRzLnRz) | `0.00% <0.00%> (ø)` | |
| [...ashboardComponents/TestComponent/TestComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9UZXN0Q29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...zations/dashboardComponents/TestComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `42.10% <42.10%> (ø)` | |
| [superset-frontend/src/utils/functionalRegistry.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Z1bmN0aW9uYWxSZWdpc3RyeS50cw==) | `57.89% <57.89%> (ø)` | |
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `96.00% <66.66%> (+5.67%)` | :arrow_up: |
| ... and [1271 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4954d52...503eea8](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (56a4e2a) into [master](https://codecov.io/gh/apache/superset/commit/37944e18d6dccb04a5a768134b6fc1f4a2e625a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (37944e1) will **decrease** coverage by `0.00%`.
> The diff coverage is `55.20%`.
> :exclamation: Current head 56a4e2a differs from pull request most recent head 208e275. Consider uploading reports for the commit 208e275 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
- Coverage 76.89% 76.88% -0.01%
==========================================
Files 1038 1047 +9
Lines 55515 55672 +157
Branches 7564 7598 +34
==========================================
+ Hits 42690 42806 +116
- Misses 12575 12616 +41
Partials 250 250
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.92% <55.20%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `85.71% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rset-frontend/src/setup/setupDasboardComponents.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRGFzYm9hcmRDb21wb25lbnRzLnRz) | `0.00% <0.00%> (ø)` | |
| [...ashboardComponents/TestComponent/TestComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9UZXN0Q29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...zations/dashboardComponents/TestComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `42.85% <42.85%> (ø)` | |
| [superset-frontend/src/utils/functionalRegistry.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Z1bmN0aW9uYWxSZWdpc3RyeS50cw==) | `57.89% <57.89%> (ø)` | |
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `96.00% <66.66%> (-4.00%)` | :arrow_down: |
| ... and [44 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [37944e1...208e275](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e374836) into [master](https://codecov.io/gh/apache/superset/commit/4954d5232958890c36eb97ba114d74105fa25ca5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4954d52) will **decrease** coverage by `0.02%`.
> The diff coverage is `53.53%`.
> :exclamation: Current head e374836 differs from pull request most recent head d54bd9d. Consider uploading reports for the commit d54bd9d to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
- Coverage 67.08% 67.05% -0.03%
==========================================
Files 1609 1617 +8
Lines 64897 64991 +94
Branches 6866 6875 +9
==========================================
+ Hits 43533 43581 +48
- Misses 19498 19544 +46
Partials 1866 1866
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.76% <53.53%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `75.00% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rset-frontend/src/setup/setupDasboardComponents.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRGFzYm9hcmRDb21wb25lbnRzLnRz) | `0.00% <0.00%> (ø)` | |
| [...ashboardComponents/TestComponent/TestComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9UZXN0Q29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...zations/dashboardComponents/TestComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `45.71% <45.71%> (ø)` | |
| [superset-frontend/src/utils/functionalRegistry.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Z1bmN0aW9uYWxSZWdpc3RyeS50cw==) | `52.17% <52.17%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4954d52...d54bd9d](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d54bd9d) into [master](https://codecov.io/gh/apache/superset/commit/4954d5232958890c36eb97ba114d74105fa25ca5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4954d52) will **decrease** coverage by `0.75%`.
> The diff coverage is `40.35%`.
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
- Coverage 67.08% 66.32% -0.76%
==========================================
Files 1609 1575 -34
Lines 64897 61563 -3334
Branches 6866 6249 -617
==========================================
- Hits 43533 40830 -2703
+ Misses 19498 19135 -363
+ Partials 1866 1598 -268
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.90% <40.35%> (-2.88%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `78.94% <0.00%> (-11.38%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `70.00% <ø> (-5.00%)` | :arrow_down: |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rdComponents/ExampleComponent/ExampleComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvRXhhbXBsZUNvbXBvbmVudC9FeGFtcGxlQ29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...ions/dashboardComponents/ExampleComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvRXhhbXBsZUNvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `5.26% <5.26%> (ø)` | |
| [...ponents/gridComponents/new/NewDynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdEeW5hbWljQ29tcG9uZW50LnRzeA==) | `50.00% <50.00%> (ø)` | |
| ... and [515 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4954d52...d54bd9d](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (369afd4) into [master](https://codecov.io/gh/apache/superset/commit/8ebec6016ecd0b729ff149bf1bb051da808f3f95?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ebec60) will **increase** coverage by `9.79%`.
> The diff coverage is `54.00%`.
> :exclamation: Current head 369afd4 differs from pull request most recent head eba9e97. Consider uploading reports for the commit eba9e97 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
+ Coverage 67.10% 76.89% +9.79%
==========================================
Files 1609 1045 -564
Lines 64897 55698 -9199
Branches 6866 7606 +740
==========================================
- Hits 43547 42830 -717
+ Misses 19484 12618 -6866
+ Partials 1866 250 -1616
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.94% <54.00%> (+17.17%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `85.71% <ø> (+10.71%)` | :arrow_up: |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rset-frontend/src/setup/setupDasboardComponents.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRGFzYm9hcmRDb21wb25lbnRzLnRz) | `0.00% <0.00%> (ø)` | |
| [...ashboardComponents/TestComponent/TestComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9UZXN0Q29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...zations/dashboardComponents/TestComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `42.10% <42.10%> (ø)` | |
| [superset-frontend/src/utils/functionalRegistry.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Z1bmN0aW9uYWxSZWdpc3RyeS50cw==) | `57.89% <57.89%> (ø)` | |
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `96.00% <66.66%> (+5.67%)` | :arrow_up: |
| ... and [1270 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8ebec60...eba9e97](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (369afd4) into [master](https://codecov.io/gh/apache/superset/commit/4316fe6ae64522ff5ac31383b378b94be786ad60?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4316fe6) will **decrease** coverage by `0.07%`.
> The diff coverage is `54.00%`.
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
- Coverage 76.96% 76.89% -0.08%
==========================================
Files 1037 1045 +8
Lines 55608 55698 +90
Branches 7588 7606 +18
==========================================
+ Hits 42800 42830 +30
- Misses 12558 12618 +60
Partials 250 250
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.94% <54.00%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `85.71% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rset-frontend/src/setup/setupDasboardComponents.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRGFzYm9hcmRDb21wb25lbnRzLnRz) | `0.00% <0.00%> (ø)` | |
| [...ashboardComponents/TestComponent/TestComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9UZXN0Q29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...zations/dashboardComponents/TestComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `42.10% <42.10%> (ø)` | |
| [superset-frontend/src/utils/functionalRegistry.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Z1bmN0aW9uYWxSZWdpc3RyeS50cw==) | `57.89% <57.89%> (ø)` | |
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `96.00% <66.66%> (-4.00%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4316fe6...369afd4](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e374836) into [master](https://codecov.io/gh/apache/superset/commit/4954d5232958890c36eb97ba114d74105fa25ca5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4954d52) will **decrease** coverage by `0.02%`.
> The diff coverage is `53.53%`.
> :exclamation: Current head e374836 differs from pull request most recent head aca538a. Consider uploading reports for the commit aca538a to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
- Coverage 67.08% 67.05% -0.03%
==========================================
Files 1609 1617 +8
Lines 64897 64991 +94
Branches 6866 6875 +9
==========================================
+ Hits 43533 43581 +48
- Misses 19498 19544 +46
Partials 1866 1866
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.76% <53.53%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `75.00% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rset-frontend/src/setup/setupDasboardComponents.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRGFzYm9hcmRDb21wb25lbnRzLnRz) | `0.00% <0.00%> (ø)` | |
| [...ashboardComponents/TestComponent/TestComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9UZXN0Q29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...zations/dashboardComponents/TestComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `45.71% <45.71%> (ø)` | |
| [superset-frontend/src/utils/functionalRegistry.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Z1bmN0aW9uYWxSZWdpc3RyeS50cw==) | `52.17% <52.17%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4954d52...aca538a](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (369afd4) into [master](https://codecov.io/gh/apache/superset/commit/1c12167d8d12b6a092356c008286f6f07f1c9954?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c12167) will **decrease** coverage by `0.29%`.
> The diff coverage is `54.00%`.
> :exclamation: Current head 369afd4 differs from pull request most recent head ccb5853. Consider uploading reports for the commit ccb5853 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
- Coverage 77.19% 76.89% -0.30%
==========================================
Files 1036 1045 +9
Lines 55687 55698 +11
Branches 7627 7606 -21
==========================================
- Hits 42987 42830 -157
- Misses 12444 12618 +174
+ Partials 256 250 -6
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.94% <54.00%> (-0.48%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `85.71% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rset-frontend/src/setup/setupDasboardComponents.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRGFzYm9hcmRDb21wb25lbnRzLnRz) | `0.00% <0.00%> (ø)` | |
| [...ashboardComponents/TestComponent/TestComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9UZXN0Q29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...zations/dashboardComponents/TestComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `42.10% <42.10%> (ø)` | |
| [superset-frontend/src/utils/functionalRegistry.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Z1bmN0aW9uYWxSZWdpc3RyeS50cw==) | `57.89% <57.89%> (ø)` | |
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `96.00% <66.66%> (-0.88%)` | :arrow_down: |
| ... and [88 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1c12167...ccb5853](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (503eea8) into [master](https://codecov.io/gh/apache/superset/commit/4954d5232958890c36eb97ba114d74105fa25ca5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4954d52) will **decrease** coverage by `0.02%`.
> The diff coverage is `53.53%`.
> :exclamation: Current head 503eea8 differs from pull request most recent head e374836. Consider uploading reports for the commit e374836 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
- Coverage 67.08% 67.05% -0.03%
==========================================
Files 1609 1617 +8
Lines 64897 64991 +94
Branches 6866 6875 +9
==========================================
+ Hits 43533 43581 +48
- Misses 19498 19544 +46
Partials 1866 1866
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.76% <53.53%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `75.00% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rset-frontend/src/setup/setupDasboardComponents.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRGFzYm9hcmRDb21wb25lbnRzLnRz) | `0.00% <0.00%> (ø)` | |
| [...ashboardComponents/TestComponent/TestComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9UZXN0Q29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...zations/dashboardComponents/TestComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `45.71% <45.71%> (ø)` | |
| [superset-frontend/src/utils/functionalRegistry.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Z1bmN0aW9uYWxSZWdpc3RyeS50cw==) | `52.17% <52.17%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4954d52...e374836](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (369afd4) into [master](https://codecov.io/gh/apache/superset/commit/8ebec6016ecd0b729ff149bf1bb051da808f3f95?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ebec60) will **increase** coverage by `9.79%`.
> The diff coverage is `54.00%`.
> :exclamation: Current head 369afd4 differs from pull request most recent head 94e2d5b. Consider uploading reports for the commit 94e2d5b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
+ Coverage 67.10% 76.89% +9.79%
==========================================
Files 1609 1045 -564
Lines 64897 55698 -9199
Branches 6866 7606 +740
==========================================
- Hits 43547 42830 -717
+ Misses 19484 12618 -6866
+ Partials 1866 250 -1616
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.94% <54.00%> (+17.17%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `85.71% <ø> (+10.71%)` | :arrow_up: |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rset-frontend/src/setup/setupDasboardComponents.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRGFzYm9hcmRDb21wb25lbnRzLnRz) | `0.00% <0.00%> (ø)` | |
| [...ashboardComponents/TestComponent/TestComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9UZXN0Q29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...zations/dashboardComponents/TestComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `42.10% <42.10%> (ø)` | |
| [superset-frontend/src/utils/functionalRegistry.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Z1bmN0aW9uYWxSZWdpc3RyeS50cw==) | `57.89% <57.89%> (ø)` | |
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `96.00% <66.66%> (+5.67%)` | :arrow_up: |
| ... and [1270 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8ebec60...94e2d5b](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simcha90 commented on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
simcha90 commented on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-1014541656
> First pass comments. Code looks great, but my main question is shouldn't we move the central building blocks to `@superset-ui/core`, like the central types/interfaces and registries? If we'd do that, we could
>
> 1. Develop the plugins independently from the Superset codebase.
> 2. Add a dashboard component template to the Yeoman generator. See #18027 which was merged just recently and made the system work again after the monorepo migration
> 3. Publish dashboard component plugins to npm
> 4. Pin plugins to specific versions etc
>
> Etc. Also, I think we should add tests as early as possible, which are missing here. By moving the relevant parts to `@superset-ui/core` we would automatically have 100 % test coverage requirements, but in addition, we should also have at least a few RTL tests that make sure the relevant Dashboard flows work (viewing a dashboard with a plugin + adding and removing a component)
May be functional registry can be moved to `superset-core`, but meantime I don't see some special need for it because:
1. we can do it also now, I think this PR enough for our company needs to start develop our plugins
2. I'm not sure that we have capacity for it, @amitmiran137 do we have?
3, 4 Can be done also now, we don't need move code to `superset-core` for these things
P.S. other stuff fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (26c0d65) into [master](https://codecov.io/gh/apache/superset/commit/fa104fee9a20dbd2175f60c50043886b8b8f7408?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa104fe) will **increase** coverage by `0.33%`.
> The diff coverage is `40.35%`.
> :exclamation: Current head 26c0d65 differs from pull request most recent head 3108ae0. Consider uploading reports for the commit 3108ae0 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
+ Coverage 65.95% 66.29% +0.33%
==========================================
Files 1584 1575 -9
Lines 62063 61605 -458
Branches 6273 6280 +7
==========================================
- Hits 40934 40839 -95
+ Misses 19508 19145 -363
Partials 1621 1621
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.86% <40.35%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `78.94% <0.00%> (-4.39%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `70.00% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rdComponents/ExampleComponent/ExampleComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvRXhhbXBsZUNvbXBvbmVudC9FeGFtcGxlQ29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...ions/dashboardComponents/ExampleComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvRXhhbXBsZUNvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `5.26% <5.26%> (ø)` | |
| [...ponents/gridComponents/new/NewDynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdEeW5hbWljQ29tcG9uZW50LnRzeA==) | `50.00% <50.00%> (ø)` | |
| ... and [92 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fa104fe...3108ae0](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 merged pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
amitmiran137 merged pull request #17208:
URL: https://github.com/apache/superset/pull/17208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (26c0d65) into [master](https://codecov.io/gh/apache/superset/commit/fa104fee9a20dbd2175f60c50043886b8b8f7408?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa104fe) will **increase** coverage by `0.33%`.
> The diff coverage is `40.35%`.
> :exclamation: Current head 26c0d65 differs from pull request most recent head 8db30ef. Consider uploading reports for the commit 8db30ef to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
+ Coverage 65.95% 66.29% +0.33%
==========================================
Files 1584 1575 -9
Lines 62063 61605 -458
Branches 6273 6280 +7
==========================================
- Hits 40934 40839 -95
+ Misses 19508 19145 -363
Partials 1621 1621
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.86% <40.35%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `78.94% <0.00%> (-4.39%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `70.00% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rdComponents/ExampleComponent/ExampleComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvRXhhbXBsZUNvbXBvbmVudC9FeGFtcGxlQ29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...ions/dashboardComponents/ExampleComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvRXhhbXBsZUNvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `5.26% <5.26%> (ø)` | |
| [...ponents/gridComponents/new/NewDynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdEeW5hbWljQ29tcG9uZW50LnRzeA==) | `50.00% <50.00%> (ø)` | |
| ... and [92 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fa104fe...8db30ef](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simcha90 commented on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
simcha90 commented on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-1020882263
@zhaoyongjie done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d54bd9d) into [master](https://codecov.io/gh/apache/superset/commit/fa104fee9a20dbd2175f60c50043886b8b8f7408?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa104fe) will **increase** coverage by `0.36%`.
> The diff coverage is `40.35%`.
> :exclamation: Current head d54bd9d differs from pull request most recent head 26c0d65. Consider uploading reports for the commit 26c0d65 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
+ Coverage 65.95% 66.32% +0.36%
==========================================
Files 1584 1575 -9
Lines 62063 61563 -500
Branches 6273 6249 -24
==========================================
- Hits 40934 40830 -104
+ Misses 19508 19135 -373
+ Partials 1621 1598 -23
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.90% <40.35%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `78.94% <0.00%> (-4.39%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `70.00% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rdComponents/ExampleComponent/ExampleComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvRXhhbXBsZUNvbXBvbmVudC9FeGFtcGxlQ29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...ions/dashboardComponents/ExampleComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvRXhhbXBsZUNvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `5.26% <5.26%> (ø)` | |
| [...ponents/gridComponents/new/NewDynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdEeW5hbWljQ29tcG9uZW50LnRzeA==) | `50.00% <50.00%> (ø)` | |
| ... and [139 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fa104fe...26c0d65](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] simcha90 commented on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
simcha90 commented on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-1020882263
@zhaoyongjie done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (26c0d65) into [master](https://codecov.io/gh/apache/superset/commit/fa104fee9a20dbd2175f60c50043886b8b8f7408?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa104fe) will **increase** coverage by `0.33%`.
> The diff coverage is `40.35%`.
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
+ Coverage 65.95% 66.29% +0.33%
==========================================
Files 1584 1575 -9
Lines 62063 61605 -458
Branches 6273 6280 +7
==========================================
- Hits 40934 40839 -95
+ Misses 19508 19145 -363
Partials 1621 1621
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.86% <40.35%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `78.94% <0.00%> (-4.39%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `70.00% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rdComponents/ExampleComponent/ExampleComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvRXhhbXBsZUNvbXBvbmVudC9FeGFtcGxlQ29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...ions/dashboardComponents/ExampleComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvRXhhbXBsZUNvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `5.26% <5.26%> (ø)` | |
| [...ponents/gridComponents/new/NewDynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdEeW5hbWljQ29tcG9uZW50LnRzeA==) | `50.00% <50.00%> (ø)` | |
| ... and [92 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fa104fe...26c0d65](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (208e275) into [master](https://codecov.io/gh/apache/superset/commit/37944e18d6dccb04a5a768134b6fc1f4a2e625a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (37944e1) will **decrease** coverage by `0.00%`.
> The diff coverage is `55.20%`.
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
- Coverage 76.89% 76.89% -0.01%
==========================================
Files 1038 1047 +9
Lines 55515 55672 +157
Branches 7564 7598 +34
==========================================
+ Hits 42690 42807 +117
- Misses 12575 12615 +40
Partials 250 250
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.92% <55.20%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `85.71% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rset-frontend/src/setup/setupDasboardComponents.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRGFzYm9hcmRDb21wb25lbnRzLnRz) | `0.00% <0.00%> (ø)` | |
| [...ashboardComponents/TestComponent/TestComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9UZXN0Q29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...zations/dashboardComponents/TestComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `42.85% <42.85%> (ø)` | |
| [superset-frontend/src/utils/functionalRegistry.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Z1bmN0aW9uYWxSZWdpc3RyeS50cw==) | `57.89% <57.89%> (ø)` | |
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `96.00% <66.66%> (-4.00%)` | :arrow_down: |
| ... and [44 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [37944e1...208e275](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (503eea8) into [master](https://codecov.io/gh/apache/superset/commit/4954d5232958890c36eb97ba114d74105fa25ca5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4954d52) will **decrease** coverage by `0.02%`.
> The diff coverage is `53.53%`.
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
- Coverage 67.08% 67.05% -0.03%
==========================================
Files 1609 1617 +8
Lines 64897 64991 +94
Branches 6866 6875 +9
==========================================
+ Hits 43533 43581 +48
- Misses 19498 19544 +46
Partials 1866 1866
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.76% <53.53%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `75.00% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rset-frontend/src/setup/setupDasboardComponents.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRGFzYm9hcmRDb21wb25lbnRzLnRz) | `0.00% <0.00%> (ø)` | |
| [...ashboardComponents/TestComponent/TestComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9UZXN0Q29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...zations/dashboardComponents/TestComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `45.71% <45.71%> (ø)` | |
| [superset-frontend/src/utils/functionalRegistry.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Z1bmN0aW9uYWxSZWdpc3RyeS50cw==) | `52.17% <52.17%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4954d52...503eea8](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e374836) into [master](https://codecov.io/gh/apache/superset/commit/4954d5232958890c36eb97ba114d74105fa25ca5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4954d52) will **decrease** coverage by `0.02%`.
> The diff coverage is `53.53%`.
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
- Coverage 67.08% 67.05% -0.03%
==========================================
Files 1609 1617 +8
Lines 64897 64991 +94
Branches 6866 6875 +9
==========================================
+ Hits 43533 43581 +48
- Misses 19498 19544 +46
Partials 1866 1866
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.76% <53.53%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `75.00% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rset-frontend/src/setup/setupDasboardComponents.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRGFzYm9hcmRDb21wb25lbnRzLnRz) | `0.00% <0.00%> (ø)` | |
| [...ashboardComponents/TestComponent/TestComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9UZXN0Q29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...zations/dashboardComponents/TestComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvVGVzdENvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `45.71% <45.71%> (ø)` | |
| [superset-frontend/src/utils/functionalRegistry.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Z1bmN0aW9uYWxSZWdpc3RyeS50cw==) | `52.17% <52.17%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4954d52...e374836](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17208: feat: Dynamic dashboard component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17208:
URL: https://github.com/apache/superset/pull/17208#issuecomment-950327477
# [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17208](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (26c0d65) into [master](https://codecov.io/gh/apache/superset/commit/28e729b835d8195f3610f7131504441803e43406?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (28e729b) will **decrease** coverage by `0.02%`.
> The diff coverage is `40.35%`.
> :exclamation: Current head 26c0d65 differs from pull request most recent head b65e977. Consider uploading reports for the commit b65e977 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17208 +/- ##
==========================================
- Coverage 66.31% 66.29% -0.03%
==========================================
Files 1595 1575 -20
Lines 62599 61605 -994
Branches 6297 6280 -17
==========================================
- Hits 41513 40839 -674
+ Misses 19440 19145 -295
+ Partials 1646 1621 -25
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.86% <40.35%> (-0.47%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/dashboard/components/BuilderComponentPane.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLnRzeA==) | `78.94% <0.00%> (-4.39%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | `100.00% <ø> (ø)` | |
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | `100.00% <ø> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `70.00% <ø> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [...rdComponents/ExampleComponent/ExampleComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvRXhhbXBsZUNvbXBvbmVudC9FeGFtcGxlQ29tcG9uZW50LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...ions/dashboardComponents/ExampleComponent/index.ts](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2Rhc2hib2FyZENvbXBvbmVudHMvRXhhbXBsZUNvbXBvbmVudC9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | |
| [...ard/components/gridComponents/DynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0R5bmFtaWNDb21wb25lbnQudHN4) | `5.26% <5.26%> (ø)` | |
| [...ponents/gridComponents/new/NewDynamicComponent.tsx](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdEeW5hbWljQ29tcG9uZW50LnRzeA==) | `50.00% <50.00%> (ø)` | |
| ... and [214 more](https://codecov.io/gh/apache/superset/pull/17208/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [28e729b...b65e977](https://codecov.io/gh/apache/superset/pull/17208?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org